From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150084.outbound.protection.outlook.com [40.107.15.84]) by sourceware.org (Postfix) with ESMTPS id 252173844008 for ; Tue, 6 Apr 2021 16:42:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 252173844008 Received: from AM5PR0601CA0037.eurprd06.prod.outlook.com (2603:10a6:203:68::23) by AM6PR08MB3989.eurprd08.prod.outlook.com (2603:10a6:20b:b0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.28; Tue, 6 Apr 2021 16:42:00 +0000 Received: from AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:68:cafe::3) by AM5PR0601CA0037.outlook.office365.com (2603:10a6:203:68::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.32 via Frontend Transport; Tue, 6 Apr 2021 16:42:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT030.mail.protection.outlook.com (10.152.16.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29 via Frontend Transport; Tue, 6 Apr 2021 16:42:00 +0000 Received: ("Tessian outbound 700fd1fc53d5:v90"); Tue, 06 Apr 2021 16:41:59 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0ef959ba2ebd3a60 X-CR-MTA-TID: 64aa7808 Received: from 905c7e79a2f1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DFA5CBC4-4F6E-454B-9C17-E10F93DAC5FD.1; Tue, 06 Apr 2021 16:41:52 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 905c7e79a2f1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 06 Apr 2021 16:41:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gJ8jYWbx9T+QHOPEu5uF5lGHlroj9mGEkfei5xa/gAlgnOUiD47VJsevxGZTE2q0bEKHED2daarSZ2icqfu5wHXCsASfg9KX4lZ0M/DlQAWNShr3H/A4GG7YHHGuDiA3oAczWPD5sQ39VSdEk8Zki23aAm3SDTdfeTahBNjgXYQsZ4dRM5h3cpo/NIHLKHNz0PXsTEIFwNbD4aWhdHkQkMvpMe/xVXB+RhEogsOyAECrSdMPKWv+SAV78MP2dfocm34VI4jlZovj5kTz1gWwqMCEPgEHLT/cuKDq7FV77/fNl6heMjeZiQjkqqKiQ23uckFQitnocE6QRDWaoVYB/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WZx9PpFUXGF0c0xfQIS5/ed+RBjoZOeIq2J6idNJDfU=; b=Y3iWYTbZXEh4kVG4GOdXUL6EqtdpJAjgSux6Bnd8Ztnf2gKShFx+mmtcZNEJgEbxcKXaPTfYX70Uwin/1EqoBRI/GaIqdaSlhuTV15E9yyOgDWxRV8bVRvCv0VJdwRRDcQyQxAkJn0pEulOXEWCT4HBt6kHj/1KgdwhBFBiw9561E+BCUBDhNACEeBo8wH4fgC4nHyKJgnKcOlQoXjO7ld8uVHNnr6eU+HzUy8x6fIRJTiDAwL00Ps7V/TzfVc28vQb1XaOsp8xygvkHs1/UWM8+LmEH5QzDUlBIBQ/0H3tMAzFvWvZBfEzECWAIOFnORTVr31xvy/sEKs11pxvcUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; Received: from PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) by PAXPR08MB6925.eurprd08.prod.outlook.com (2603:10a6:102:13a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.28; Tue, 6 Apr 2021 16:41:52 +0000 Received: from PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::c99f:671d:bb2c:f20b]) by PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::c99f:671d:bb2c:f20b%7]) with mapi id 15.20.3999.032; Tue, 6 Apr 2021 16:41:52 +0000 Date: Tue, 6 Apr 2021 17:41:50 +0100 From: Szabolcs Nagy To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Maninder Singh Subject: Re: [PATCH 02/15] elf: Fix data race in _dl_name_match_p [BZ #21349] Message-ID: <20210406164149.GN23289@arm.com> References: <3721784a79c9d2040297304b2a7216d7072ea838.1613390045.git.szabolcs.nagy@arm.com> <3622cbc0-faf9-defe-7924-fb849faa6cdc@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3622cbc0-faf9-defe-7924-fb849faa6cdc@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.55] X-ClientProxiedBy: LO2P265CA0496.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::21) To PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.55) by LO2P265CA0496.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.32 via Frontend Transport; Tue, 6 Apr 2021 16:41:51 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 00384a5b-d6cf-4dcf-6ae0-08d8f91ae678 X-MS-TrafficTypeDiagnostic: PAXPR08MB6925:|AM6PR08MB3989: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9iWseWhSBNdA+1ZwDrA+rH5N11uP84Gh5Wt1AAeoEzPfL9OiAn03zAkfeCM+ndonBdmresKe1ycMRIVsu3wHfcbisSUbz8h2tX/CZdaG14TycZLd9ZJJnmfC3IAOaDsvrxA2venNsJ/AETu3u8F5suH1gn42N7Qrr4u71X5dJQjNtAiJdGzDT74jS//b6Oy9da+6/+CnK7K2gFaS7vcsawV/teGqrA7wo+jqqlpU1M/y9CnMd14emaYfU7fu43EbdXRkHols1EwxwV0sJKjLLDY5gtSzbaG7l6Jutrtgd8I4NGTO8XDtToUx5yEnX+4Kk6QvYJG7BtK4bY3YEPZ7lJ+M0PMwUHHW2K93z2toO3y2zp9e7NV+lTUp7mW4KWXWVhIfP18MRkX2Q/+28E+Wv35ZfwO4AeFuPzaBkBjwAj7TLDGn6pifUR034OLp7tViw4M53ACJ4Pa0fjZ/EDr03bafqOpNZOM3ZVnhZKrmd12mpD7xmxsCfAtV6Kxtax1cz/hcHcuMmlUe8Yg1i+NAKm3eJEKUuh9uQO16jkRRx5qjFX4cRo7NIQLQr99t4o45dWLvO9uSel47eQ4GYJH8EHjFYGFRg6BzzCNKGas+DjFSX16TUFVpkR9YudvDjls+71WvDH3hCJCFKYdFdn/zRuP7cQv4HmI7r2750+8L1j7Y2sJQmjM9fBrMstyy/QFh X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6320.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39850400004)(396003)(346002)(376002)(366004)(136003)(8676002)(956004)(44832011)(6916009)(8936002)(83380400001)(5660300002)(66556008)(38100700001)(66476007)(26005)(52116002)(38350700001)(86362001)(55016002)(316002)(33656002)(7696005)(186003)(66946007)(53546011)(1076003)(2906002)(8886007)(36756003)(16526019)(478600001)(4326008)(2616005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZStvUmpDd3lOUUg4cHFJSGNPNFluYlp3SjZRRlpsckxuMUJJTlVrOWM4bEd0?= =?utf-8?B?OENNK1Z6T204SDF4SE9sUkNvQ3lsZ0pnd3hVd1laSTlhVkRiemcrT0Q1dzZr?= =?utf-8?B?NFJSaWEzcDhEemllR09lMUhjbVpuYlc4aGN6cU9FQUNBZlBMSCtPU3FkbGFt?= =?utf-8?B?SGo2M2NxYmFKNjJ5WnVmUmg3TElOUERZd2FKYUdKVXpqRVFtcnh4aXhTYmRh?= =?utf-8?B?Qm9ZT3FGQkNzS2VyT2RxNTBsZ0RZMnU5N2FGaUtiODQzVGVnMkxPVmU2a1Zz?= =?utf-8?B?UHU4QWVtdXVscXhacHdIakhCeVd0TDJ2R05xeTR3WnZzQ1FYMEpJazFBOUIv?= =?utf-8?B?QktnTTFtd3l3MFNTa0dCd25PVDQ3NnN1ckpCUjRSSThvMlhNRDMxWEhOZVdu?= =?utf-8?B?cUl4cGVFVEpMeXBaNlZYalRtMHZTL3FNTEo5amtZYmxIS3k2WkN2Tk9oUFNV?= =?utf-8?B?dkF2K2pNYzR6Z1VnY21iL014T0JzQXlRdCtHRTRscThtVVFmeWw4czBEUCs5?= =?utf-8?B?Tklhc2xQKy9UUTQwVk1EV2lnUGd6Q0cyNnVuVHdJQXZGdEV1NWdNVGxhWm42?= =?utf-8?B?TG5QQTVnWnJIN01PbHpwWFRodlY5aGptSHFKRnJ6dzhxbXUwL0xHRHZ4OVc5?= =?utf-8?B?WStzdTh4a1NJOFRuZDlzRzduV2todjJmVWVqUmEyY05sSlJYcWFKdTBORExs?= =?utf-8?B?dTVkSXFMcm45dWxiR1IrOU1tUnltWUxlVVZ2aG1nMVArL2hvaHQxUVg4UUpN?= =?utf-8?B?SkdLWG9vT1hQM0JtbTJoWmdIbEowWCtsYU00T2c0aWw2d0xIQXl6WlhjY3h5?= =?utf-8?B?VktKTWZiUkxtZlIvK3FJVzdpQUF2amZLRzVVWnhoVUpzWnEyVHpwSlVpMWNG?= =?utf-8?B?QjVLU2d1UUpMNTFwOVBYSDJvbGNzckdlM2JBdFhHdTI5NGp0bWF3a2hqV0oz?= =?utf-8?B?RUY5MDJ2bWM3VkVtdFZ0KzdQclhMaE54U1RzY3dxdXRiODkvNmNRR2xSNnNL?= =?utf-8?B?aFFwS3poZjVBMVV0VlNPcENSamFOL0g2d1RFN2llM1ovWVJVTHNVMm9YSHlx?= =?utf-8?B?SVVyU1J0VXB1MjBFMUw4cnpzYWlsVVVINkNRdGNpUHIxSG9lQmlobW9JL2dB?= =?utf-8?B?TGFucVdCaXVYby9IQWNFckVhR29tRUNoUnl6VlpTcVN6MWIrMHN2UnRqUWVL?= =?utf-8?B?YXdEL0RWWkx3a2lZUTR4S1VIRVBCckp0dFhnK3ZwdmlybTA4L0RGVXJ1Vm91?= =?utf-8?B?TDN0QUZNNmpGWWdzeWdLZ25aaWFrdHgwS2huUHJmNHZyc2xEYXlWTFJvalcx?= =?utf-8?B?NkwyN2hvVkFMSUJUVE5jVURqcktVdGNWaDFvOG8zZnRLa1JEVTBwRzJpU3BY?= =?utf-8?B?dnhmRmwydUgwRXBoc2dMTU9YWE55d3ByamxRYlh3aUxOTndsZEhJSmZzemtm?= =?utf-8?B?aUQ1ZEs0a3IvTW5UYnRBNWFUVzM1R1Q1VzlORzRnc0o1Z00xZmhsZzNZbUZ5?= =?utf-8?B?V3JRbVo1NkxaQzRqZmwycTA4N1ZQUHNRalFDSmxWV3VvOEhmYWZMbk1EZXBH?= =?utf-8?B?NFdqZjJ0VUtDU0RlY2pTckYrelN6VXBaVnJRNC96d3phMDduenBVeEttWmY3?= =?utf-8?B?ZHZqUlF2UUhqd0JkSHlldU85d2ZCblhkd2pmL0V3R2h5RG5kYTZQWU15SXc0?= =?utf-8?B?RzlCZVdCRlNyNkF0elJPZFIrdWdZa3haT1dlY0pUR1VBS0dZUFFqTWZXaU5n?= =?utf-8?Q?PoSecZutdUHSQlat1kz5nA6uzCKDCrCsc3GGGbl?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6925 Original-Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 7e7f92d5-55af-4b1d-70ec-08d8f91ae159 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7KmGiD40shds+UfQPziZqf9CGj14dR0Jh1VWx/bjo4Q4L6b2i6DPE+czmRIlbkhFU+qhrPKDSidiqZmke8bqtGt4Sm1rilhvupBZjkCZnmeKKzkXFNNor5wV1dlf04PU0JKmxjirGEXZuJSfTxbZm0yYRbq3+ff8rsSaNxlXXny1pJoq1r8oENrgAfooyTTlinK3kcGDXFZI/3QseS98LElPlrvtOasHUlqEZP674NS9PZm9UTDyg7GmgQUIwE93WrksYYgIiWRAwsPV7SH/a0XOSp9nLug94DmQRT//A+aURj5l30m6TqO3UB6x433osVrGTg5pnkLF3zcDjgIlUSp/9sl31lvokikQSgO9/1/AfiZIMGNAxzkFyf330PkOKpjV9S3wO7GN0k6m4O6BnfE78n7neCIbDLdUGtVt2UiAGU4PEQ/b+aLFMtOrx528JEwdnAQHNfRTRzuiS/5TaYrQS3Q+i0G59cFqGUbQJIjQjEFRbdVRPrL8JiOPFm+lWXu5ObLw3K6znjlUzWKT+c3dnxsiCxsOwQG5BLP+BHLLWcKN4p/xx6cy3sFdtCQRXwoyCS3+PEDEf0A9vySSimatC1bCKlpimzPYJPY6FQP6GCuEistmNqQ/L21Ej1EvxE1cv6GFwNcxlUjP/P220pRQoKGoqP8brY743s9OX9s= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(346002)(396003)(39840400004)(376002)(46966006)(36840700001)(81166007)(2906002)(16526019)(186003)(356005)(33656002)(83380400001)(316002)(26005)(5660300002)(36756003)(4326008)(107886003)(53546011)(47076005)(478600001)(6862004)(36860700001)(2616005)(70586007)(956004)(82310400003)(8886007)(44832011)(55016002)(8936002)(336012)(70206006)(8676002)(7696005)(86362001)(1076003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2021 16:42:00.3432 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 00384a5b-d6cf-4dcf-6ae0-08d8f91ae678 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3989 X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2021 16:42:04 -0000 The 04/01/2021 11:01, Adhemerval Zanella wrote: > On 15/02/2021 08:56, Szabolcs Nagy via Libc-alpha wrote: > > From: Maninder Singh > > > > dlopen updates libname_list by writing to lastp->next, but concurrent > > reads in _dl_name_match_p were not synchronized when it was called > > without holding GL(dl_load_lock), which can happen during lazy symbol > > resolution. > > > > This patch fixes the race between _dl_name_match_p reading lastp->next > > and add_name_to_object writing to it. This could cause segfault on > > targets with weak memory order when lastp->next->name is read, which > > was observed on an arm system. Fixes bug 21349. > > > > (Code is from Maninder Singh, comments and description is from Szabolcs > > Nagy.) > > > > Co-authored-by: Szabolcs Nagy > > I couldn't reproduce with the example provided in the bugzilla (on both > aarch64 and arm machines), but the explanation and the fix sounds logical. > I guess a testcase will be hard to create an exercise the issue. > > LGTM, thanks. > > Reviewed-by; Adhemerval Zanella thanks, committed at 395be7c2184645320c955b0ba214af9fa1ea9675