From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hera.aquilenet.fr (hera.aquilenet.fr [IPv6:2a0c:e300::1]) by sourceware.org (Postfix) with ESMTPS id 645573857819 for ; Tue, 6 Apr 2021 18:43:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 645573857819 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=samuel.thibault@ens-lyon.org Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id E750B5D8; Tue, 6 Apr 2021 20:43:28 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ltLOHFD8SVPu; Tue, 6 Apr 2021 20:43:28 +0200 (CEST) Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 2B82995; Tue, 6 Apr 2021 20:43:28 +0200 (CEST) Received: from samy by begin with local (Exim 4.94) (envelope-from ) id 1lTqfe-00Fpp0-Rc; Tue, 06 Apr 2021 20:43:26 +0200 Date: Tue, 6 Apr 2021 20:43:26 +0200 From: Samuel Thibault To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Szabolcs Nagy , rrh.henry@gmail.com Subject: Re: RFC: Remove --disable-hidden-plt Message-ID: <20210406184326.y3bwehu352ptd422@begin> References: <28ab0b62-2b14-4fd2-b333-abb1d91fa714@linaro.org> <20210406171833.24b5vr4j2b762knb@begin> <20210406180338.wh2vwyqqsro7v3d5@begin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spamd-Bar: -- Authentication-Results: hera.aquilenet.fr X-Rspamd-Server: hera X-Rspamd-Queue-Id: E750B5D8 X-Spamd-Result: default: False [-2.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; BAYES_HAM(-3.00)[100.00%] X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2021 18:43:32 -0000 Adhemerval Zanella, le mar. 06 avril 2021 15:15:01 -0300, a ecrit: > Currently NO_RTLD_HIDDEN spills on some generic code: > > config.h.in:#undef NO_RTLD_HIDDEN > elf/dl-minimal.c:# ifndef NO_RTLD_HIDDEN > elf/dl-minimal.c:# ifndef NO_RTLD_HIDDEN > include/assert.h:# if IS_IN (libc) || (IS_IN (rtld) && !defined NO_RTLD_HIDDEN) > include/sys/stat.h:# if IS_IN (libc) || (IS_IN (rtld) && !defined NO_RTLD_HIDDEN) > include/unistd.h:# ifndef NO_RTLD_HIDDEN Ah, so actually I eventually did the work of marking the specific functions. That's the extra maintenance complexity I was talking about. > With the removal of NO_HIDDEN configure support, I would like to > move NO_RTLD_HIDDEN to be Hurd specific But we don't want to duplicate code either. > if possible. It's always possible to duplicate the code but that'd be forking maintenance. We could split the few NO_RTLD_HIDDEN lines in a separate header that sysdeps/mach/hurd/ could override with an empty file? It does not seem to me really making the code more readable than the ifndef... Samuel