From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: [PATCH 08/11] misc: syslog: Use CLOC_EXEC with _PATH_CONSOLE (BZ #17145)
Date: Mon, 12 Apr 2021 18:11:10 -0300 [thread overview]
Message-ID: <20210412211113.393120-8-adhemerval.zanella@linaro.org> (raw)
In-Reply-To: <20210412211113.393120-1-adhemerval.zanella@linaro.org>
The syslog open the '/dev/console' for LOG_CONS without O_CLOEXEC,
which might leak in multithread programs that call fork.
Checked on x86_64-linux-gnu.
---
misc/syslog.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/misc/syslog.c b/misc/syslog.c
index a310eba476..b595889e1c 100644
--- a/misc/syslog.c
+++ b/misc/syslog.c
@@ -250,7 +250,8 @@ __vsyslog_internal (int pri, const char *fmt, va_list ap,
*/
int fd;
if (LogStat & LOG_CONS &&
- (fd = __open (_PATH_CONSOLE, O_WRONLY | O_NOCTTY, 0)) >= 0)
+ (fd = __open (_PATH_CONSOLE, O_WRONLY | O_NOCTTY | O_CLOEXEC,
+ 0)) >= 0)
{
__dprintf (fd, "%s\r\n", buf + msgoff);
__close (fd);
--
2.27.0
next prev parent reply other threads:[~2021-04-12 21:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 21:11 [PATCH 01/11] support: Add xmkfifo Adhemerval Zanella
2021-04-12 21:11 ` [PATCH 02/11] misc: Add syslog test Adhemerval Zanella
2021-04-12 21:11 ` [PATCH 03/11] misc: syslog: Fix indentation and style Adhemerval Zanella
2021-04-12 21:11 ` [PATCH 04/11] misc: syslog: Use bool for connected Adhemerval Zanella
2021-04-14 14:54 ` Andreas Schwab
2021-04-12 21:11 ` [PATCH 05/11] misc: syslog: Assume MSG_NOSIGNAL support (BZ #17144) Adhemerval Zanella
2021-04-14 14:57 ` Andreas Schwab
2021-04-12 21:11 ` [PATCH 06/11] misc: syslog: Simplify implementation Adhemerval Zanella
2021-04-12 21:11 ` [PATCH 07/11] misc: syslog: Use static buffer Adhemerval Zanella
2021-04-12 21:11 ` Adhemerval Zanella [this message]
2021-04-14 15:00 ` [PATCH 08/11] misc: syslog: Use CLOC_EXEC with _PATH_CONSOLE (BZ #17145) Andreas Schwab
2021-04-12 21:11 ` [PATCH 09/11] misc: syslog: Use static const for AF_UNIX address Adhemerval Zanella
2021-04-14 15:03 ` Andreas Schwab
2021-04-12 21:11 ` [PATCH 10/11] misc: syslog: Move SYSLOG_NAME to USE_MISC (BZ #16355) Adhemerval Zanella
2021-04-12 21:11 ` [PATCH 11/11] misc: syslog: Use RFC5424 Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412211113.393120-8-adhemerval.zanella@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).