From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2087.outbound.protection.outlook.com [40.107.20.87]) by sourceware.org (Postfix) with ESMTPS id AA95B393C87A for ; Tue, 13 Apr 2021 08:38:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AA95B393C87A Received: from AM6P191CA0048.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::25) by VI1PR0802MB2335.eurprd08.prod.outlook.com (2603:10a6:800:a0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.22; Tue, 13 Apr 2021 08:38:01 +0000 Received: from VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:7f:cafe::21) by AM6P191CA0048.outlook.office365.com (2603:10a6:209:7f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16 via Frontend Transport; Tue, 13 Apr 2021 08:38:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT023.mail.protection.outlook.com (10.152.18.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Tue, 13 Apr 2021 08:38:01 +0000 Received: ("Tessian outbound b610e7b4d771:v90"); Tue, 13 Apr 2021 08:38:00 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a1a8c2c259a6b16f X-CR-MTA-TID: 64aa7808 Received: from 51a1dd0114f6.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5042D807-3020-4532-B199-3EC5A6D8FADF.1; Tue, 13 Apr 2021 08:37:53 +0000 Received: from FRA01-PR2-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 51a1dd0114f6.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 13 Apr 2021 08:37:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CjCgpGDVIjCvbNNFeHUjQqY2ygxFIH20HduebQFT6kNAsqRxjjnhYk1Ke1mA/X7GnYcN0nfOs7su5qksvlkeIKH33lxBWql4gI6DkqqSW2FSxuXM6pLCvBADKydpIFkPTqHoQ0CjzF7ZPR/9IPXynip7fxgb+5ThPwvqwAYOhoyD6YANJh4wCuPWT3wvwDJiwbjwYPzqQD/aNYSCgyofypGynVY3Lh6sk4Dt3dUftbRaxUmz1ehaDBH1e4Xa3FFJrzCKOWL6kLy2EIbMA0To+NFX56VO2ys7FXJgY9dqOoL+5fSs9ZeN5LPQ13d4HHlItPfbpGH8kAfqFUVOAQsVEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+b+jgrMtPguI8gJ+MhljlZxIhsC69YFrRRaQ9U4oLZg=; b=MZTH4Bwad/Bq0F4w0RA0T3OlRdn7/zqbc6MYtJAhL/yrU/ULq1K0ZedNwS3uEukQIAdbqCJpJQkL3JXKFqeUhpc4sm+mJzQpsI/pp3dZfJOsUIZ8SDcW2EJpeZ0p34btYFZEVO6Q+cffc+ZX32mo8zfpNlzM1vp7F1D/j2ENWo0u8Bjg4OVIXHm1cQ9iZxPRr2CSfPHqAd8xzxHnrzPGBQ8bdKig2MCBZShvGibFtoOtD7AmJxFYamsPHrXf4sqwdN5cgXS+WlKxXRGDQDpV4CUOkvCV3dMko+uWzw5i3kJl4aNbv6HWedEcUEjv8Lf91wNTBklZriLXkzm7q3cl3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=arm.com; Received: from PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) by PR2PR08MB4745.eurprd08.prod.outlook.com (2603:10a6:101:1a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.22; Tue, 13 Apr 2021 08:37:44 +0000 Received: from PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::c99f:671d:bb2c:f20b]) by PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::c99f:671d:bb2c:f20b%7]) with mapi id 15.20.4020.022; Tue, 13 Apr 2021 08:37:44 +0000 Date: Tue, 13 Apr 2021 09:37:37 +0100 From: Szabolcs Nagy To: libc-alpha@sourceware.org, Richard.Earnshaw@arm.com, DJ Delorie Subject: Re: [PATCH 02/16] Remove PR_TAGGED_ADDR_ENABLE from sys/prctl.h Message-ID: <20210413083736.GT23289@arm.com> References: <20210326112940.GA23289@arm.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210326112940.GA23289@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.55] X-ClientProxiedBy: SA9PR03CA0023.namprd03.prod.outlook.com (2603:10b6:806:20::28) To PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.55) by SA9PR03CA0023.namprd03.prod.outlook.com (2603:10b6:806:20::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16 via Frontend Transport; Tue, 13 Apr 2021 08:37:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9fce065b-765e-4ed9-6f34-08d8fe57729d X-MS-TrafficTypeDiagnostic: PR2PR08MB4745:|VI1PR0802MB2335: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cxVOdYUF3fHUTddSsfub7CkwWtLabJVpygnMjI+Z6vprYDo04DdhRh/ir77YAny7drRp09GFZBtLP89uGLrX2AvEKEEEIPxMWA9LIQK/tvpmDLOt3tUCdNgm0wqKETGTF0H9ViLgg1VTveygy89qVJOXGDznsqBIQ+G+Xa8Ng/UC75raElHUzX29A4PliyTUFMiFyk/2vmB38gK8twmdTQhQnTx0mu1f8Qii/0TJIxr15C7ArefQbcswQXjZqfLoaAOM6r+blvelHJvzNEL4/gV12djSzQjKgWVF0QgdnCNJLq8R32DXzQD3nzFaLSnkgz1uF/YLLFw1ffHbUdo2Po5zsF5NUG61V7vZDvVcUZX5F3Bagz4Xyg8Y3dN96TAOCS2K7NpdeuquHrSIZE1jPMR9AsMfJ8Q6ghVKq89KX7qbWdCMVb3foalqJD32AmNcQK6gAJ8n0F6sucoh3KGVKzV+gBxgdN8fuI0N5vOWzB8dPA2mUUYxKGuG94u6FRp6gmSYgIgqEqHJkMpHDbbWg32f2KnzpzknFTvTXTJRDiyNNEXByFKoiS2K7cLj8S5svakw3hvYtjjhIo6RVMxEy1NRb41P98K/fQwpWOYmrmwtqvVw8eo+8ezqCcBgx36XUpCEmQRiHEi4P+DEF6edhw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6320.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(136003)(366004)(39860400002)(376002)(8676002)(55016002)(1076003)(2906002)(8936002)(33656002)(66476007)(7696005)(6666004)(66556008)(5660300002)(16526019)(2616005)(26005)(8886007)(478600001)(956004)(83380400001)(52116002)(38100700002)(316002)(66946007)(6916009)(38350700002)(36756003)(86362001)(44832011)(186003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?amJNY0duOFB6T0w4cTR1NXk1OXl2Z0RmQ2RIc2l6QkJsbndmZnMyVFl2THR4?= =?utf-8?B?ZUVCSUlzWXNaTUV1SjlId0w0QTdNemg3V2kyazhCTkhkbXYrZU1ZOTI0TWtr?= =?utf-8?B?bnFQU053US9ZREI1WHd3UXNHT2R5UU13MFdPQTd3cTM1bGZFS3FiSVZuSUNY?= =?utf-8?B?eFRTa0ZLTG9OY0V2TTFSRmVMT0tzWUpkZVd0SDZodlQ1bFJEM1N1V1V6VUl4?= =?utf-8?B?c1d6bEo1QU5VOHc4SHpDNmUrVmN6SUdwUHc0d2Y1ZmdYVHphRjhEcHMxeE5W?= =?utf-8?B?TXAraWNqRDdadFM0dTdQNTMzaGxpVnZjVnZuMWhpM1lTNTA3Vm15ZXQzOGp5?= =?utf-8?B?QXo5S3g3eDRjNnJmWVR3b05FMGFHYmY1VUxXRGp5ZTd4YU9aYUw0dWpjdlRX?= =?utf-8?B?bG1VOWp3K0s5OXFhMWVsL3d0ZGVYQ1krZUlRQ1NqUTIwZEROZURvdWxiNmtp?= =?utf-8?B?Tk4zY1BrVStvOEJPa1Q1akhqQ0hWRm0zaHBkTVlhZVZoOHZtN1JMMW9Db2xl?= =?utf-8?B?VUV1anV6QnhHa0xld1hXMzVOY0J2OHc0V0tXeW1iMVdsajNpYTdJQ1djc2li?= =?utf-8?B?cldRN1pSaU9uWFZQVFFHUGVQVjZCa3BoM0RiZlc2MnE0TlhnSGhGT1o5N2ww?= =?utf-8?B?SCtjOVVPSThpdVdxM1lhYkdXci9naVYvM2RTVWlPZzJ2dHFPNjVxYVZabWZT?= =?utf-8?B?RkNUZEI2ejlSYllMYTFZZGlkZUp5U0NwTEIycDhYa3NzZWZVZFVpVEFWTEE1?= =?utf-8?B?UXc5SytBbnZXSDMvZDRLU3RtcWlzUTBMQkI2cHRwWThEdFRqNUZQRWl6VEdl?= =?utf-8?B?UU1yb3lrWGF1MXhINzUvckxiZ05CT3FxNEY4aFIzMHF0RlRDZU5KemY4NzNE?= =?utf-8?B?aUV2YlcyRFcvbG1vNFdGZHVISW1rTzV4QXNCN1RIVzYrejZnSis5Uy9kUy9p?= =?utf-8?B?bTBzUGtqSE9zRElDeUZoS2hNZXBNdkdnZ2hnS3lHZzhmL2tHbnB2R0MzdGM4?= =?utf-8?B?dENIWkFSUk9rczQ1WFVLQ0FHZ2dTcG5HYnNySzljSjl3ZXZJSklqQWxJZXdB?= =?utf-8?B?RnFxcE5qbmMyQ3VKRFI2ekNaV3lPZHRmVGNwNEd5MnlZWG9sdmViV2RveUhl?= =?utf-8?B?dVRCZTlZRjl4VWJsditLMjMvMVhKODY5MlNvbTh4aGFSaVEzdk1yNXJXS0R1?= =?utf-8?B?dHF4REJkSEJndmNSNkN1REJIZENjSEp1N21KZVoweVNaSm9velAzZ1J1Zlps?= =?utf-8?B?OGZVTWl4Yk45b1o1d0tjTElXRnpQemhDcVZnQWt3M1VaMVBXWW5Dcmlkc1BZ?= =?utf-8?B?cWQ3SjlLamJzc25Sam1OV2N6eVB3Qk05TWg3c2FRTE9QS29lMkdQbW0vY2x2?= =?utf-8?B?V205TVNNWDZDQ3hyU2kzVDRBYXJsbGptQk9JS2dhdWNRYlo1akszeEZNWWNW?= =?utf-8?B?dEQ3cXBybUdLazQ2b2h4WGdNR0h2ZXdpVWRFTE5mWEZnckQ3WmpWR0N1TFRt?= =?utf-8?B?OWxBVmpuTTJIYlh4RmV6VWFubWtSYVVtSWFOYlFmNkoyQ3A3aFBRSWtzZDBm?= =?utf-8?B?L25BbnUySmtKTHFucmJRV0VoWWFMcUlBMGw4SWdNbzR2QmRURlUxZnJzaXAr?= =?utf-8?B?b2Zkb0FnNmFjZzludVczcXI3aTZ1UGpyY3l0SHFQWVdZN0ZkR1YwaVh6TUpx?= =?utf-8?B?SWo4b2VpMHQ1OGR1WDdxaVh4ODdTNmJWZGRMRjFXK3ZPRWtaMk44bGVtc3Zl?= =?utf-8?Q?Nnm3RLzkBCS9tLZcrCPtEWNFTibo2eSkbO5bySW?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4745 Original-Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 0e60266f-0ea5-46df-9117-08d8fe5768b3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pnsU114EjthBD8FpNe9YORFjLRcTfHGQPjiJ9LIeeDcVgNqTMPCwLKHCPwrYIjhGDhIIVrtFiJ+FjJBEHnh1OTXFqRZvUTB6P518Y3/54Q4g4O5vlRj5EsNXL9EcuWYf07W46V0YXOv0PVDGg5gV55cact8VhdvqavOETMA6ZRTjiplrTA6qgGrGnm/FhSAbw5ZO51XOaNF0EngpHIUY5XdphrG8UdEFNX7/YGsj91Pc30NpBn7Te3729bOiuqbmXn8jKzIrgfMkCyQkACOYlPVUINg376saPmuYeheQWhiv8SykagShwW/4fWf8kmLMw+7DJGbrb1wLeLE4rGjBEY+vXzxUEkFuC7bmx9y0kdR+owgCFx3AGj0yE68PeuEgOheBaOnRGGPEfCsfn7A3oh8j84Ms+s6eLpJLvyPeetx2FN7DA/0NqcbWefNbbPwFQXLyGKjt83C578QHbQv4PO5qdQDxxg6KRdAZE5ANMaAcy1E5Evfakz35/HkSWIGyhYwX05KngtzD5x6AajQr8yp9EZwvRIpS4bA8paBsWmf1djA8BpkNg3b0fGv/m2cUu2sXrUL6H8fWQLXMey2HRJCtCwzAlNvjjQZ+jIfzteF9zOYFbb2Xu9vqGv2ArFgmGJmgtVJNsjLvYXOryViH1Q== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(376002)(136003)(346002)(39860400002)(46966006)(36840700001)(6862004)(82740400003)(82310400003)(336012)(356005)(81166007)(26005)(956004)(36756003)(8886007)(6666004)(86362001)(316002)(2616005)(44832011)(1076003)(33656002)(5660300002)(47076005)(8936002)(36860700001)(7696005)(2906002)(83380400001)(186003)(55016002)(70206006)(8676002)(16526019)(478600001)(70586007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2021 08:38:01.0065 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9fce065b-765e-4ed9-6f34-08d8fe57729d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2335 X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2021 08:38:05 -0000 The 03/26/2021 11:29, Szabolcs Nagy via Libc-alpha wrote: > The 03/04/2021 16:30, Szabolcs Nagy via Libc-alpha wrote: > > The value of PR_TAGGED_ADDR_ENABLE was incorrect in the installed > > headers and the prctl command macros were missing that are needed > > for it to be useful (PR_SET_TAGGED_ADDR_CTRL). Linux headers have > > the definitions since 5.4 so it's widely available, we don't need > > to repeat these definitions. The remaining definitions are from > > Linux 5.10. > > > > To build glibc with --enable-memory-tagging, Linux 5.4 headers and > > binutils 2.33.1 or newer is needed. > > ping. > > i now committed all the other memtag patches (thanks > DJ for the reviews) only this one needs a review > (i would like to back port it too). ping. DJ: can you please do the review of this header change? (others seems to be less interested looking at it) > > --- > > sysdeps/unix/sysv/linux/sys/prctl.h | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/sysdeps/unix/sysv/linux/sys/prctl.h b/sysdeps/unix/sysv/linux/sys/prctl.h > > index 00817ff0f1..c9048c7cdb 100644 > > --- a/sysdeps/unix/sysv/linux/sys/prctl.h > > +++ b/sysdeps/unix/sysv/linux/sys/prctl.h > > @@ -25,10 +25,6 @@ > > we're picking up... */ > > > > /* Memory tagging control operations (for AArch64). */ > > -#ifndef PR_TAGGED_ADDR_ENABLE > > -# define PR_TAGGED_ADDR_ENABLE (1UL << 8) > > -#endif > > - > > #ifndef PR_MTE_TCF_SHIFT > > # define PR_MTE_TCF_SHIFT 1 > > # define PR_MTE_TCF_NONE (0UL << PR_MTE_TCF_SHIFT) > > -- > > 2.17.1 > >