From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70048.outbound.protection.outlook.com [40.107.7.48]) by sourceware.org (Postfix) with ESMTPS id 29E8E388A404 for ; Tue, 13 Apr 2021 09:35:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 29E8E388A404 Received: from DU2PR04CA0296.eurprd04.prod.outlook.com (2603:10a6:10:28c::31) by VI1PR08MB5471.eurprd08.prod.outlook.com (2603:10a6:803:137::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.21; Tue, 13 Apr 2021 09:35:48 +0000 Received: from DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28c:cafe::b5) by DU2PR04CA0296.outlook.office365.com (2603:10a6:10:28c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Tue, 13 Apr 2021 09:35:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT005.mail.protection.outlook.com (10.152.20.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Tue, 13 Apr 2021 09:35:48 +0000 Received: ("Tessian outbound 47ca92dabae7:v90"); Tue, 13 Apr 2021 09:35:48 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c995421dc5a9dc36 X-CR-MTA-TID: 64aa7808 Received: from 515a68e4dce5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 412E9471-BEBB-4711-9023-0F6715C47F93.1; Tue, 13 Apr 2021 09:35:42 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 515a68e4dce5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 13 Apr 2021 09:35:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BSwTYac/vNGGLDxQ+6CO0z2++0IAvTUaY147l8AB3JidCdo+ZsOKGNy1aImgS2MYrdkKlwkOmha/D16L82T+Kra2yr0Of4JjUp0RdvYmS0+gJr9YxSZY2ZJx98GJzvDyBqgVe/m+42SxQ/dPA+QGch86WYecWKI1ro7tqaXSbnc5GQSZhea6TUi3c+Akt7yfs8+jDGeN9q/N00kesWIONi3myu+QBtsXoORIAj2Z+mhtMeVZ5qXUHwLJRjcy8iquZzhECcRH0Rp7GG96bBJAheAopHUTAR4NlkO6F3/tHAiJsGWNJKvcd1aBKmGhJTyCjc8Tvo2fvqZxZw/xzlWfVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q/U5J5zzNn7Rcjsadxni6f0x0ISnZQN0U0lKBBNNgz4=; b=e5Svb3UD5ju7wmx2olmAd4SsdYPCcZXiFMZUyErNKmUhThxtWA9N98xBqugo+CHx7mamKfjujLGwmaofXm5vTYzXZN7lOESl0Y8yDMjK+rjkJgNNAhOJ0xPluWttzZcBfbqS71Kw1YjfT2Nrf8a5OznYdO1JJwKPt8PZE87BQn3OILEoS897vrXOCvKRwefmyiakS76wG6cnbJGEfxE70k1JtXeuu6o/tWBMiztCVL50ww28xoMSxX3RiauD42nkRTshPAOufYyOZgRVYhwsJwbN/o8Gy3B7oAoOopMts8EGstGl9hJW31G4hvgeJzgzv4yKgPIq4fcRWIhsScdz9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: linux-m68k.org; dkim=none (message not signed) header.d=none;linux-m68k.org; dmarc=none action=none header.from=arm.com; Received: from PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) by PR3PR08MB5754.eurprd08.prod.outlook.com (2603:10a6:102:91::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Tue, 13 Apr 2021 09:35:40 +0000 Received: from PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::c99f:671d:bb2c:f20b]) by PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::c99f:671d:bb2c:f20b%7]) with mapi id 15.20.4020.022; Tue, 13 Apr 2021 09:35:40 +0000 Date: Tue, 13 Apr 2021 10:35:38 +0100 From: Szabolcs Nagy To: Andreas Schwab Cc: Szabolcs Nagy via Libc-alpha Subject: Re: [PATCH v2 01/14] elf: Fix a DTV setup issue [BZ #27136] Message-ID: <20210413093538.GU23289@arm.com> References: <87r1jeh98l.fsf@igel.home> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87r1jeh98l.fsf@igel.home> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.55] X-ClientProxiedBy: LO4P123CA0473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::10) To PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.55) by LO4P123CA0473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.21 via Frontend Transport; Tue, 13 Apr 2021 09:35:40 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2d6e0115-0837-4885-0556-08d8fe5f8530 X-MS-TrafficTypeDiagnostic: PR3PR08MB5754:|VI1PR08MB5471: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gvUtny/c2BqT0rJGbSOc6hADaExOHtPiJLw7sJAgCpRixuMd9xaeRnWOaNHN7CCNJAbvZKVWYN7a2Ens8w5Tnqt8Q0EfIcnxQkMqpwlPCIzK8b8kykAkeByIgtv8XEbDhMShJUWWbYJx7/BMRvTUXt4aS47B88J8/HZic3ZtzZwW31Jqke1MpYA7/sVqp3tR7goqR4UCHTaH6exhW1a1Phln7Uqpkj9UbV7eHdxZS57oselUXVfyWkAaVYg2814xq5fSumSJcsBs+HEzy6N88Okhl3GYSZCFFleexWMakU4OE6f7M6RawtPfeQmhLz+8rbLyBlp9ZRT/myAimUZo7gX5LGEK38zmM2ImzbHv9SMnXVbLrwdlRYQhRe3cY4xuvq/waP0PymwDuX+3R5fprrPnsfYtMOZgoIDnHeomfovTxFpT+woM2H+3jDlTBnf5yEVR+ZjhO3a7uMYxhhDMpZZ50RrjFG6/IG3jo87eZ2rDQU7dvVs9cylf2AXlvbHe2+YwFC04ca1KJVgryaINRNPu9EibQvlGiDZyKzHHo0hRPov67P1U5qhwmeTxbzEpDLFKzrg/3Mz2fgdWmVl1RyFtPtK8GjPkdfruB05W3y0w5QzxUtghebFBLrwMEm7Sr+TKAUf5kgbpxoAoHvcWGA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6320.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(136003)(346002)(376002)(366004)(66476007)(66556008)(478600001)(16526019)(5660300002)(26005)(186003)(66946007)(6916009)(7696005)(52116002)(44832011)(55016002)(8676002)(2616005)(38100700002)(38350700002)(956004)(4744005)(8886007)(316002)(36756003)(33656002)(1076003)(2906002)(4326008)(86362001)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VDhTUStsK1Y3eW92UjMxRnFvdkN6QUxQUEFpWVZQSkZUaXlaY1I0OE45eWhH?= =?utf-8?B?cVBvSHZlRzc4OHlEUzdtcGwvU2JWVjhVb1Jkd3BzZ0NkS1ROby9PaGRIZDc2?= =?utf-8?B?aWI5VGFYZkdScVY2ZGJXaWFLVE5Hc25zY0xWMDhtOW9CYlBaalJyMUcwSmEz?= =?utf-8?B?TUdhNUg3L0NoQW1kT2NmTkVSeThFT2tlVTJscmV3ZFBtUnF2c3crM3dNVk9U?= =?utf-8?B?UlFhZTZOOXk0endlTzc0Qm5wdjhYcFpWeDJ0cmRxbHNkNGhNVDhBOEowLzVw?= =?utf-8?B?UEZ4bU9KSkxRVWFFNmcwR3VkMVZVaGNZa0FIMHZmWENDMHNFWm1WWHlDSUtu?= =?utf-8?B?Mk5hUWZOcUd3WlZUSjdvemUyZkwrM1hBZ1JqQXp6V1lPd3FFVE9kLytmSGMz?= =?utf-8?B?bU1jeWZPM0FQcWRHZnZZYk42TUNzS2hnWnRleUpXbUd5YUNIa3BCSmFwQmZG?= =?utf-8?B?TFhhQkl3WjRLY3ZEdVA5ajg3UGRadHBZMjZtUmM2ZnZKUXBvUmE4Ujd2RW9y?= =?utf-8?B?aTg2VmI3VmZ4ZjEwZmRPWXhLZmNwc3dHVjJVNzdBdmZBNk9iMHBmTEtKdTUr?= =?utf-8?B?eTJOT2xHVUV1YkIxNWkvTm45ajN2QkFlQzVoZm85VXpkYVpiRWZMVnBBa3pE?= =?utf-8?B?RmFtWnNENzNLclp2Z2VobFRNM1RZVGhTeDNsYWl1dm9aUWNEQTF0RnBNTjJs?= =?utf-8?B?dm56WDk5enZXQklaSld0VlowVnFuazZWMjJUWDVrLy9kdVAzSEViVFNjTytr?= =?utf-8?B?cEthaDFMWlVNT1kyaHVzakFab2RwTmRabE12YnpUakliODljSnlvRVVHNkpp?= =?utf-8?B?VnFZRnpPa3lFM3hDSnlQWTZnTDUxZUtVY2NzTmVUSkdvTkV6Sk1xYnkyc1N3?= =?utf-8?B?RmhJWWlpVkd6Z05XSC9HMDBYY2l5dXcwbTdQVU9pQVBlSURLanlOeEpTSy9R?= =?utf-8?B?ejJkUGs2dVl6L2plclhxR2ZOemcydlFCMkxUNlVadnl1NFRieUFJWXpMblNC?= =?utf-8?B?MVNxNVYwcDlHMUdnNTFCZ1ZRc0taK2JEQ2RwUXRiYnA3SGJwQXBVa2JSVnI2?= =?utf-8?B?c0srS21wQ1Y2cVUxaUsyRytwcEprNDFzWCtZWklwd2lkK3gwMEIxU0pLQU16?= =?utf-8?B?YnF2b2ZCWDMwK25maHczc0prZzJvdTI3eWpFVFhtQ2R1ZXB6U3pyWi9MZEtY?= =?utf-8?B?RUdxS3oxOXZtVGFMbjJYdWtlcjZNNVVCRTBUZlQ3eXFFL2NWWW1JdkhzWEQw?= =?utf-8?B?QWtjQ2E0N0c2ajdRdkpQWCtHbTN3QUJqZ2t5VE8wZUlLWCtsYzJHdFk4ejVG?= =?utf-8?B?TXVJdzJvRGNxcTVMMzVHUSs4L3JjWE5jNzVhMytTcnVNQWMxd3h6bmxzb1Bj?= =?utf-8?B?VGU0YmoyNHYrSUVxV1VjNnE3Nnh3VGFUQXlma1RsM2JJelVVMUtTbTUwZDA3?= =?utf-8?B?QUFPWUQ0NDAxeFA1RVRvNVY4NVBodVYrTmdSRldEWlJJeU9odGg2THFPd1Vl?= =?utf-8?B?RDN2MEVzSnMwOWU3V3VsaUNvRzN1Ukd0MHg2T0RiUUl3SkI3OU80NndIQjkz?= =?utf-8?B?MVpjTFVlUXkxaWJRNTlUMHFTQ25mSmhMSHFtM2FDdkt1UHBPUDB3REZVSzVZ?= =?utf-8?B?blBQd0tjVk80b3d2WUZiZFByeTQ4Wjg0OElaVGgvVGxJYkxkSCsxWG9GdXJM?= =?utf-8?B?MlU4R0h6Nm1Odk95VkxQQWNvbHE4NU1IQUh4WjRMVGlWT0pQU2txbzhibVh0?= =?utf-8?Q?+RgrgEioV79EjzYq/WSwxUUW4fglNF5ffl92cas?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5754 Original-Authentication-Results: linux-m68k.org; dkim=none (message not signed) header.d=none; linux-m68k.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 21eff95c-04fa-4acc-6fe7-08d8fe5f8060 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nAofC8Ztau5w1PjBANoJ5HHPFs7haY12oN7DyNYg9BAIqw5ehzBoPXUv1vaCBmZlQ/BHC9ZNClXl0brjsjd+7SU+g98qR3rl9n54Y7wh5hE94XyxpW92jjVofmb7Qe/qwGIVat1L+Gbx1JsImQhBiGR+/dZBUsmdJFJimSyiuN97KnEmr7PCQKl9j6uHOicGwvBgjKW00IzTjZ1Nps3eUWBENo4kO2rrMZidsK6WrDE8VX0uFyJwTbiqCp0Xw0wr9qPdfpVkLkQTVsjJuo6uOFBNN+GwwokHtn8gn0UPxY18GlT9SxPIxZ+U4KPQw9VdgnUDGV4ZuCSEAcSYQ4Aib4X3wnFoOsJc6YbmXGkPKySTvDJEu68a9N/l0ifm4+Ud7ryfCEeTWmt+kN/ZSv7qSTnjoMy7rCSF/r9XpIBWW4XAuQWu1kbsX327J8PtWjAcpHMCsojCFFH+cSb1Pslczgq14Z0Rmwsqhx3kAlBcqjF3uPwCBGjT0+Q4HkzQ8Cg4asY8Pwhl2whnGlIF+F3th09GWQWEKMgH7WRuSXiN1sfdVdLcmpXmNTKaf1wPTiUcECZdcLuB1oC1KSORhcHF3cr/TrPEiDTFLdIUe08CXddWQb8kmEjIUslmcF9rIupboZF6d2noKw5bc3EUreZnm1yu9dqoOAZlUvxX/aYMsKM= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(346002)(39860400002)(136003)(396003)(376002)(46966006)(36840700001)(956004)(44832011)(2906002)(26005)(186003)(6862004)(7696005)(8886007)(356005)(55016002)(5660300002)(16526019)(36756003)(4744005)(2616005)(1076003)(70206006)(70586007)(47076005)(86362001)(336012)(36860700001)(81166007)(8676002)(316002)(8936002)(82740400003)(4326008)(33656002)(478600001)(82310400003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2021 09:35:48.2730 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2d6e0115-0837-4885-0556-08d8fe5f8530 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5471 X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2021 09:35:54 -0000 The 04/13/2021 10:36, Andreas Schwab wrote: > On Apr 13 2021, Szabolcs Nagy via Libc-alpha wrote: > > > The max modid is a valid index in the dtv, it should not be skipped. > > Does this check in _dl_allocate_tls_init need to be adjusted as well? > > /* Check if the current dtv is big enough. */ > if (dtv[-1].counter < GL(dl_tls_max_dtv_idx)) no, that seems fine because counter is not the dtv length but the maximum valid index (dtv[dtv[-1].counter] is valid, the dtv array size is counter+2 to accomodate for dtv[-1] and [0])