From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80071.outbound.protection.outlook.com [40.107.8.71]) by sourceware.org (Postfix) with ESMTPS id 744D23854835 for ; Tue, 13 Apr 2021 10:35:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 744D23854835 Received: from DB6PR1001CA0033.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::19) by VI1PR0801MB1808.eurprd08.prod.outlook.com (2603:10a6:800:59::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.21; Tue, 13 Apr 2021 10:35:08 +0000 Received: from DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:55:cafe::76) by DB6PR1001CA0033.outlook.office365.com (2603:10a6:4:55::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Tue, 13 Apr 2021 10:35:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT012.mail.protection.outlook.com (10.152.20.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Tue, 13 Apr 2021 10:35:08 +0000 Received: ("Tessian outbound 9bcb3c8d6cb1:v90"); Tue, 13 Apr 2021 10:35:08 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 69e02215cf1bb1a2 X-CR-MTA-TID: 64aa7808 Received: from dc40a56094c2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 177B3BFF-F7F7-4389-8EDF-D7AFFEF36ED5.1; Tue, 13 Apr 2021 10:34:55 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dc40a56094c2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 13 Apr 2021 10:34:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fLuFy+q+I8Clyv85LgdSQgJwS6PLK4MA5UoO+J4hjsgyfCt2i6TvbfINpLWDbcnBJ+66llqGPw1XKU8kktUToWzglbYbyhmC2YHRtOyMlL7fDmcIKdE2fHEl/iEVR7fOfCeqaZTx9SNfWnksi02Ii3bMJKmQct8aGCSajYKAdOei+w2NKvuWqzTX68UdEZDPX3X01bplaI/mdIOXYpB7jCHmXhOSaOEPPnYVTNnrMrZeedobq7wEBDpXLBxDt1s7MjXaUeznVF3+0N8AOGxOUPq4s8O+3Q/jJmWKGuQl4fzKZKQ5eL/dk5/z8PrlCdiXpk6r96KLFK3rmCMzesbywA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+UpYVV+sM6sd2JYtRuNJxlmc2JfL0SXk0iE8wpBgc/E=; b=UiueUci/HIUHEvSSnAa60ILp32ZQnVxMv4nSg5cPD2g3DLwI1XikUDaRcSYId3MCNlMS49fCpqdHzKDUfI4OYN3XM2ub6emXdRoou3N/yPa9w23ELK+FdK3Sq6lQjlDFrR+MHZh4NpoYb4tbW8iKJdf+Tq2SGSSlYTBbiV+In2P/UFcSCUkhs+P5HxJlBbkrQdhPVnldKPSJaSf4YnOFgZi2QwSl4n4rs5c6yqvl48SiOZrcvwEHrySFDkOYqKAJWNa58t8JQZ1Nwr8zDc/3LR0Kw9Z41wAVMEyVNdcntdWYMTQ5foL4TutRGNAl+DQPlU3MbjVmgb+1vBqJmCVTpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: linux-m68k.org; dkim=none (message not signed) header.d=none;linux-m68k.org; dmarc=none action=none header.from=arm.com; Received: from PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) by PAXPR08MB6543.eurprd08.prod.outlook.com (2603:10a6:102:12f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.21; Tue, 13 Apr 2021 10:34:54 +0000 Received: from PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::c99f:671d:bb2c:f20b]) by PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::c99f:671d:bb2c:f20b%7]) with mapi id 15.20.4020.022; Tue, 13 Apr 2021 10:34:53 +0000 Date: Tue, 13 Apr 2021 11:34:50 +0100 From: Szabolcs Nagy To: Andreas Schwab Cc: Szabolcs Nagy via Libc-alpha Subject: Re: [PATCH v2 01/14] elf: Fix a DTV setup issue [BZ #27136] Message-ID: <20210413103450.GW23289@arm.com> References: <87r1jeh98l.fsf@igel.home> <20210413093538.GU23289@arm.com> <87mtu2h4c6.fsf@igel.home> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87mtu2h4c6.fsf@igel.home> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.55] X-ClientProxiedBy: LNXP265CA0094.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::34) To PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.55) by LNXP265CA0094.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.21 via Frontend Transport; Tue, 13 Apr 2021 10:34:53 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 865a45c7-24b4-458c-c44f-08d8fe67cf40 X-MS-TrafficTypeDiagnostic: PAXPR08MB6543:|VI1PR0801MB1808: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: UL9lPnJ2bWNHXLmruzYE77GXWiNnNl8IzKNX6GLQ5uM/mdGD/Wvf4hzmn2l+Mp7cEXKtpe6RlJkvCNVYd7QP3wZKF28H8MCrdlQpr7nfHpPTE2ymh3SQJ8Ykh/zIusp3ior+/gt8ASKiWqrGBcmi4c/V7x+N0xTh0JxjFY5z65xyY3tO7/1riIMc8Z1cVgqbMtNi4f82SrtaMcPCX7IdmavJRtJ1LU0rVUvQ9ZcxOcljqSFST0TC+BQTB8t+U+53rO4UGonzhgS96MZKvJGoTI3mXxlNWKfjDz6d96XRu8PTNYNl/r0P2JBWMk5adKJ+sB+TtDEIPjYkBGk7aNgyr2t0m3XiXyMwqRjV/vuB/eJZs0I3sHAEBUZH901nDSjR4BUXDndUOTdhJrCFGbaUEB4fDn1Z211RyTRIag11cfimevnD5vT8k51HLTK67WoW/rFYpDKt0Fhvse+v2H/xHPZ0UNPIl9L6/5ocBuolNaH+Xb9h/wFtCh+qZhgFzs1KfRX4+hiXnJpaEIa+jml6qWuQjye+mLeAbSMIrE2IskP2vM/zHbsPgvuLc6mhdu5Iy/5BPWbaRhjHLg30HqUMPSmrvUbE/1k+XlFshYKIeqV0OapHyRKgcLGEPqFZcHfaP6gKUzaQDzG2DAKsdbVgaW7Bf0qUVKrCuM8IReNXJG8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6320.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(396003)(346002)(39860400002)(376002)(4326008)(6916009)(66556008)(55016002)(36756003)(478600001)(8886007)(1076003)(26005)(38350700002)(52116002)(38100700002)(33656002)(8676002)(16526019)(186003)(66946007)(44832011)(2616005)(66476007)(7696005)(956004)(2906002)(5660300002)(86362001)(8936002)(316002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?cUttbmlZMnNWSFhRVENCSnRmWkdRNW5aanUrcGlXbmtMcFF5VURkQ1lJWUJL?= =?utf-8?B?eTVMWEdkUG1KVDZXWmRFcjFEL3dvb283OEV1TlFYZFRRS1NqeWpaWGc2TFMz?= =?utf-8?B?WkMrTEowRlkwNW5wM3VxY203LzlvbDBBcEllczFaRDFOeG1IQzlBcGpDTXFi?= =?utf-8?B?ZUZHaWx2SjJPRldad3B4cENMd1JkbWtiYzV5RWNscVBOVDF1Zkx4KzdtcGFY?= =?utf-8?B?REszdSttWlJaQjR2OWNVR2ZTZFpQb1J5TkZvM2l6bFF6OG1yRjYxZStkWHBK?= =?utf-8?B?c0hHRHBtclBLc0pDcFpBYTV1VjhnTDZHR2VOWGI3RE1XWmZQT0NTZGhVN0ov?= =?utf-8?B?NVc1K0JEQnFEenR6L29NUTQ5Y0UxYThoMnVpTWFLNFhKaXhuQnBWdFR5Snph?= =?utf-8?B?OFZteGdydTZzM2wxaitmSVU2M2JSYzBRZUxZcmVjZzNaWmZldjZzb2xabzl3?= =?utf-8?B?Q3NROUZHODhzcTFVYUF5OFZXWHg1eXpjVVA2K2pSTlFuYUpnN3hjMzBwSGdt?= =?utf-8?B?aWJaTE4rTkN2THFRcEFWWUorOU1uMjJHZCtCZndmNmloaTRVSncveUQyMVNm?= =?utf-8?B?UnROUmRTQmVzbnRkYXo3eUpYeW5GcnNUblpFSUx5MEp4SE96Y3RIaGRUQ2Qx?= =?utf-8?B?ckhZNzh0KzBQQXlQbUQwMmhYOWN5T1BxNEVHcWREV1hZeFYwdzlEbTh0Mk9O?= =?utf-8?B?ekIzQzRQakZaVyt0SG9XR3h3Y3hBNWpkd2xnSHRudTc1VEhjL3pVK0VvQzZm?= =?utf-8?B?OTFIZU4vKzlPN2pKUGdaN0ZLQ3JmM0RpVmdtNUd3QWJJOUlscFFBVTVsYUhn?= =?utf-8?B?Q01iUmZydjZjaVphQktLZVpCanhoOGc3R21VekRrUXB4WTk0QWdrTU5TTE1v?= =?utf-8?B?VlVFVU9MYnpIam4rT3lRUGJsL3hLSGhPKzZHbW1iZ0NweUJSbHhLR1hub0Rp?= =?utf-8?B?NzdGc0ZWeGZhUVZyYXlxUncxUmlySVBkSnRtU1lQbGs5OTVQY0p3L0tkbVI1?= =?utf-8?B?Z3RvRUQvbU9sVXFpV084dE0vSzBFMUc5bms2UzdGWEFpenFJaFppdEtBNEhs?= =?utf-8?B?TVZVUzhONmdlZXlJUit5WU1Xbitya3Fja3BqNzBjeE5WR2pIOWN5SC9vYlR5?= =?utf-8?B?a1djNmNZanBkSHRkYUlRZHhuUTZlanlaS1FHeCtEemZlc3lrU2dvQ3ovNlRC?= =?utf-8?B?dVhIUG5nb1VtLzRGUUJCUGo4NmdEYWZCdURnSFBPb3dzZjBtNFBXS3RtSkxx?= =?utf-8?B?aFVja294dHh6SEZ2NDh5RlpBMEtMV0V3aEVuVG5kTDJmWExLQ1RBb1lPNXFy?= =?utf-8?B?eHh1ekd5ZmsvME1veDd2TEZQMXRXSFlaQVh2ZkUwMzRoS3J3OFlGSXg4cllH?= =?utf-8?B?TXRmcTVGbzEzQm80N28wd0NzSTBDQXNwZ241QVMwMVhjT2ZVL3luSkhpOE1T?= =?utf-8?B?WXBLQitpR0lyMUlVUFU5NlFnWHZ0d3lhcWtEUzFyV0xSYXhwdTNBMFVtWDNj?= =?utf-8?B?dzVrSU9jbEJNUElkZWxPUkp0ajFkamY4K0NPUFVMa0h0ekZMelZNNUhWNits?= =?utf-8?B?TzJma3VObXUwMkZzMVFUK2xlK0ZHN1h0NlJrVWFwanVoLzdDSVlTQW95NWJO?= =?utf-8?B?RFZ1ZDdUZXZTY2dPRkxQTyt4VVgyMWJVbGdRWHY0b2JxM2FCSnRjdDNub1FO?= =?utf-8?B?T0hDdlpGZjNNdktRR0s4MS82a0ZQMm5KTEFCNUdEeGd4eHVqODl1bDhTUmov?= =?utf-8?Q?RqLG65NimWgHwTgjlBM2EabuSgDs6ggql6/ZJ8I?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6543 Original-Authentication-Results: linux-m68k.org; dkim=none (message not signed) header.d=none; linux-m68k.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 0722c709-ee48-4d8c-179d-08d8fe67c640 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EN+VZ01ZNu45UU5OWvV5aMzQ1gB5ev7oJSO8VsWLuZIAQmTnj21mApjcS2ydS0Ev5/ve6tLQ8w/IJvYalKe/WmDT8jgFebyZ6+JHV/yVORCUlZwaiS6hbSCtzhFQo1LffVzey/RKjI3bqr3xc7z9sjwwIxSQqlE8iUBE7X7Znfp+h9AQMTVPx6HLIDMRxhbZ4YzZ40tCm1c9d5y18mR/Cqoa323GfxTm8K/W1ofh+udSFgo4MYl/EHMfNEe2PMWi8elJvKxQqoW8GYDSzWuWRXYsf1AFXYXYD8BelukFvaaHAEhj8IHyhAe+ZVvU6BHTLGJ3moRhgh/0UP3bajfXwvyhbonuTIRQwxNkieabANLsEI2gf8PhgMZG/2UOewpeWT5Q0N912W15Y5XlN/mdRRaosJakTIxD4sLN7BGwAVAQTzstIDw3syK4r3Sb0ggTj5Rb2FZnJ+GOfMXJSaytmbPF0Bn88idzAZHA5TX9xUUMfI9czYzKM0OAyBr/QrpzoGQAVgdBYEPY7BosQETNUC29WEDBDTyfT508Ub7wlpzEaPdbyKKIK69SEqmyPiGcJwagIslp1SlaAPu16cYhLUiR1HieuOd2yccLeH26gHSLsCKvHi2UtjeA06IPXEVE8ohLw2S8JE14CN8mPEJQf+Fr07ZYScajkJW0Uf5RlGs= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39860400002)(396003)(346002)(376002)(136003)(36840700001)(46966006)(316002)(47076005)(16526019)(70586007)(186003)(36756003)(336012)(8886007)(81166007)(2906002)(4326008)(8676002)(70206006)(26005)(82310400003)(7696005)(44832011)(956004)(33656002)(82740400003)(8936002)(86362001)(2616005)(356005)(6862004)(36860700001)(5660300002)(1076003)(55016002)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2021 10:35:08.5060 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 865a45c7-24b4-458c-c44f-08d8fe67cf40 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1808 X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2021 10:35:14 -0000 The 04/13/2021 12:22, Andreas Schwab wrote: > On Apr 13 2021, Szabolcs Nagy wrote: > > > The 04/13/2021 10:36, Andreas Schwab wrote: > >> On Apr 13 2021, Szabolcs Nagy via Libc-alpha wrote: > >> > >> > The max modid is a valid index in the dtv, it should not be skipped. > >> > >> Does this check in _dl_allocate_tls_init need to be adjusted as well? > >> > >> /* Check if the current dtv is big enough. */ > >> if (dtv[-1].counter < GL(dl_tls_max_dtv_idx)) > > > > no, that seems fine because counter is not the dtv length but > > the maximum valid index (dtv[dtv[-1].counter] is valid, the > > dtv array size is counter+2 to accomodate for dtv[-1] and [0]) > > Since both dtv[-1].counter and GL(dl_tls_max_dtv_idx) are indexes, not > lengths, I would expect them to be compared with <=. but the code is /* Check if the current dtv is big enough. */ if (dtv[-1].counter < GL(dl_tls_max_dtv_idx)) { /* Resize the dtv. */ dtv = _dl_resize_dtv (dtv, GL(dl_tls_max_dtv_idx)); in case of == there is no need to resize: the dtv array is large enough for the observed GL(dl_tls_max_dtv_idx).