The 04/14/2021 15:06, Adhemerval Zanella wrote:
> On 13/04/2021 05:18, Szabolcs Nagy via Libc-alpha wrote:
> > The test dlopens a large number of modules with TLS, they are reused
> > from an existing test.
> > 
> > The test relies on the reuse of slotinfo entries after dlclose, without
> > bug 27135 fixed this needs a failing dlopen. With a slotinfo list that
> > has non-monotone increasing generation counters, bug 27136 can trigger.
> > 
> > --
> > v2:
> > - moved from nptl/ to elf/
> > - dlopen a different set of existing modules.
> > - code style fixes (!= NULL etc).
> > - moved after bug fix patch
> 
> LGTM, with just a small suggestion below?
> 
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

thanks

> > +{
> > +  char buf[100];
> > +  snprintf (buf, sizeof buf, "tst-tls-manydynamic%02dmod.so", i);
> > +  mod[i] = xdlopen (buf, RTLD_LAZY);
> > +}
> 
> Maybe xasprintf here?  

committed with this change, but made a mistake

committed patches are attached.