From: Raoni Fassina Firmino <raoni@linux.ibm.com>
To: "Lucas A. M. Magalhaes" <lamm@linux.ibm.com>
Cc: libc-alpha@sourceware.org, tulio@linux.ibm.com
Subject: Re: [PATCH] powerpc: Optimized memmove for POWER10
Date: Wed, 28 Apr 2021 18:39:45 -0300 [thread overview]
Message-ID: <20210428213945.vd2ypid6vfhds3kt@work-tp> (raw)
In-Reply-To: <20210428174642.1437818-1-lamm@linux.ibm.com>
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/Makefile b/sysdeps/powerpc/powerpc64/multiarch/Makefile
> index 8aa46a3702..16ad1ab439 100644
> --- a/sysdeps/powerpc/powerpc64/multiarch/Makefile
> +++ b/sysdeps/powerpc/powerpc64/multiarch/Makefile
> @@ -24,7 +24,8 @@ sysdep_routines += memcpy-power8-cached memcpy-power7 memcpy-a2 memcpy-power6 \
> stpncpy-power8 stpncpy-power7 stpncpy-ppc64 \
> strcmp-power8 strcmp-power7 strcmp-ppc64 \
> strcat-power8 strcat-power7 strcat-ppc64 \
> - memmove-power7 memmove-ppc64 wordcopy-ppc64 bcopy-ppc64 \
> + memmove-power10 memmove-power7 memmove-ppc64 \
> + wordcopy-ppc64 bcopy-ppc64 \
> strncpy-power8 strstr-power7 strstr-ppc64 \
> strspn-power8 strspn-ppc64 strcspn-power8 strcspn-ppc64 \
> strlen-power8 strcasestr-power8 strcasestr-ppc64 \
Same as my comment on memcpy-power10 patch: If memmove-power10 is only
for "le" should it be on the next section, inside this if:
ifneq (,$(filter %le,$(config-machine)))
LGTM with the clarification about the Makefile.
Tested the patch with --with-cpu=power10 on top of the master
(commit b25b06749179) with no regression from upstream.
o/
Raoni
next prev parent reply other threads:[~2021-04-28 21:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 17:46 Lucas A. M. Magalhaes
2021-04-28 21:39 ` Raoni Fassina Firmino [this message]
2021-04-29 14:18 ` Matheus Castanho
2021-04-29 15:56 ` Lucas A. M. Magalhaes
2021-04-29 19:18 ` Matheus Castanho
2021-04-29 14:22 ` Raphael M Zinsly
2021-04-29 14:46 ` Lucas A. M. Magalhaes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428213945.vd2ypid6vfhds3kt@work-tp \
--to=raoni@linux.ibm.com \
--cc=lamm@linux.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=tulio@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).