From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 3F4FB385E000 for ; Thu, 6 May 2021 14:09:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3F4FB385E000 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 146E4XWl051063 for ; Thu, 6 May 2021 10:09:53 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 38ce8dfge2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 06 May 2021 10:09:53 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 146E7lgE024887 for ; Thu, 6 May 2021 14:09:52 GMT Received: from b03cxnp07027.gho.boulder.ibm.com (b03cxnp07027.gho.boulder.ibm.com [9.17.130.14]) by ppma04dal.us.ibm.com with ESMTP id 38bedty6nc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 06 May 2021 14:09:52 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 146E9o9g27656514 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 6 May 2021 14:09:50 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8EB0BBE04F; Thu, 6 May 2021 14:09:50 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A5009BE051; Thu, 6 May 2021 14:09:49 +0000 (GMT) Received: from work-tp (unknown [9.65.198.14]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTPS; Thu, 6 May 2021 14:09:49 +0000 (GMT) Date: Thu, 6 May 2021 11:09:46 -0300 From: Raoni Fassina Firmino To: Raphael M Zinsly Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] powerpc64le: Fix ifunc selection for memset, memmove, bzero and bcopy Message-ID: <20210506133309.ertnu3sxgy4l2w7i@work-tp> Mail-Followup-To: Raphael M Zinsly , libc-alpha@sourceware.org References: <20210503195935.je5jbi6hjbiiaovs@work-tp> <08714fd3-695c-5c54-6d57-5747a1ac3a9c@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <08714fd3-695c-5c54-6d57-5747a1ac3a9c@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: C6JapakoneM4hTp0f8Bb3qe0PYXHihc8 X-Proofpoint-ORIG-GUID: C6JapakoneM4hTp0f8Bb3qe0PYXHihc8 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-06_10:2021-05-06, 2021-05-06 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 spamscore=0 bulkscore=0 adultscore=0 priorityscore=1501 mlxlogscore=713 impostorscore=0 suspectscore=0 phishscore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2105060103 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 May 2021 14:09:55 -0000 On Tue, May 04, 2021 at 02:48:06PM -0300, Raphael M Zinsly wrote: > The patch LGTM but I think it would improve readbility if you use more > parentheses in the multiarch files e.g.: > > (hwcap2 & PPC_FEATURE2_ARCH_3_1) > && (hwcap2 & PPC_FEATURE2_HAS_ISEL) > && (hwcap & PPC_FEATURE_HAS_VSX) > ? __bcopy_power10 : I tried to follow the parentheses style of the surround code, but some use parentheses for each hwcap sub-expression, some don't. IMHO less parentheses are more readable, but I don't have strong opinion about it and can change it if you feel strong about it. o/ Raoni