From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2077.outbound.protection.outlook.com [40.107.21.77]) by sourceware.org (Postfix) with ESMTPS id 3A77B388C029 for ; Tue, 11 May 2021 16:19:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3A77B388C029 Received: from AM3PR04CA0146.eurprd04.prod.outlook.com (2603:10a6:207::30) by VI1PR0802MB2623.eurprd08.prod.outlook.com (2603:10a6:800:b9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Tue, 11 May 2021 16:19:54 +0000 Received: from AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:207:0:cafe::d0) by AM3PR04CA0146.outlook.office365.com (2603:10a6:207::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Tue, 11 May 2021 16:19:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT021.mail.protection.outlook.com (10.152.16.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Tue, 11 May 2021 16:19:53 +0000 Received: ("Tessian outbound 13cdc29c30b8:v91"); Tue, 11 May 2021 16:19:53 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 866eb19f693e2442 X-CR-MTA-TID: 64aa7808 Received: from bf4731b70605.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 77111095-7D0B-4AFA-B566-09432E623498.1; Tue, 11 May 2021 16:19:39 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bf4731b70605.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 11 May 2021 16:19:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HVYsXm0lKW6hNm3YEVV3ynU1IrUafkJ9iyhvJ5DRpj3HFG/xlEje0++fODSLhvZzBVIKN3eOf+w4SrPZxY+N0T4KkFZxdmx+6Yu03iXANFOwRQBu1+04pawrKIBikVUrguN43zaWOLBa//byI84dzHleKYZJbTXzDHTrGVT2fsc/AmcQFUkrTazDn1Y/Sqjx+1PBd9VOV4nD81PVKI/Pm/IxC3oKvdMOP8zb/kYfUdttXew82tGwYh05XmfGHBFd7W+X81fMdOHM5XbLcOZJ+lc1xfCHIFzGTpRk5f41C/AsMGzG9xJVRPKC4+neEUnHmVWIrd5j/wYQ71/YCpPsOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S7RaTLfcfCw1a0UiBEWlYUgckR0bM4aUj5jtWKLtgBM=; b=Oh/btuqy1xJ0CSdkBuiOuirNAEX5ukVjHqy0Z680OZMah4q0fUQb9fBENNhT328GNMHXgmKsMnf0tl28BgZXsM3YyD1Mf6n6z09vo+WP8HuD+hITqVGLA3czj+eQF9njUfbBQCh974q9OFF1sccHDmgJ7sgIFhCNbdi2kPrKJwwcPoPf7xrgHe7VKhMnkyAYYEIzR2EYtV7yuxninuE0GSHSN3IgZ0ym5lLsCevtLAEesepgcSECkfuugVjfvzJ//60kP1cn/DwFH9LnB2qwvD+iG287f4LxzhmB4FM+IZ8jjJ2uyS41lfShi4x8Av9EbYQsCV3rKszYuJMdB3EYaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; Received: from PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) by PA4PR08MB6015.eurprd08.prod.outlook.com (2603:10a6:102:e6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Tue, 11 May 2021 16:19:36 +0000 Received: from PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::c99f:671d:bb2c:f20b]) by PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::c99f:671d:bb2c:f20b%7]) with mapi id 15.20.4129.025; Tue, 11 May 2021 16:19:36 +0000 Date: Tue, 11 May 2021 17:19:34 +0100 From: Szabolcs Nagy To: Carlos O'Donell , libc-alpha@sourceware.org Subject: Re: [PATCH v2 06/14] elf: Use relaxed atomics for racy accesses [BZ #19329] Message-ID: <20210511161934.GJ9028@arm.com> References: <10fb15a36b3f6bc3e5ca62cda081c86512f47d32.1618301209.git.szabolcs.nagy@arm.com> <37965321-dec2-f901-325c-ac4bad72484f@linaro.org> <20210416091256.GA30290@arm.com> <0a69a61e-5500-8e01-658d-c5e4896c6489@redhat.com> <20210511093105.GH9028@arm.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210511093105.GH9028@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.55] X-ClientProxiedBy: LO2P265CA0244.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::16) To PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.55) by LO2P265CA0244.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Tue, 11 May 2021 16:19:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb35a2fb-c11e-4eec-8ba4-08d914989c54 X-MS-TrafficTypeDiagnostic: PA4PR08MB6015:|VI1PR0802MB2623: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:3276;OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KKVBq5lWY90W5E5ogYKKp3MWfVmzTg6RFwCv0mEc75kmnJsZdJQWliFFwV+ITSNkQTGPkw/exXy9ALpd5jQ0WkqcE8e7m6F9Q0itKstI61SqMAYIbKNGzKXccqOt3j1seftoHdRPHCMTV6VTsK/j97RDEiXjvJUllVZDau7mwllOToarWvFLtDTWZuqgedlj4DxeoG/uOzTl8rjQukAcStLci3KAhVvSIy0cGl1zk6Y3Gt/1CAwqbIqJZOrFpDE/kIiP1NDBaCmXTIthKvP5MTq3PbHMegIVaYrdPGYTSjDvk7q6U1JrDVUjrOpr+J4I7OV7CifYKQtGkxldmaSB+6oLKjoabZ3/AfUScHstAtaFR7LrpfoFLJBAg7f00/grCAxwAVV502lh4LjhKbm4ps25ns+edqgkjRCUb9e3MpYrF1kw/hBrfJcUUcnUwVH7lB8xgO6DtmEKtaMkeYrx+CPAUMaf4gEvjVevkikV6nGPomGe3GmbNQwqB8eZc8oAJFDtPtFZyhxgMmVKIwHi4logvLlV7KVxLCCyCd2Y5eg5zZszgZfNPWb2WSwDTOMgEFXE5dKfKFnw2D9/A4GRI1IE9B29Jp+orP5GVWDaX5JSOO3ILhOhSRiLoAe3N2++vAjjpt1w/Eq7dIH7tXlTbg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6320.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39850400004)(366004)(396003)(376002)(346002)(136003)(316002)(53546011)(83380400001)(1076003)(36756003)(8886007)(44832011)(33656002)(86362001)(38350700002)(478600001)(2616005)(2906002)(16526019)(186003)(26005)(956004)(5660300002)(7696005)(8676002)(66556008)(66946007)(66476007)(8936002)(38100700002)(55016002)(52116002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?bFh5R2ZLalRNR3ZWcXRad2FEY3ZxUUF0Nng0eWRQZXNxM3lKb2RBaHpPeWEx?= =?utf-8?B?Z2o4VWhXbHRWYXlvTnNMS3IwMkNFUTRjK1Vuajc5UUhzVUxWMzltbkNjNmVm?= =?utf-8?B?eDUyc013V2ZwbEY1VFowUHpUNTZLZG9PQ2tiZCs3ZWxyeFJ1MDY1OG82NUhI?= =?utf-8?B?ZFhkSFAyampjdjl6VHV4Q04zTVgyTTFQYlgxS0s4MkZsK0d2Vk5qeTFGdUth?= =?utf-8?B?UFN4Z1IreW55SUpYMXhGeUM5L3p6aHFlVWk4L0FoODc3ZS9RT2Rqd1JSa09B?= =?utf-8?B?NEFLM1V6b0R2TUI0SWNIcFIxU3NvTmtrV2VCV1pVZGQzbmJ2bm9BYk9UWmhl?= =?utf-8?B?L0hEMitMcWhQNnp4eVN3RnQ5MUxvOXhVVDQwc21JckVHdFFNUGZzN0l3cXA2?= =?utf-8?B?bFB3VnpPVVpVNVNPamx3bUliVFJEUGtYRSs2SHo3V2hVdUJ1VE91NElTazBy?= =?utf-8?B?SnlmSWR2a09UV1JaOE9odGJDMEt0N2tDYWxLdHFvSEc5a2g4bk43NGlIWVpT?= =?utf-8?B?UHNWOHR5SFRQK2J6ajkvRWF0N1U4TzZCZ2syUDdjMkdkeDV4L0RFaUxNR2NB?= =?utf-8?B?QlhjQWxCdzBxUUVDWXhwdWRYR2hKeW53RkpLNkdvMjJPeXRSN3NjSFpuaGdy?= =?utf-8?B?a3Y1RE4vU1pCcXpJb1NvaVZScjlWeG93TE9WV21hYVROWnZ4V1JmbjV4S0xN?= =?utf-8?B?YmxTWHE3ejBrbExMRkRRdzJibmNTWFFTRnBSUFdXdmtLVnlSdHpIVEtmUGhZ?= =?utf-8?B?Wjh1YUo5SnBwdkYrZDZRZ1FOTGorTEtITnRqUmxNYzB0OXk5cjRmMUExKzNw?= =?utf-8?B?bUJqNHBPT3krNWhJTVZUazFWMWFKMDB4WHJpRUdtN1dVVkN4VWd4Sk9HS3kx?= =?utf-8?B?cjd3OTBMZjIwaHJhQ2FlZkdhZ0NYVVFjUlArR1FnSmhpdHV3amR1d0NLWVQx?= =?utf-8?B?cklUV0pjYVZHbXNrY3BqYitmNEV2K0hkMTZpSDRYRk9iTWk0eXpXL3QxL2VI?= =?utf-8?B?T2RVcllaQ21PTlFFNXRQbkQyckhqcmhuR0d0cktFUEJSOFFPMTRTTVlEQlRq?= =?utf-8?B?U2FVVHNNS3BYUEVraHJpelAwSE82T3FnTjJweE1Ec1pYdVlkd05JZkhmTDZJ?= =?utf-8?B?RU1idXF0ay8wMmdMa3prMzBGRmNqNmZIQzhrMTRxNWdnVmgzRVhBdUkxanVK?= =?utf-8?B?dXBoTFVIZDYvUEs3U254eS82cVlSVTVRUi9xcnp6enpyMkJaaXJYMG9jWXY0?= =?utf-8?B?VTZXcThiTnB2L2tOZFVhV3dxdHVkMVVtRXpZSFh0YitYQ2xaa0tzbmZrVGxl?= =?utf-8?B?UlJCK3ozTFlveUlTMURUTk9vQjhObU1HbmprYmZ5L1JnMGdpYzZDL0Q1SElw?= =?utf-8?B?V3E4citnWEowQjZBSThtNW14NHpyZ3BGZnBCUmIvak81Ym9sZWtaUG1TVnNh?= =?utf-8?B?OThQYVcrYXFFZkk2U25mSUt0L1BHZytEdktRUlBIT2M1R0s4amZGNTIyTTVk?= =?utf-8?B?bzZ4bzloMEtHNlNVWXBlSzZvUzJza3lRejk4Y0tyNDlwOFFnM3BkendYSURL?= =?utf-8?B?SEIyVm9UMHFiamFOMWlRQ0h4L0c1YVBZUm40NUszV1l0TjJVTFhaNWZiUFZv?= =?utf-8?B?YUJTTEN1MzB5RmxGdkJua2JKbEhHVFJTZWg2ZjVSOW4yV3BFaG8zcmhRbmh3?= =?utf-8?B?TnFkNVJyeDJhSDJlYytjZ2Y0MWRTTDZrRHI4Qk5wazZyNlRLVGRwSUJkdnF0?= =?utf-8?Q?Y1HoonEhc0HpYD4PNBYqBH8RmEDNFZsIA3x60Bx?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6015 Original-Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 95e2411b-42ac-4122-c75e-08d9149891c6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hJgMsukDeLomU6c9d05c8qwxlldXOtM2jek+vzRoZ68hWkRuFsNHcp6geRE7MkDqI3DsGfXCRzGp0eiF3irp81BHMvIThqk45PKGHhbvtvRExqTgH07YY9xTZ6Y/dYr1I0+jTG0V9942skblH1OPIbwpcsWCAKf5YAXAYzapFAoh1P7sEMlZ2PwM/p8kqffuooxX871wg+tNlYFWD5RYG/obj+NFlQNKdnVzpsLnUkI3N/zugTf04mlc+ykKKKV9StPnuFyK7kJXUNaQ/TEntOlf+A+Nlt6n9nsPOP6K22YJ7lOzOkluMWzPrAdTD+bliYoHPPdUJ3vnhFSfb37xfGvPnew+iSoO0kxxi77R5DmJenQGI5opiUj0G12cM2aL1Ml9IS1zdKp4q3T+w/W8SO13ClQx6WXygfMwsx8GkuhYVgz5x5bS4+hhCFQmy0KOVPsf93WYcpLAVmLGZlsrHIvEIoXldSM+hAuxVbSQce3rmPlNhsXl1k9pncWjRWWN6ldM0ORt35r81f31VqpXdTbnqwU8KJ/vwOF0Ae0NZLwYFWKUFLzZAIuWH/Pyxi34Mc0gVck7bsXYjbzC115Qm29zXhrrLqoOM/NutuU6/f/6NwKlw0Sy9Or4Fr8s2Aja9qzanT82C0aOf0McryI/aoGU8FTfI3Bj10aoT0F3Xxw= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39850400004)(136003)(396003)(376002)(346002)(46966006)(36840700001)(8936002)(47076005)(7696005)(53546011)(1076003)(316002)(86362001)(336012)(2616005)(956004)(82740400003)(83380400001)(70586007)(55016002)(186003)(26005)(16526019)(44832011)(36756003)(82310400003)(5660300002)(356005)(8886007)(33656002)(36860700001)(70206006)(8676002)(478600001)(81166007)(2906002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2021 16:19:53.9447 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cb35a2fb-c11e-4eec-8ba4-08d914989c54 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2623 X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 May 2021 16:19:59 -0000 The 05/11/2021 10:31, Szabolcs Nagy via Libc-alpha wrote: > Thanks for the review, i attached the fixed patch i plan to commit > later today if there are no further comments. committed as f4f8f4d4e0f92488431b268c8cd9555730b9afe9 and committed the other reviewed patches from the series too. > From 2a65e592a753310334c1ded2841215fb9c6024f8 Mon Sep 17 00:00:00 2001 > From: Szabolcs Nagy > Date: Wed, 30 Dec 2020 19:19:37 +0000 > Subject: [PATCH] elf: Use relaxed atomics for racy accesses [BZ #19329] > > This is a follow up patch to the fix for bug 19329. This adds relaxed > MO atomics to accesses that were previously data races but are now > race conditions, and where relaxed MO is sufficient. > > The race conditions all follow the pattern that the write is behind the > dlopen lock, but a read can happen concurrently (e.g. during tls access) > without holding the lock. For slotinfo entries the read value only > matters if it reads from a synchronized write in dlopen or dlclose, > otherwise the related dtv entry is not valid to access so it is fine > to leave it in an inconsistent state. The same applies for > GL(dl_tls_max_dtv_idx) and GL(dl_tls_generation), but there the > algorithm relies on the fact that the read of the last synchronized > write is an increasing value. > > Reviewed-by: Adhemerval Zanella ...