From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by sourceware.org (Postfix) with ESMTPS id E20333939C02 for ; Wed, 19 May 2021 11:00:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E20333939C02 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lukma@denx.de Received: from ktm (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 9DB7882D65; Wed, 19 May 2021 13:00:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1621422009; bh=KYSqwtHBXE+3qzAuT2N86b1ggGq5yFNv3lVKjCdO3bo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rP32IFwQiRvbSBSI15VMvOWeuxkRgnRtWeGLQixGiwRf6RVBJwJcFPEejPdqcLI52 tiuI5RpTE9S6jcfeHSHreTbBd/ehvKt5+j5xwej/LEeMORQnetKkTf0qvin4G7GmGZ dbcvDITvZZwxs2tUEsz7rZaZNyhoUg0lSS0DzLPPAizukKSn+ia8ActEL4AA69QoEi gI1l696PGzqkDVCTKrgiCYUjdftvMtPcTfsGIFCMBncynl368Qf/Spu05pGPZ1hcHR jbkj1B2UBBVnKgolimRRIGpPddhszU2ditlrtcMVnXG0/451Tm1bHuinMsqypzCUDr Ol8YINIQjzKHg== Date: Wed, 19 May 2021 13:00:07 +0200 From: Lukasz Majewski To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Carlos O'Donell Subject: Re: [PATCH v2 23/25] libsupport: Add 64 bit time_t support for time functions Message-ID: <20210519130007.78b2c4f0@ktm> In-Reply-To: <20210518205613.1487824-24-adhemerval.zanella@linaro.org> References: <20210518205613.1487824-1-adhemerval.zanella@linaro.org> <20210518205613.1487824-24-adhemerval.zanella@linaro.org> Organization: denx.de X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/YaN_h6k/D.p7dGJH_PwVfiv"; protocol="application/pgp-signature" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2021 11:00:16 -0000 --Sig_/YaN_h6k/D.p7dGJH_PwVfiv Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 18 May 2021 17:56:11 -0300 Adhemerval Zanella wrote: > The patch adds redirections for xclock_gettime, xclock_settime, > timespec_add, timespec_sub, test_timespec_before_impl, > test_timespec_equal_or_after_impl, support_timespec_ns, > support_timespec_normalize, and support_timespec_check_in_range when > _TIME_BITS=3D64 is defined. >=20 Reviewed-by: Lukasz Majewski > Co-authored-by: Lukasz Majewski > --- > support/Makefile | 6 ++++ > support/timespec-add-time64.c | 27 +++++++++++++++++ > support/timespec-add.c | 2 +- > support/timespec-sub-time64.c | 27 +++++++++++++++++ > support/timespec-sub.c | 2 +- > support/timespec-time64.c | 40 +++++++++++++++++++++++++ > support/timespec.c | 9 +++--- > support/timespec.h | 52 > +++++++++++++++++++++++++-------- support/xclock_gettime_time64.c | > 26 +++++++++++++++++ support/xclock_settime_time64.c | 23 > +++++++++++++++ support/xtime.h | 7 +++++ > 11 files changed, 202 insertions(+), 19 deletions(-) > create mode 100644 support/timespec-add-time64.c > create mode 100644 support/timespec-sub-time64.c > create mode 100644 support/timespec-time64.c > create mode 100644 support/xclock_gettime_time64.c > create mode 100644 support/xclock_settime_time64.c >=20 > diff --git a/support/Makefile b/support/Makefile > index da6dc58d37..1ee73f81bc 100644 > --- a/support/Makefile > +++ b/support/Makefile > @@ -83,8 +83,11 @@ libsupport-routines =3D \ > support_test_verify_impl \ > temp_file \ > timespec \ > + timespec-time64 \ > timespec-add \ > + timespec-add-time64 \ > timespec-sub \ > + timespec-sub-time64 \ > write_message \ > xaccept \ > xaccept4 \ > @@ -94,7 +97,9 @@ libsupport-routines =3D \ > xchdir \ > xchroot \ > xclock_gettime \ > + xclock_gettime_time64 \ > xclock_settime \ > + xclock_settime_time64 \ > xclose \ > xchmod \ > xconnect \ > @@ -215,6 +220,7 @@ CFLAGS-support_paths.c =3D \ > # in support_timespec_check_in_range and for that computation we use > # -fexcess-precision=3Dstandard. > CFLAGS-timespec.c +=3D -fexcess-precision=3Dstandard > +CFLAGS-timespec-time64.c +=3D -fexcess-precision=3Dstandard > =20 > ifeq (,$(CXX)) > LINKS_DSO_PROGRAM =3D links-dso-program-c > diff --git a/support/timespec-add-time64.c > b/support/timespec-add-time64.c new file mode 100644 > index 0000000000..8574e1602c > --- /dev/null > +++ b/support/timespec-add-time64.c > @@ -0,0 +1,27 @@ > +/* Add two struct __timespec64 values. 64 bit time support. > + Copyright (C) 2021 Free Software Foundation, Inc. > + This file is part of the GNU C Library and is also part of gnulib. > + Patches to this file should be submitted to both projects. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be > useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > + > +#if __TIMESIZE !=3D 64 > +# define timespec __timespec64 > +# define time_t __time64_t > +# define timespec_add timespec_add_time64 > +# include "timespec-add.c" > +#endif > diff --git a/support/timespec-add.c b/support/timespec-add.c > index cf8bd91291..8ed3acef6d 100644 > --- a/support/timespec-add.c > +++ b/support/timespec-add.c > @@ -61,5 +61,5 @@ timespec_add (struct timespec a, struct timespec b) > } > } > =20 > - return make_timespec (rs, rns); > + return (struct timespec) { .tv_sec =3D rs, .tv_nsec =3D rns }; > } > diff --git a/support/timespec-sub-time64.c > b/support/timespec-sub-time64.c new file mode 100644 > index 0000000000..f88307016d > --- /dev/null > +++ b/support/timespec-sub-time64.c > @@ -0,0 +1,27 @@ > +/* Subtract two struct __timespec64 values. 64 bit time support. > + Copyright (C) 2021 Free Software Foundation, Inc. > + This file is part of the GNU C Library and is also part of gnulib. > + Patches to this file should be submitted to both projects. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be > useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > + > +#if __TIMESIZE !=3D 64 > +# define timespec __timespec64 > +# define time_t __time64_t > +# define timespec_sub timespec_sub_time64 > +# include "timespec-sub.c" > +#endif > diff --git a/support/timespec-sub.c b/support/timespec-sub.c > index 08cc233086..0b8fea042d 100644 > --- a/support/timespec-sub.c > +++ b/support/timespec-sub.c > @@ -61,5 +61,5 @@ timespec_sub (struct timespec a, struct timespec b) > } > } > =20 > - return make_timespec (rs, rns); > + return (struct timespec) { .tv_sec =3D rs, .tv_nsec =3D rns }; > } > diff --git a/support/timespec-time64.c b/support/timespec-time64.c > new file mode 100644 > index 0000000000..5bbf8be7e0 > --- /dev/null > +++ b/support/timespec-time64.c > @@ -0,0 +1,40 @@ > +/* Support code for timespec checks. 64 bit time support. > + Copyright (C) 2021 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be > useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > +#include > +#include > +#include > +#include > + > +#if __TIMESIZE !=3D 64 > +struct __timespec64 timespec_sub_time64 (struct __timespec64, > + struct __timespec64); > + > +#define test_timespec_before_impl > test_timespec_before_impl_time64 +#define > test_timespec_equal_or_after_impl \ > + test_timespec_equal_or_after_impl_time64 > +#define support_timespec_ns support_timespec_ns_time64 > +#define support_timespec_normalize > support_timespec_normalize_time64 +#define > support_timespec_check_in_range \ > + support_timespec_check_in_range_time64 > +#define timespec __timespec64 > +#define timespec_sub timespec_sub_time64 > + > +#include "timespec.c" > +#endif > diff --git a/support/timespec.c b/support/timespec.c > index b02afad9d3..fcc54861b1 100644 > --- a/support/timespec.c > +++ b/support/timespec.c > @@ -23,9 +23,8 @@ > #include > =20 > void > -test_timespec_before_impl (const char *file, int line, > - const struct timespec left, > - const struct timespec right) > +test_timespec_before_impl (const char *file, int line, struct > timespec left, > + struct timespec right) > { > if (left.tv_sec > right.tv_sec > || (left.tv_sec =3D=3D right.tv_sec > @@ -43,8 +42,8 @@ test_timespec_before_impl (const char *file, int > line,=20 > void > test_timespec_equal_or_after_impl (const char *file, int line, > - const struct timespec left, > - const struct timespec right) > + struct timespec left, > + struct timespec right) > { > if (left.tv_sec < right.tv_sec > || (left.tv_sec =3D=3D right.tv_sec > diff --git a/support/timespec.h b/support/timespec.h > index a3eb72aa01..0478aef51f 100644 > --- a/support/timespec.h > +++ b/support/timespec.h > @@ -24,11 +24,6 @@ > #include > #include > =20 > -struct timespec timespec_add (struct timespec, struct timespec) > - __attribute__((const)); > -struct timespec timespec_sub (struct timespec, struct timespec) > - __attribute__((const)); > - > static inline struct timespec > make_timespec (time_t s, long int ns) > { > @@ -40,21 +35,54 @@ make_timespec (time_t s, long int ns) > =20 > enum { TIMESPEC_HZ =3D 1000000000 }; > =20 > +#ifndef __USE_TIME_BITS64 > +struct timespec timespec_add (struct timespec, struct timespec) > + __attribute__((const)); > +struct timespec timespec_sub (struct timespec, struct timespec) > + __attribute__((const)); > + > void test_timespec_before_impl (const char *file, int line, > - const struct timespec left, > - const struct timespec right); > + struct timespec left, > + struct timespec right); > =20 > void test_timespec_equal_or_after_impl (const char *file, int line, > - const struct timespec left, > - const struct timespec right); > + struct timespec left, > + struct timespec right); > =20 > time_t support_timespec_ns (struct timespec time); > =20 > struct timespec support_timespec_normalize (struct timespec time); > =20 > -int support_timespec_check_in_range (struct timespec expected, > struct timespec observed, > - double lower_bound, double > upper_bound); - > +int support_timespec_check_in_range (struct timespec expected, > + struct timespec observed, > + double lower_bound, double > upper_bound); + > +#else > +struct timespec __REDIRECT (timespec_add, (struct timespec, struct > timespec), > + timespec_add_time64); > +struct timespec __REDIRECT (timespec_sub, (struct timespec, struct > timespec), > + timespec_sub_time64); > +void __REDIRECT (test_timespec_before_impl, (const char *file, int > line, > + struct timespec left, > + struct timespec right), > + test_timespec_before_impl_time64); > +void __REDIRECT (test_timespec_equal_or_after_impl, (const char *f, > int line, > + struct timespec > left, > + struct timespec > right), > + test_timespec_equal_or_after_impl_time64); > + > +time_t __REDIRECT (support_timespec_ns, (struct timespec time), > + support_timespec_ns_time64); > + > +struct timespec __REDIRECT (support_timespec_normalize, (struct > timespec time), > + support_timespec_normalize_time64); > + > +int __REDIRECT (support_timespec_check_in_range, (struct timespec > expected, > + struct timespec > observed, > + double lower_bound, > + double > upper_bound), > + support_timespec_check_in_range_time64); > +#endif > =20 > /* Check that the timespec on the left represents a time before the > time on the right. */ > diff --git a/support/xclock_gettime_time64.c > b/support/xclock_gettime_time64.c new file mode 100644 > index 0000000000..bf9fe9bf9c > --- /dev/null > +++ b/support/xclock_gettime_time64.c > @@ -0,0 +1,26 @@ > +/* clock_settime with error checking. 64 bit time_t support. > + Copyright (C) 2021 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be > useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > + > +#if __TIMESIZE !=3D 64 > +# define xclock_gettime xclock_gettime_time64 > +# define timespec __timespec64 > +# define clock_gettime __clock_gettime64 > +# include "xclock_gettime.c" > +#endif > diff --git a/support/xclock_settime_time64.c > b/support/xclock_settime_time64.c new file mode 100644 > index 0000000000..62a8be1815 > --- /dev/null > +++ b/support/xclock_settime_time64.c > @@ -0,0 +1,23 @@ > +/* clock_settime helper with error checking - 64 bit time_t support. > + Copyright (C) 2021 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + The GNU C Library is distributed in the hope that it will be > useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > + > +#if __TIMESIZE !=3D 64 > +# define xclock_settime xclock_settime_time64 > +# define timespec __timespec64 > +# define clock_settime __clock_settime64 > +# include "xclock_settime.c" > +#endif > diff --git a/support/xtime.h b/support/xtime.h > index b4ac3b59e2..25a069d447 100644 > --- a/support/xtime.h > +++ b/support/xtime.h > @@ -30,8 +30,15 @@ __BEGIN_DECLS > /* The following functions call the corresponding libc functions and > terminate the process on error. */ > =20 > +#ifndef __USE_TIME_BITS64 > void xclock_gettime (clockid_t clock, struct timespec *ts); > void xclock_settime (clockid_t clock, const struct timespec *ts); > +#else > +void __REDIRECT (xclock_gettime, (clockid_t clock, struct timespec > *ts), > + xclock_gettime_time64); > +void __REDIRECT (xclock_settime, (clockid_t clock, const struct > timespec *ts), > + xclock_settime_time64); > +#endif > =20 > /* This helper can often simplify tests by avoiding an explicit > variable declaration or allowing that declaration to be const. */ Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/YaN_h6k/D.p7dGJH_PwVfiv Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmCk77cACgkQAR8vZIA0 zr1k+QgAsoxxCcoaGFWld0JAaXpeDrR7P/H+BRyI92QxCwYV91K2m1lKdetrwNB1 aqMXTbRJbVkU6cRNL8kKsPdpyNNqFKxluLU6vN6jZ+NcIFb+gf/LLqqTnnfTdGdh dfQPotHhB7Ti7StfsTKsffZw41ad9o4Vr2UmHsh7or1iqrqlAFOE8eCYHS8/05YJ wqHcz63vc9zj1DGMrbMgvRyWgYAcv+aRsGdJqRVKfvh8E0Ohzs2YMLPmQ/eu4RS5 bXcW/NELzom8w3owjMYxWUd09hYoIFLxTIq5D59tdYE8n2xwrRUPxsGcX/ZLYHyK gnmAmuJdZNDZH9sn4b5sKfFIkvGdAA== =hmO7 -----END PGP SIGNATURE----- --Sig_/YaN_h6k/D.p7dGJH_PwVfiv--