From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) by sourceware.org (Postfix) with ESMTPS id 9E32B386FC00 for ; Wed, 19 May 2021 13:44:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9E32B386FC00 Received: by mail-qv1-xf2f.google.com with SMTP id ez19so6783402qvb.3 for ; Wed, 19 May 2021 06:44:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=y6zR8RmE76oCCmwoIHKMRAnGhE/Hi5Ud+i/Harerd3I=; b=qI2Z5ouqrSRvekKamTwSV+ecoQ8aV9ySeH9efDjIJenPFZKUHdNT0pOTydX/7rkP8K 5ekPkQnx3Xw+whvkJi4+mzrrKprWP9gS6q5z5vLkaYhj5uur80Ur2a6sbARFi1WG7mtJ 7Zc69fueTsngz+VJghGeJXbPQ3+yYNX78p2t4pgpjn4rDWDu1ywedbNtUhajpOVdJvwQ QXuMpTvdk0k6TawiCp162EvMFV1ZpVztJxAxIWaReARxAZZC8Ynd59Izv2/npkUHD1gP t4NYkmDIxC8jGF1oY7a/TPO4p32IuihgvBxNO5D0wyUQ+qxMwCG5tg2O/AzqHcHlqIZY pzsQ== X-Gm-Message-State: AOAM531TSgd/BXZjRttLy8NQwUrEvdIhHCyvmt07eUUAzzfW9U9mIl1q 76cDlep8VOct8bO4WAxXd+mkCUzn/Q4OQg== X-Google-Smtp-Source: ABdhPJw567h88k9HkckOeqYG+cBMyWriWhJTgibpRD4OOSeGO45TJGGaRS2VowA+XKe06LC2pGtxow== X-Received: by 2002:a0c:9c0f:: with SMTP id v15mr13594962qve.24.1621431865976; Wed, 19 May 2021 06:44:25 -0700 (PDT) Received: from birita.. ([177.194.37.86]) by smtp.googlemail.com with ESMTPSA id r10sm15811118qke.9.2021.05.19.06.44.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 06:44:25 -0700 (PDT) From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [COMMITTED] Remove --enable-stackguard-randomization (BZ #27872) Date: Wed, 19 May 2021 10:44:21 -0300 Message-Id: <20210519134421.1548475-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2021 13:44:30 -0000 Last ENABLE_STACKGUARD_RANDOMIZE usage was removed by 4a103975c4. --- config.h.in | 3 --- configure | 16 ---------------- configure.ac | 9 --------- 3 files changed, 28 deletions(-) diff --git a/config.h.in b/config.h.in index 99036b887f..d54c8c5d13 100644 --- a/config.h.in +++ b/config.h.in @@ -160,9 +160,6 @@ /* Define if your compiler defaults to -msecure-plt mode on ppc. */ #undef HAVE_PPC_SECURE_PLT -/* Define if __stack_chk_guard canary should be randomized at program startup. */ -#undef ENABLE_STACKGUARD_RANDOMIZE - /* Define if memory tagging support should be enabled. */ #undef USE_MTAG diff --git a/configure b/configure index 4cc462613c..5dde2ba355 100755 --- a/configure +++ b/configure @@ -770,7 +770,6 @@ enable_profile enable_static_pie enable_timezone_tools enable_hardcoded_path_in_tests -enable_stackguard_randomization enable_hidden_plt enable_bind_now enable_stack_protector @@ -1430,9 +1429,6 @@ Optional Features: --enable-hardcoded-path-in-tests hardcode newly built glibc path in tests [default=no] - --enable-stackguard-randomization - initialize __stack_chk_guard canary with a random - number at program start --disable-hidden-plt do not hide internal function calls to avoid PLT --enable-bind-now disable lazy relocations in DSOs --enable-stack-protector=[yes|no|all|strong] @@ -3397,18 +3393,6 @@ fi -# Check whether --enable-stackguard-randomization was given. -if test "${enable_stackguard_randomization+set}" = set; then : - enableval=$enable_stackguard_randomization; enable_stackguard_randomize=$enableval -else - enable_stackguard_randomize=no -fi - -if test "$enable_stackguard_randomize" = yes; then - $as_echo "#define ENABLE_STACKGUARD_RANDOMIZE 1" >>confdefs.h - -fi - # Check whether --enable-hidden-plt was given. if test "${enable_hidden_plt+set}" = set; then : enableval=$enable_hidden_plt; hidden=$enableval diff --git a/configure.ac b/configure.ac index 64be29d877..19051b8ee0 100644 --- a/configure.ac +++ b/configure.ac @@ -198,15 +198,6 @@ AC_ARG_ENABLE([hardcoded-path-in-tests], [hardcoded_path_in_tests=no]) AC_SUBST(hardcoded_path_in_tests) -AC_ARG_ENABLE([stackguard-randomization], - AS_HELP_STRING([--enable-stackguard-randomization], - [initialize __stack_chk_guard canary with a random number at program start]), - [enable_stackguard_randomize=$enableval], - [enable_stackguard_randomize=no]) -if test "$enable_stackguard_randomize" = yes; then - AC_DEFINE(ENABLE_STACKGUARD_RANDOMIZE) -fi - AC_ARG_ENABLE([hidden-plt], AS_HELP_STRING([--disable-hidden-plt], [do not hide internal function calls to avoid PLT]), -- 2.30.2