From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by sourceware.org (Postfix) with ESMTPS id EDA1038515FB for ; Mon, 24 May 2021 03:15:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EDA1038515FB Received: by mail-qk1-x736.google.com with SMTP id v8so25847713qkv.1 for ; Sun, 23 May 2021 20:15:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EzMSiaK7B1CBwH0xmehjlzamSEHCg+7EvxYXwZTqfCQ=; b=b9moi8G3hBbL0Esja7Q7b6X+UzJGhK9WuhvsL4DTri/UMj+jxSQh7gr0MMoI3rL2ZD Y76+1HMtl96ykJLVO7mBSyR9k4rChrO9ciRiWOpKIFWHzKHAhw31uQbVexKyDhLqdnqk z36dQH/7NhAGpo6QU6TeFNJYrsIwVfefa734LMOJlO8TZP3J2alb4Z5fbda61/sGeqFs 1apHOAEKlF0CoH1hhmF37+YVHGlVDyiLXCGzIoTNIsSrHNv1pGh9sacBAwXZjv7bmTEe JJcCXXPfSFu1YIhUqIH/jD7emVcDYICIPXZ9dMuLhQzAaDb2Nj30heWKh6JaWCQUUvNS MOCQ== X-Gm-Message-State: AOAM532hlVenNJuOUNhJDH45+RCQE6P/XJ/zDRdZlbMvJ/Jv6MoKWK/T X05loA5ZU7+aw7MWeQNAMypAfRIksVfsSg== X-Google-Smtp-Source: ABdhPJzNzHM66fI0Y+kZg8Gua6pEiGrSBApNGDgE8J223EbLm1MPJctOIUqIbbj3VKlntf8oZ0Y6Ig== X-Received: by 2002:a05:620a:4404:: with SMTP id v4mr26220413qkp.167.1621826121433; Sun, 23 May 2021 20:15:21 -0700 (PDT) Received: from noah-tigerlake.home (pool-71-245-178-39.pitbpa.fios.verizon.net. [71.245.178.39]) by smtp.googlemail.com with ESMTPSA id b134sm5755504qkg.76.2021.05.23.20.15.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 May 2021 20:15:21 -0700 (PDT) From: Noah Goldstein To: libc-alpha@sourceware.org Subject: [PATCH v2 2/2] x86: Improve memmove-vec-unaligned-erms.S Date: Sun, 23 May 2021 23:15:02 -0400 Message-Id: <20210524031502.1975741-2-goldstein.w.n@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210524031502.1975741-1-goldstein.w.n@gmail.com> References: <20210524013020.1869687-2-goldstein.w.n@gmail.com> <20210524031502.1975741-1-goldstein.w.n@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 May 2021 03:15:23 -0000 This patch changes the condition for copy 4x VEC so that if length is exactly equal to 4 * VEC_SIZE it will use the 4x VEC case instead of 8x VEC case. Results For Skylake memcpy-avx2-erms size, al1 , al2 , Cur T , New T , Win , New / Cur 128 , 0 , 0 , 9.137 , 6.873 , New , 75.22 128 , 7 , 0 , 12.933 , 7.732 , New , 59.79 128 , 0 , 7 , 11.852 , 6.76 , New , 57.04 128 , 7 , 7 , 12.587 , 6.808 , New , 54.09 Results For Icelake memcpy-evex-erms size, al1 , al2 , Cur T , New T , Win , New / Cur 128 , 0 , 0 , 9.963 , 5.416 , New , 54.36 128 , 7 , 0 , 16.467 , 8.061 , New , 48.95 128 , 0 , 7 , 14.388 , 7.644 , New , 53.13 128 , 7 , 7 , 14.546 , 7.642 , New , 52.54 Results For Tigerlake memcpy-evex-erms size, al1 , al2 , Cur T , New T , Win , New / Cur 128 , 0 , 0 , 8.979 , 4.95 , New , 55.13 128 , 7 , 0 , 14.245 , 7.122 , New , 50.0 128 , 0 , 7 , 12.668 , 6.675 , New , 52.69 128 , 7 , 7 , 13.042 , 6.802 , New , 52.15 Results For Skylake memmove-avx2-erms size, al1 , al2 , Cur T , New T , Win , New / Cur 128 , 0 , 32 , 6.181 , 5.691 , New , 92.07 128 , 32 , 0 , 6.165 , 5.752 , New , 93.3 128 , 0 , 7 , 13.923 , 9.37 , New , 67.3 128 , 7 , 0 , 12.049 , 10.182 , New , 84.5 Results For Icelake memmove-evex-erms size, al1 , al2 , Cur T , New T , Win , New / Cur 128 , 0 , 32 , 5.479 , 4.889 , New , 89.23 128 , 32 , 0 , 5.127 , 4.911 , New , 95.79 128 , 0 , 7 , 18.885 , 13.547 , New , 71.73 128 , 7 , 0 , 15.565 , 14.436 , New , 92.75 Results For Tigerlake memmove-evex-erms size, al1 , al2 , Cur T , New T , Win , New / Cur 128 , 0 , 32 , 5.275 , 4.815 , New , 91.28 128 , 32 , 0 , 5.376 , 4.565 , New , 84.91 128 , 0 , 7 , 19.426 , 14.273 , New , 73.47 128 , 7 , 0 , 15.924 , 14.951 , New , 93.89 Signed-off-by: Noah Goldstein --- sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S index 5e4a071f16..a783da5de2 100644 --- a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S +++ b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S @@ -420,8 +420,8 @@ L(more_2x_vec): cmpq $(VEC_SIZE * 8), %rdx ja L(more_8x_vec) cmpq $(VEC_SIZE * 4), %rdx - jb L(last_4x_vec) - /* Copy from 4 * VEC to 8 * VEC, inclusively. */ + jbe L(last_4x_vec) + /* Copy from 4 * VEC + 1 to 8 * VEC, inclusively. */ VMOVU (%rsi), %VEC(0) VMOVU VEC_SIZE(%rsi), %VEC(1) VMOVU (VEC_SIZE * 2)(%rsi), %VEC(2) @@ -440,7 +440,7 @@ L(more_2x_vec): VMOVU %VEC(7), -(VEC_SIZE * 4)(%rdi,%rdx) VZEROUPPER_RETURN L(last_4x_vec): - /* Copy from 2 * VEC to 4 * VEC. */ + /* Copy from 2 * VEC + 1 to 4 * VEC, inclusively. */ VMOVU (%rsi), %VEC(0) VMOVU VEC_SIZE(%rsi), %VEC(1) VMOVU -VEC_SIZE(%rsi,%rdx), %VEC(2) -- 2.25.1