Hi Carlos,

> On 5/27/21 5:46 PM, Carlos O'Donell wrote:
> > Adhemerval, Lukasz,
> > 
> > I'm at ~6/25 patches reviewed. I started not by reviewing but by
> > building additional glibc packages for Fedora Rawhide and then
> > testing in Rawhide.
> > 
> > Testing looks good in Fedora Rawhide on top of Florian's recent
> > merge in of the most recent development changes.
> > 
> > I'll continue reviewing these as discussed in order to ensure we
> > can merge them in a timely fashion.  
> 
> Just a quick status update.
> 
> I'm at ~18/25 patches reviewed.

Thanks for the update.

> 
> I had a somewhat long discussion with Adhemerval on IRC about the new
> dual-time ABI and the dropping of the __glibc_reserved* entries form
> the public ABI. This is OK for the new ABI, but we must be careful we
> don't ever define __USE_TIME_BITS64 for any existing 64-bit time_t
> ABIs since it would be an ABI regression.

I do agree with Adhemerval (as he stated it on the IRC), that
__USE_TIME_BITS64 is _only_ defined when __TIMESIZE != 64

It looks like we are safe here...

> 
> I'm out of time today, but I'll come back tomorrow to try finish the
> reviews.
> 

Great. Thanks for the comprehensive review.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de