From: "H.J. Lu" <hjl.tools@gmail.com>
To: libc-alpha@sourceware.org
Cc: Florian Weimer <fweimer@redhat.com>,
Noah Goldstein <goldstein.w.n@gmail.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: [PATCH v8 0/3] Add an internal wrapper for clone, clone2 and clone3
Date: Tue, 1 Jun 2021 07:55:13 -0700 [thread overview]
Message-ID: <20210601145516.3553627-1-hjl.tools@gmail.com> (raw)
The clone3 system call provides a superset of the functionality of clone
and clone2. It also provides a number of API improvements, including
the ability to specify the size of the child's stack area which can be
used by kernel to compute the shadow stack size when allocating the
shadow stack. Add:
extern int __clone_internal (struct clone_args *__cl_args,
int (*__func) (void *__arg), void *__arg);
to provide an abstract interface for clone, clone2 and clone3.
1. Simplify stack management for thread creation by passing both stack
base and size to create_thread.
2. Consolidate clone vs clone2 differences into a single file.
3. Call __clone3 if HAVE_CLONE3_WAPPER is defined. If __clone3 returns
-1 with ENOSYS, fall back to clone or clone2.
4. Use only __clone_internal to clone a thread. Since the stack size
argument for create_thread is now unconditional, always pass stack size
to create_thread.
5. Enable the public clone3 wrapper in the future after it has been
added to all targets.
NB: Sandbox should return ENOSYS on clone3 if it is rejected:
https://bugs.chromium.org/p/chromium/issues/detail?id=1213452#c5
H.J. Lu (3):
Add an internal wrapper for clone, clone2 and clone3
x86-64: Add the clone3 wrapper
Add static tests for __clone_internal
include/clone_internal.h | 16 ++
nptl/allocatestack.c | 59 +-------
nptl/pthread_create.c | 38 +++--
sysdeps/unix/sysv/linux/Makefile | 11 +-
sysdeps/unix/sysv/linux/clone-internal.c | 91 ++++++++++++
sysdeps/unix/sysv/linux/clone3.c | 1 +
sysdeps/unix/sysv/linux/clone3.h | 60 ++++++++
sysdeps/unix/sysv/linux/spawni.c | 26 ++--
.../sysv/linux/tst-align-clone-internal.c | 87 +++++++++++
sysdeps/unix/sysv/linux/tst-clone2-internal.c | 137 ++++++++++++++++++
sysdeps/unix/sysv/linux/tst-clone3-internal.c | 99 +++++++++++++
.../unix/sysv/linux/tst-getpid1-internal.c | 133 +++++++++++++++++
.../sysv/linux/tst-misalign-clone-internal.c | 86 +++++++++++
sysdeps/unix/sysv/linux/x86_64/clone3.S | 92 ++++++++++++
sysdeps/unix/sysv/linux/x86_64/sysdep.h | 2 +
15 files changed, 850 insertions(+), 88 deletions(-)
create mode 100644 include/clone_internal.h
create mode 100644 sysdeps/unix/sysv/linux/clone-internal.c
create mode 100644 sysdeps/unix/sysv/linux/clone3.c
create mode 100644 sysdeps/unix/sysv/linux/clone3.h
create mode 100644 sysdeps/unix/sysv/linux/tst-align-clone-internal.c
create mode 100644 sysdeps/unix/sysv/linux/tst-clone2-internal.c
create mode 100644 sysdeps/unix/sysv/linux/tst-clone3-internal.c
create mode 100644 sysdeps/unix/sysv/linux/tst-getpid1-internal.c
create mode 100644 sysdeps/unix/sysv/linux/tst-misalign-clone-internal.c
create mode 100644 sysdeps/unix/sysv/linux/x86_64/clone3.S
--
2.31.1
next reply other threads:[~2021-06-01 14:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 14:55 H.J. Lu [this message]
2021-06-01 14:55 ` [PATCH v8 1/3] " H.J. Lu
2021-06-04 12:20 ` H.J. Lu
2021-06-18 18:20 ` PING^1 " H.J. Lu
2021-07-13 18:54 ` Adhemerval Zanella
2021-07-13 19:06 ` Adhemerval Zanella
2021-07-13 19:49 ` [PATCH v9] " H.J. Lu
2021-07-14 13:17 ` Adhemerval Zanella
2021-06-01 14:55 ` [PATCH v8 2/3] x86-64: Add the clone3 wrapper H.J. Lu
2021-07-13 19:12 ` Adhemerval Zanella
2021-06-01 14:55 ` [PATCH v8 3/3] Add static tests for __clone_internal H.J. Lu
2021-07-13 19:32 ` Adhemerval Zanella
2021-07-13 21:12 ` [PATCH v9] " H.J. Lu
2021-07-14 13:18 ` Adhemerval Zanella
2021-07-14 13:32 ` H.J. Lu
2021-07-14 13:42 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601145516.3553627-1-hjl.tools@gmail.com \
--to=hjl.tools@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).