From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by sourceware.org (Postfix) with ESMTPS id 16029388A421 for ; Mon, 21 Jun 2021 07:43:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 16029388A421 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=denx.de Received: from ktm (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 03A7A801FD; Mon, 21 Jun 2021 09:43:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1624261399; bh=/Ek1e0G2oMbJimsiw9cVziY771DaPFga4d+PpK6TX4w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0TwcSR+f25C0qhBZwnvK6UiMj4CLhdaVW3Qqx23lJSKby+crDGLjm+DBlUWPMfh1I SfYXd/yYs3waWTBfjb8w8eCvWZQDRhlgwtUizd7Pgfhs92k9wIpP06zwWn14/bfiT6 m0l9vAz7Y60i2PCJgtVbKhd+amAIgUXJRvnWFbgznrAIXBw7Wh7pY9DPx3VDXa8nJq dnLb2BKE79GRk3ysUFkPy94KSE696OGVNR/QruqMSGewUSr8MYJk7hkoBcq21iWz3k haNz3usgXinn8FqaMzosw/oB04/isaI/7X5Eo+Sfc/CiWyzx7EvZZoo10hglKvY04R +/1jPgyB0ciug== Date: Mon, 21 Jun 2021 09:43:18 +0200 From: Lukasz Majewski To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Carlos O'Donell Subject: Re: [PATCH 07/18] linux: Remove supports_time64 () from clock_getres Message-ID: <20210621094318.1a85a9b4@ktm> In-Reply-To: <20210617115104.1359598-8-adhemerval.zanella@linaro.org> References: <20210617115104.1359598-1-adhemerval.zanella@linaro.org> <20210617115104.1359598-8-adhemerval.zanella@linaro.org> Organization: denx.de X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/vSPAElU8EYv5rAgzZjSj_i9"; protocol="application/pgp-signature" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2021 07:43:21 -0000 --Sig_/vSPAElU8EYv5rAgzZjSj_i9 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 17 Jun 2021 08:50:53 -0300 Adhemerval Zanella wrote: > It breaks the usage case of live migration like CRIU or similar. > The performance drawback is it would require an extra syscall > on older kernels without 64-bit time support. >=20 > Checked on i686-linux-gnu on a 4.15 kernel and on a 5.11 kernel > (with and without --enable-kernel=3D5.1) and on x86_64-linux-gnu. > --- > sysdeps/unix/sysv/linux/clock_getres.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) >=20 > diff --git a/sysdeps/unix/sysv/linux/clock_getres.c > b/sysdeps/unix/sysv/linux/clock_getres.c index a9edec93e6..83f0593074 > 100644 --- a/sysdeps/unix/sysv/linux/clock_getres.c > +++ b/sysdeps/unix/sysv/linux/clock_getres.c > @@ -21,7 +21,6 @@ > #include > =20 > #include > -#include > #include > #include > =20 > @@ -34,19 +33,14 @@ __clock_getres64 (clockid_t clock_id, struct > __timespec64 *res) #ifndef __NR_clock_getres_time64 > # define __NR_clock_getres_time64 __NR_clock_getres > #endif > - if (supports_time64 ()) > - { > + > #ifdef HAVE_CLOCK_GETRES64_VSYSCALL > - r =3D INLINE_VSYSCALL (clock_getres_time64, 2, clock_id, res); > + r =3D INLINE_VSYSCALL (clock_getres_time64, 2, clock_id, res); > #else > - r =3D INLINE_SYSCALL_CALL (clock_getres_time64, clock_id, res); > + r =3D INLINE_SYSCALL_CALL (clock_getres_time64, clock_id, res); > #endif > - > - if (r =3D=3D 0 || errno !=3D ENOSYS) > - return r; > - > - mark_time64_unsupported (); > - } > + if (r =3D=3D 0 || errno !=3D ENOSYS) > + return r; > =20 > #ifndef __ASSUME_TIME64_SYSCALLS > /* Fallback code that uses 32-bit support. */ Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/vSPAElU8EYv5rAgzZjSj_i9 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmDQQxYACgkQAR8vZIA0 zr2QRggAwl06w3qVAxJAvk8QVwaXVwyN/pjDvMCZE8S+I+ZJeDFZykUC9ZcJZ+Ie o9GRkvl1r6CEG5LYZoCEobt3IbihknBex0UAo8uTa96IYiUjz/KurOhxrODcLTyJ UGpCoJOEO1RqcdHBzDbGzFVHFsSTy72NASjx9ergC918c34gGXgtWRmFBBw3yEZk FTavq27MqGOQytm80UqNRstztmVUp03f4TLNfZu65i/suXjoJYlP0eoJZrsvUa45 A4jExs/5mlwwuicbazKQcq5tl/akqf4/4sMTnor+vXVpb38MybqAQEN+0Mp0cTFX 6ld4NE89xsxDyQRySYrlya2QKhUmpQ== =eIZD -----END PGP SIGNATURE----- --Sig_/vSPAElU8EYv5rAgzZjSj_i9--