From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Carlos O'Donell <carlos@redhat.com>
Subject: Re: [PATCH] elf: Disable most of TLS modid gaps processing [BZ #27135]
Date: Fri, 25 Jun 2021 08:18:41 +0100 [thread overview]
Message-ID: <20210625071841.GI13058@arm.com> (raw)
In-Reply-To: <8735t6juqg.fsf@oldenburg.str.redhat.com>
The 06/25/2021 08:58, Florian Weimer wrote:
> Revert "elf: Fix DTV gap reuse logic [BZ #27135]"
>
> This reverts commit 572bd547d57a39b6cf0ea072545dc4048921f4c3.
>
> It turns out that the _dl_next_tls_modid in _dl_map_object_from_fd keeps
> returning the same modid over and over again if there is a gap and
> more than TLS-using module is loaded in one dlopen call. This corrupts
> TLS data structures. The bug is still present after a revert, but
> empirically it is much more difficult to trigger (because it involves a
> dlopen failure).
>
> Tested on i386-linux-gnu and x86_64-linux-gnu.
looks reasonable.
prev parent reply other threads:[~2021-06-25 7:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 6:58 Florian Weimer
2021-06-25 7:18 ` Szabolcs Nagy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210625071841.GI13058@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).