From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80078.outbound.protection.outlook.com [40.107.8.78]) by sourceware.org (Postfix) with ESMTPS id 11B2B3857C71 for ; Fri, 25 Jun 2021 07:18:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 11B2B3857C71 Received: from AM6P191CA0092.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::33) by VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Fri, 25 Jun 2021 07:18:54 +0000 Received: from VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8a:cafe::ff) by AM6P191CA0092.outlook.office365.com (2603:10a6:209:8a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Fri, 25 Jun 2021 07:18:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT024.mail.protection.outlook.com (10.152.18.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Fri, 25 Jun 2021 07:18:54 +0000 Received: ("Tessian outbound f945d55369ce:v96"); Fri, 25 Jun 2021 07:18:53 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 04107100d0e60daa X-CR-MTA-TID: 64aa7808 Received: from 0ea3e6bf96c0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9B7B0695-0EF4-45FC-BB14-155217796A2E.1; Fri, 25 Jun 2021 07:18:46 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0ea3e6bf96c0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 25 Jun 2021 07:18:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NpCOIoOR2lTqNru1u2x/21cOJiU5DHxkF/8AUmy2D2zxoyjpyPpsn4NhcGUkLLJ8ZGab6cx/QCUReWkfVvRFK3DvZyhe04Lp5aIW2kFoBFGCdO1kCDbjgflGxhjD5phmahissT7i7/K+avlwYtO3hmj881cGngCbxyXjvAr0khCIVLBy4mdoUMFbtsxO9YRdVwleVTfjS7uK6jHvfJpV2WiWUvkh6Js/Nk+ejlUX5Hcs8WzRQ//NBc5MQijoW/y6zTgwDo155pC69asvMfuMXI1OGYAkHkobMYRveVU5NTZOLUUJzPbtria0KU0eGMbTCDAA3UdKYEnhtK2SyPw1RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3jfRwD3kWski8uIatywe8B8Y3B7BgTXlkT6y/PyxI4s=; b=Jgr8qA6SuddlIzeKXPeG9IcMmBYv+IblLaqvmdgjcxoWxqvVlbwmMLA76NsJQj6THDmNK3g+e5DBxvwjUDitrv4AZhyNSIQ6dSSinwoo8QAI36UY3Rj8rV3I7rkPuM/mZ7v4ROHRJwn+cJuMOfeXFUt21yoDQSSdVMHAtHavkUYIaLvzDCd13R77/yK/JunRZC8tW4cW9p34eTdhSRmlq7svxlikQk0RHzeWMaxiWW1+39sZkJUnCbYPqccOBuOUCmY2NIHrs+kbusUauT/vMhtoqsA/HSYECT0vkERfltd+SbNP3I+aIIgxRtBoTxyar6W+Sd+yuHs50b+2R0UCeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; Received: from DBBPR08MB6313.eurprd08.prod.outlook.com (2603:10a6:10:202::19) by DB8PR08MB5530.eurprd08.prod.outlook.com (2603:10a6:10:11f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.20; Fri, 25 Jun 2021 07:18:44 +0000 Received: from DBBPR08MB6313.eurprd08.prod.outlook.com ([fe80::ada5:303a:de76:b0e2]) by DBBPR08MB6313.eurprd08.prod.outlook.com ([fe80::ada5:303a:de76:b0e2%5]) with mapi id 15.20.4242.023; Fri, 25 Jun 2021 07:18:43 +0000 Date: Fri, 25 Jun 2021 08:18:41 +0100 From: Szabolcs Nagy To: Florian Weimer Cc: libc-alpha@sourceware.org, Adhemerval Zanella , Carlos O'Donell Subject: Re: [PATCH] elf: Disable most of TLS modid gaps processing [BZ #27135] Message-ID: <20210625071841.GI13058@arm.com> References: <8735t6juqg.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8735t6juqg.fsf@oldenburg.str.redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.55] X-ClientProxiedBy: LO2P265CA0117.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::33) To DBBPR08MB6313.eurprd08.prod.outlook.com (2603:10a6:10:202::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.55) by LO2P265CA0117.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Fri, 25 Jun 2021 07:18:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 252ea23c-46ab-4d3b-5389-08d937a97d5d X-MS-TrafficTypeDiagnostic: DB8PR08MB5530:|VE1PR08MB5215: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:1417;OLM:1417; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: D0dfPi6z19TLy4pWGmYp66DjZoXINVQoMHrcJfloPCsDowNSMoNoVu+oxDIFya7QabU30fqsuXK7HIGpFCE37MMTp9+TzyGqZpEHPE0GIaMGF49QKZNT2OJjT0jXeBCa/8j/zE9vIFIpEJ+9Pq1024TC2vkbppqzNW9aCb++tg2uNpxgm1pZTAaCsivsfPJiBJOBRSd43XAoYMRfpwF4ip4WEwD0crU7mUo+YzeP/WpDgEi1eQOMmIht9IRvoYZzTA53CdHdJkkuatTk2cPpHKHNiNFATKTlfnLP31qfuR0Pmd70dbXCfkzbj2XWNA9StcsP9FvktwuLepL94P8CJrtfymn9MTRwftTe/3OAUnCZD/CDm0iHVeqB6RQwH/zKnJeGxUNaoxJGprBJvjA4owWllM3CxKgrVSbyctQO/dmWzz2icDxq/ssRbsb2Ut57h0s0Rp6pWFh0W7f0d1YFi3kvpbGtwt0tkxGDh7JZ2Nw8K4Ak6ipCj4u+Cq2NvcOn+M/S6cW2YAtMPNePNOKj9AS2aHcmn2K/PXx7bP3OOR+zPyQ+uBFehTLGXVu4FpDPzFYgUe8s6JMaeNzrkC9ZXgr+h0Uapn8nOlZ7qTUhwqbx0i5ApI9m6sj7eXF/Z8Tuh+NgpNd9kbFPpzIql8amtpEZeHBYjDrQDG7/Z4fwrFukKdems+pXKZbPRKzmAXCA9G46GAG2jTxW2MQ/lr60Cw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR08MB6313.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39850400004)(366004)(136003)(376002)(396003)(346002)(33656002)(66946007)(8936002)(316002)(8676002)(1076003)(66556008)(66476007)(4744005)(956004)(6916009)(4326008)(55016002)(54906003)(83380400001)(8886007)(7696005)(52116002)(16526019)(38100700002)(186003)(86362001)(478600001)(38350700002)(2616005)(26005)(2906002)(5660300002)(36756003)(44832011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVZUaE90dFE3cy9nYy9WclZNMEhtRlNpVmp5ajlpa1Y4clhLc044a0hhUCt6?= =?utf-8?B?d25CbEhlSlBtNEQwZHNHd1ptQlNKd3JsS3BxNFhiU3Yrd0dmeXVpbGZNN2RJ?= =?utf-8?B?N2NDVXQ3ZC9NZWpDZlpUYnBxMlh6eDE3R0FUbVk4NUJ1RnRvS3F4a1Rmd21z?= =?utf-8?B?S21uNVRwUFczcnBpWTIrOUsrbGtKNVF2bUtYcnRLVVB0bWF4bXZyQ2xEdERN?= =?utf-8?B?V0w5cFhTNXpZdG12RlhPNkdDYUVVSDNCTDRTamM3d1hSSWdmSmRINU5vTjhT?= =?utf-8?B?ZkRsQ3pUdGZQN0Vva0ViRGkvQ0VXUCtvOTNZeENkcUpienV4TmV3QndEK2th?= =?utf-8?B?Ly9ib0UrWVQrUklkK0VpVGU5UXNtdlc5L2F6dDIvb212NWpHbllKQk80YS9R?= =?utf-8?B?dVk4dEpnNzdFOGJIdENiOVNKY3Q5ZE1qODRwZVlpWW0rSDVuanBxSzJxYWlY?= =?utf-8?B?QytRQXcxekxha2wzMnd1aDJmRG90eUpDVCtSY0x2VUhDODlxNXFkdzVKdzND?= =?utf-8?B?cGdCZGZpcCtOTnR0YnRIUHkvQ2EvZmduamo5eFIxWXVLMFd6R2ZITnRnaHkv?= =?utf-8?B?cEZvTCtQbmUxTDc1aWVobHRxUXoyTFptNHQ0VDRjbjBPa3BkUnNtbWx3M1hz?= =?utf-8?B?SUpGYWxVbXdYU090R3YyWFRBcWNUc2hzNE1Db3RJU0gwOGZrb3NUQ292V2hD?= =?utf-8?B?cUlCYXc5dDdjcWxHT05ydXNyOE9Xb0JUZ0V5QmlCWUJtcitNbWtaY2VXVDQx?= =?utf-8?B?RmxLb2IxZzRtRjdCWkczaFY1b1lGaWl5SXNCRzUwRnR3WE5QcEtsSTlMcVdQ?= =?utf-8?B?QU9yQ0hqTVNQeWRVZ3Vxdm1oSFNGdXVidkprU2V4NTVpME9XUWNJZWJvc0xX?= =?utf-8?B?VGhmWWNlZUpjTjZlRnRuYTJFNndwZExQQ2VjckN2M0pPdHEyNWlWL3hnSi9S?= =?utf-8?B?cG5BT2xvTHpOVWJoNkw0U0Q2R2ZrTjJnazBoVlMzWk40Q25CUjBEdjhBTm9v?= =?utf-8?B?ZFVLelBVMmhyRjBXdUxoZHRNUTI2M0RwNFcvdlFDVXdUZEFlREZZL2lQNlBS?= =?utf-8?B?TEYzc0FRSXFoNUZGY1BtbU1ubzhvQmxIWTZHdkk5WjBpRmEzQVdESWhEL1py?= =?utf-8?B?L2tHT1dDMWVGeFVmdHVkVXBqcTNaSlB4YURRMFVDelVZUVFSZFZNeXdTSWNX?= =?utf-8?B?TEc5bnNnc2kwM216ZlVxQWxRZ3hjZGZvcUZNVWJNMlFTQzYyNkVXSzVGbnZ0?= =?utf-8?B?eEVsQUY2N082Q1VFSkdoZFBvV0NQV0ZEYkw1aHAyaXYwMmlhVlkrODc0b2FN?= =?utf-8?B?cE1KUGVYNE9xeWljRE5jbjBya1NlVUxCMlc4dDVvRGpTZ2Y5MXlia24yU28w?= =?utf-8?B?L09ZTFRSNmVZNUpaWk4xdVd2cWRrcnNQSy9FTzJRUkZJY1JpZTVYclJGVlND?= =?utf-8?B?UkVjNTBtdDIwVGlQU3FWSEpwOS9RZDZJeit5bWppaUw5eHY0VmFoVEhNeXhQ?= =?utf-8?B?S0szNVhzRGlIYmxxTnpjQzNsYldoQm5vTVUzQ1ZGMW1pWnhtbFNtSXlraEw2?= =?utf-8?B?RXpYRjFHSmlnRFl6V0xyTlhqZlFLQXkzOWdIZVUwcFBHck5BTjQyZ09GZEFx?= =?utf-8?B?TFhweitzOFFOMG5DTld0bmhQOW1BK2o4aUI2TWZWaFE5ekVmVkg1bS9HVHZh?= =?utf-8?B?VFRZcFVaWDV5VWgyV3k2Ynh0dEtNUzhHem1hTFBmckgzeTlRWXFCT1h6YjNG?= =?utf-8?Q?/ED8qnHftCwQo368xFCnw6RsVEAZFOTSBI722Jo?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5530 Original-Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f87f41bd-c36b-4917-cf81-08d937a976f0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Io87yLG8REBtmoOOc0mSxezsWaymCuLpKn0SbdD6Chv3kIVU5l6op3zNVJIlg/OafwSbyyIErzrBOsy52WDx9nQsfLmtw+7agZWChC831xkRHlyrSzgypKRQXG0TB8z+Iss4l5TkqcbYSYuLONlkHifpqNbIcx9GvV4FR1TgCWx/b49JSSdoP5rtb600NJS/mKAXzvskdQYxuvJyoEFM+noYFTlOltmkQreOzJQQjWi7AGLiC87EmYSeRlZK6XCC1aGqPcKVP08rJkrRSOQSft8JAdMET/gu9BB9BymfuuHL29+mcnVjjtj6dHXZvdTMOZ2rP9EnW+0yesppmx4ECvD06p5WNW3UXwW+lLgCjSIEDcErRn0O0lmL88gK97DcEhVcfUDNvYfSX83u3Q0vynwlcylCyXQD8+H+kXOM7PSojFRdOiyQIgf1qpx6FfwjnxJMscSWUy+YX5q1yrqgj6j7airIB2eiijTAS3bH/uA00e+kCBww5AORH7Ej6eK/ntjejf626m2+vyr1p3EcjI6EfnSebslogNTuKMFcNEwhvdOcmXqnRQUfI1XnGsa6SBq20d9q8bEN/mprEoPulBGMmGhi9D9zfwD4Su0xbl1Sw4FIAXlRPIJ3lXZSrkolG7Ij8w4ba8IH+rpejg57nkl8smV3HztY7ecOTdXkG424QwMsWCl5R/xUOnkLp5qKjz5kxxbM09yVuuvvtWHAng== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39840400004)(346002)(396003)(376002)(136003)(46966006)(36840700001)(316002)(2906002)(356005)(8676002)(55016002)(82310400003)(478600001)(70586007)(107886003)(81166007)(26005)(4744005)(36860700001)(8936002)(6862004)(33656002)(186003)(16526019)(8886007)(7696005)(336012)(2616005)(83380400001)(4326008)(86362001)(5660300002)(956004)(54906003)(47076005)(1076003)(44832011)(36756003)(70206006); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2021 07:18:54.0725 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 252ea23c-46ab-4d3b-5389-08d937a97d5d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5215 X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jun 2021 07:19:00 -0000 The 06/25/2021 08:58, Florian Weimer wrote: > Revert "elf: Fix DTV gap reuse logic [BZ #27135]" > > This reverts commit 572bd547d57a39b6cf0ea072545dc4048921f4c3. > > It turns out that the _dl_next_tls_modid in _dl_map_object_from_fd keeps > returning the same modid over and over again if there is a gap and > more than TLS-using module is loaded in one dlopen call. This corrupts > TLS data structures. The bug is still present after a revert, but > empirically it is much more difficult to trigger (because it involves a > dlopen failure). > > Tested on i386-linux-gnu and x86_64-linux-gnu. looks reasonable.