From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130085.outbound.protection.outlook.com [40.107.13.85]) by sourceware.org (Postfix) with ESMTPS id E651A385482F for ; Tue, 29 Jun 2021 09:26:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E651A385482F Received: from AM5PR0502CA0002.eurprd05.prod.outlook.com (2603:10a6:203:91::12) by AM0PR08MB3636.eurprd08.prod.outlook.com (2603:10a6:208:d4::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.23; Tue, 29 Jun 2021 09:26:22 +0000 Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:91:cafe::b0) by AM5PR0502CA0002.outlook.office365.com (2603:10a6:203:91::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.19 via Frontend Transport; Tue, 29 Jun 2021 09:26:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Tue, 29 Jun 2021 09:26:22 +0000 Received: ("Tessian outbound c4dbd805523b:v97"); Tue, 29 Jun 2021 09:26:22 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 54cdbe66e493e51a X-CR-MTA-TID: 64aa7808 Received: from a86f1bc8b391.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3D4F7405-047A-43F1-B849-632E9976C916.1; Tue, 29 Jun 2021 09:25:43 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a86f1bc8b391.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 29 Jun 2021 09:25:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X0j6uqlF0O00nW1id2JBX5nzIcSqqQ9syd+HjjgPEicNUNActWiGFiD/XToNL79Q9IBJSGZ4TlvgTzbyE5KXzi5HPkMPH/FFv/bQ4SxLfoaJCGnrMTCdlakUEuzGMh6i8UnvzM43Hf3N/Dkc8SXQ0hRTqwxWWksEeWYVEC0Ubw8RGm6FiqZ/3RxGlBa6lS9PmbBnW79YvBBI/rvpVfIpclu1C8xD0xJF46kAlUX3YmpZ+IDZQ54r3/h7erbmv+WJNCsCbmevS0RfvhYMq5d2qyMvlJadLc6pZY3BbAIrQe6h7ig4w2Rpl/hJuTOAf3CFwN+YGMlQx8b94HYAUO4mdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nyeud5+PM737MLuW8MTelXrdX36m79eiu+1WWl4ZGDw=; b=gaDjK4eJhXUc8DUnm+x5U1y+XJrovypSZfaL5vAipdFe4gNihXEx7Gfeocm57Wj8gEL9XQKGqgWTU3XqhQnJlpCirJyZsqzQyoWZtgi2k/1rn0gVUhl0/fJKJ9MHUl43DbERLebO0sj9dOMdSYam57QxHpIPADQNNM/ShNEHX7lkW2pwOSwluBrT/7WRBReJBb7RZdYyiwEHEfIB3fDLOGH10+l5ruc3VdEZ6+fceH9w12PaqA+KjfZKBcY9sfhwrHf1WWPuHlL6WtqzXoZC44ADllU7TwLDK+OU/RHb3yIQAI4u77khakcUF+dI+7HJqTMAvIlMUOqRTx3FesFbww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; Received: from DBBPR08MB6313.eurprd08.prod.outlook.com (2603:10a6:10:202::19) by DBBPR08MB4758.eurprd08.prod.outlook.com (2603:10a6:10:da::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Tue, 29 Jun 2021 09:25:42 +0000 Received: from DBBPR08MB6313.eurprd08.prod.outlook.com ([fe80::ada5:303a:de76:b0e2]) by DBBPR08MB6313.eurprd08.prod.outlook.com ([fe80::ada5:303a:de76:b0e2%5]) with mapi id 15.20.4242.023; Tue, 29 Jun 2021 09:25:41 +0000 Date: Tue, 29 Jun 2021 10:25:39 +0100 From: Szabolcs Nagy To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3] nptl: Export libthread_db-used symbols under GLIBC_PRIVATE Message-ID: <20210629092539.GA14854@arm.com> References: <87zgvarwj8.fsf@oldenburg.str.redhat.com> <3974f7a0-2c4a-0654-65cc-84fe6bd80b09@redhat.com> <20210629082135.GO13058@arm.com> <87o8bpox4u.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87o8bpox4u.fsf@oldenburg.str.redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.55] X-ClientProxiedBy: LO2P265CA0374.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::26) To DBBPR08MB6313.eurprd08.prod.outlook.com (2603:10a6:10:202::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.55) by LO2P265CA0374.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.19 via Frontend Transport; Tue, 29 Jun 2021 09:25:41 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d7478cd2-0a45-4c7d-44f2-08d93adff59a X-MS-TrafficTypeDiagnostic: DBBPR08MB4758:|AM0PR08MB3636: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:462;OLM:462; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: C0MUDD3VItWCDllG6GXKdHEzcpHyo92QwjAUcmLscJLFvfi6gc1K/G0hHvuu1azeexYeeX5FygYIO6cHPNbXzYnBZ9+ejRUW43qtT8mN8dV5ghY9KeJNNEKoVZEoCl8PdM2OqqJgHJJsa2h2XXlZAWeGNI/VQIWtfsDz6NfJq5p5z1rkiug2Nj+phEutvS1I096o3i1NxPU/6qzm/adHN3K34FNxw6nOSZ8Bw/hdZVVJstRODdSb1W14IRw2fPDPgR3Aq5CzUb4RbNGuRWtCW8mpVU27hc5nIPNpYqGnftX5YkHxLyW4qPs2PzVd2cUFJy1R4xdGFcLcBUL3/TEgfzpB40vYS6wuehN1fgq5GhkmqMs0kZZF5j3Cp290iu52KyijAWJfwigVwA9BDL88tdpi5s1Bn9BznK8owiVuhihKoIrKOudTnpMcFDoiP4uYMP14MVcZUA1a1xtmqXCdoVmLfu6uWUISGfOwJ5kuOZMR7gNpOBObJDeAVdpw8UQAlQBLzZXJ9q3+VBT0Y5l+vG11cziRBkDfoSMKKOfvroHUPsYyIEso/Ukmolyz7seAUogRh03euTfr5rBFwpViWDg7+EudrCAzyHAjvWeLlrpzAgjHIxFBQuZOonREs+EYK0U4g47nzSVYdkxlR7mPXZYyxC98TMJqboZw5v1DPh0e9qi4+OiiK4yoEETWTzoQa9dWNIlNAem3J1qwu8zL1g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR08MB6313.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39850400004)(366004)(136003)(396003)(346002)(36756003)(33656002)(55016002)(53546011)(66946007)(83380400001)(66476007)(66556008)(5660300002)(186003)(16526019)(26005)(52116002)(7696005)(86362001)(1076003)(6916009)(8886007)(8936002)(4326008)(2906002)(38100700002)(44832011)(956004)(2616005)(38350700002)(8676002)(316002)(478600001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NzJYanJ3U2FrbHNlSXpBZ0hmY2phZUhuZVYxWW5oSnc0bkN6RDVDb2RXdGZV?= =?utf-8?B?Vk1nQ2Z2Uyt1QzRhdzJubWNBNjljSkdRRE42YWNTN2RRa0s4eXpNcW1zSWNC?= =?utf-8?B?dWU2c0d1cjNadTd4aFo0MlBybEljaWJYc2NBSThYaytxVFNDdHNqTktLRW9B?= =?utf-8?B?TTVseXNwVHAwOGJWdU5yOGlPZkVUcmdCODMramdXeU8xZmE3bTAvUzQ0ZDAx?= =?utf-8?B?R1B2eCtaNVExdlkvdGpxM00rUEtCNHBHb2J0aHhWaVYvY0RmZk1WVWFtMll0?= =?utf-8?B?OElUd2oyUFlDOEk2U2x6Qm80RjQ2bVMvMGNGTE9HOHlBNUFpTjJUMjdGNThY?= =?utf-8?B?Uzk2ZUJvam5TaUFhZXMzUUZ2NkVQMU9DZi9TbGdtWmFtR1NXL0k1cmJGT3U3?= =?utf-8?B?YmphTHV6TUlpQVU3TTlEVDRRUkhhRHVKL3dkZzY1eXJkbytqTzZIVXZTOFIv?= =?utf-8?B?Y2VpbmNYY1doandKWUtwQi94TktNcG5nS2hldGlkZUN1WnMwR05ieTMvemdD?= =?utf-8?B?SGVTdzF1Q1VQcndzT05US21kRzUzeE8vMUhVa2cwdFltTHpINWoxNGRYMVc3?= =?utf-8?B?ZlYvMlNTajZZa2NmZ3luU1VaL3ZReCtGUWpkUUdLNE5qRnBDdTlLNXV0OWtY?= =?utf-8?B?ay9qb0dHRU9TMENhajcvT000NnNSM001cWVWRTdVTy9CbFFOV2tYbmdqREo5?= =?utf-8?B?aCtoZ0tmNXNyTkhIL0c2MU9KWHBWZDJ0VGpPcTluWUpMNUk2ZzNqMUkvVFBo?= =?utf-8?B?R3cyRnY3UElpYWo0cVhSMXJSYk9KOXEzMlNaWjlRdzN3ZndKZEMvWE9iS3Jh?= =?utf-8?B?V3d3c21YcTRqQ3JOZnVybGx0NTQya3UvUUZkK3A2ZldZRVBlVURZZ1VXbUll?= =?utf-8?B?M0R5Tkt5UHgrSDdXUkRncHZaOGNOOURXR21HZGlyV3hCM1g2dHZTbDRZdXNM?= =?utf-8?B?elI0MkVxS1o3RTZ2YTNxY3VxaEhnMDFhOUNWK3F0bVBZT0VhMmNSYitndGJT?= =?utf-8?B?TzZ6M1JscjNZZE10WDZJS2NTYlJ5TXdsK1R2QklLeEdrUTFxR3dET3l4M0d3?= =?utf-8?B?M1B3bVJqc0c3SDNxL0J4R2JPallWQlFyeVZNR0xweFZ6c09ZMGhjK3V0b0xh?= =?utf-8?B?WXdVSzhEc3hhMFlpMERidVJudTh0VmVLNzRhc2NzMUNTMGF5TUNXY25MenJy?= =?utf-8?B?eTdRTUZxSGt5T0phZmZ1amNlbTRMb2dSNWtvS1kwMURSKy9CekV5d3B3T3hR?= =?utf-8?B?NDFUUFpUUUJtYlpPMDBRbXRMcDZ4aUxUandJazZtOFd6Q3ByWS9JWVVBTi9K?= =?utf-8?B?dThiMUowWWREeVNUeElmVkFNbTZ4TnEzT08vOVB4a3k1RHBlSG9VRGZHUnRu?= =?utf-8?B?bkJyNldoWTBiOXg3SUFDSXU4R1crZUxPaEpGWW9KaFR5T2YwNXFRZHdJU2c1?= =?utf-8?B?c0l2aSs4TDhsdUZmMGxoZ3JETDJhc1lZZlhkTHN4VzRVUGg5VWQ2bkZtbjVF?= =?utf-8?B?UXJucGs1b3J0cXlxTDlVb3Q2L1ZlSEdrNkhDbk55TUdLYUQ0SW1ncG1QeXZY?= =?utf-8?B?S2U4QjZabGhmSGFZcTRYb3ZsV1ZlNWo0WmRoUEU0SWdGeXRqNDkvR01yejZ2?= =?utf-8?B?K3h0MFo4d1JFbUF3aUp5SllxaXg0UjdxdndmbHFoSXdtaEpRU3Z4SVRQT083?= =?utf-8?B?QmV5TU5EWjVPZi94MWxoYzhQWXA4S3dBaSthZk9IRnJxY2V4c09EbW1GS3Fp?= =?utf-8?Q?HCDTQHwmmQH40WMWKeptVfpYGleZL9S+Q4SGJa3?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4758 Original-Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 9a87196e-f5ed-4a65-b795-08d93adfdd2d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Qqqz+6k6wwtoB+FeLDV7mXhf9kod3Pqwga12CAexMPI+1M9e0LLupAYNYXslCkeeTK1jyKCGACultcul4TFwbsvvf8Nox+DX7cQrdRq/KYyx7GJey7lZj6UQv+tVxiNCTdgfGKLCk2YPhEDjM5K8HzdvrU85+WqfsvrAbuLDvWcUj+Fn4k879eE4sCgA20EZKYXnl6M3dWu0dNlf30MHRIvN3bR02iqJRMkZ0jIrc0b6AYrA9fBeY4/wRvzL1GtELQ/pi2tStHqKEJRgllxN0i6O3Bt1/KhbHswna6K+bmsu5S8SKuY7ocXpiV3SmN9g2ZmOwq6+lRjD6v3DkhsR7yXh1XJdiheIymQM/F+7T0CaTq3xdEGn7dQDYG87wdQIslbXsMPDjC3vY7Yoidc3ZSDLG+YO9S5Ux6DLmyhE9mtGKq/9Rh1rDOGUkWhkJlx+0FL2eJfqBKfSEAqLvmbjoE/ASuUDbslZ3fXG0yotAKfXMfmuLBPJMT8nr2OmvuyWo1eg7BYY/MS7IK53HzBQm/JJn5THXh9fspVB9zy7TLLanULBcfMDw7ftF68X2bz8l3DGxmfKGkc8abu6Dry092GqvTccq6ijuImoaL3npNdhFWf0ZLwEMliznO88W2bxVIiYnX5M7XycZ1b3+pUy741y4/6clCeKpdxHf7lPrnac3q1Hdx8zK1T7ZrFQXRf7N20nY6/4tw5udz/rKBrZ+w== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(39860400002)(136003)(346002)(396003)(46966006)(36840700001)(55016002)(82310400003)(44832011)(36756003)(6862004)(7696005)(82740400003)(2616005)(47076005)(2906002)(53546011)(478600001)(356005)(4326008)(8676002)(8936002)(5660300002)(956004)(26005)(336012)(33656002)(81166007)(36860700001)(186003)(16526019)(1076003)(83380400001)(8886007)(70206006)(70586007)(86362001)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2021 09:26:22.1094 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d7478cd2-0a45-4c7d-44f2-08d93adff59a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3636 X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jun 2021 09:26:27 -0000 The 06/29/2021 11:09, Florian Weimer via Libc-alpha wrote: > * Szabolcs Nagy: > > > The 06/28/2021 08:59, Carlos O'Donell via Libc-alpha wrote: > >> On 6/28/21 8:41 AM, Florian Weimer wrote: > >> > This allows distributions to strip debugging information from > >> > libc.so.6 without impacting the debugging experience. > >> > >> This looks good, no redundant checks. The only *MAIN* symbol > >> left in structs.def is from ld.so and we skip checking it > >> (because the test framework only processes libc.so's symbols). > >> > >> Reviewed-by: Carlos O'Donell > > > > after the previous two nptl_db commits i see > > > > FAIL: nptl_db/db-symbols > > > > i thought this third patch would fix it, but it didn't: > > > > $ head nptl_db/db-symbols.out > > _thread_db_pthread_eventbuf_eventmask_event_bits@@GLIBC_PRIVATE ***MISSING*** > > _thread_db_pthread_start_routine@@GLIBC_PRIVATE ***MISSING*** > > _thread_db_sizeof_list_t@@GLIBC_PRIVATE ***MISSING*** > > _thread_db_pthread_schedparam_sched_priority@@GLIBC_PRIVATE ***MISSING*** > > _thread_db_td_eventbuf_t_eventdata@@GLIBC_PRIVATE ***MISSING*** > > _thread_db_list_t_prev@@GLIBC_PRIVATE ***MISSING*** > > _thread_db_sizeof_dtv_slotinfo@@GLIBC_PRIVATE ***MISSING*** > > _thread_db_pthread_cancelhandling@@GLIBC_PRIVATE ***MISSING*** > > _thread_db___pthread_keys@@GLIBC_PRIVATE ***MISSING*** > > _thread_db_rtld_global__dl_tls_dtv_slotinfo_list@@GLIBC_PRIVATE ***MISSING*** > > > > is this expected? > > It is not expected. The test runs even when cross-compiling, and I > don't see this failure in a default build-many-glibcs.py run. > > Are these symbols present as dynamic symbols in your build of libc.so.6? > > I suspect your readelf has different output not expected by the script. > Apparently older versions do not print symbol versioning information > with -D -s. 8-( I guess we should parse ELF directly, rather than > readelf output, because it is easier to maintain. > > As a stop-gap measure, we should probably switch to objdump -T. yes i can confirm that my readelf does not print symbol versions with -D -s. GNU readelf (GNU Binutils for Ubuntu) 2.31.1 i can try to update it if it's considered too old.