From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40076.outbound.protection.outlook.com [40.107.4.76]) by sourceware.org (Postfix) with ESMTPS id 75A8A3853809; Fri, 2 Jul 2021 10:59:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 75A8A3853809 Received: from AM6PR08CA0031.eurprd08.prod.outlook.com (2603:10a6:20b:c0::19) by PAXPR08MB7018.eurprd08.prod.outlook.com (2603:10a6:102:201::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22; Fri, 2 Jul 2021 10:59:30 +0000 Received: from VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:c0:cafe::81) by AM6PR08CA0031.outlook.office365.com (2603:10a6:20b:c0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Fri, 2 Jul 2021 10:59:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT017.mail.protection.outlook.com (10.152.18.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Fri, 2 Jul 2021 10:59:29 +0000 Received: ("Tessian outbound f29a5a293366:v97"); Fri, 02 Jul 2021 10:59:29 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c7b97fb609a7a9cd X-CR-MTA-TID: 64aa7808 Received: from b4e44cb1ce60.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 229DBCA6-1571-4BD5-A48A-F0A36CAA3D07.1; Fri, 02 Jul 2021 10:59:20 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b4e44cb1ce60.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Jul 2021 10:59:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gpyoiOv3mOKxJ+GDYPd5E2AUaHnLrv5WnH2im4Iaota17b7MGmX7MYH+toXAZQktksqNw1f57q9YUTPi7eSsTHMWhWFGERrYtpyNHgHSsxWSGX2iqBlwG+Y6gOU0N9R6bCc+E3AvGvgT5JMExOPRSrYNJ+svzbZI0YFio2YFJfxydAjoA78u6N3AWATn+PGeFgkh3ozrV8a5CWo3IgD1jGobzpMVtReHgwNTgg6R19Fl4VsRWTj890zt5IKl4PdIJ+m0Vmk8JcCCgyTbWDYJb+PnMJqrVrfBTyihBm0sPYO9Zf+4CHQBwNAHRFPy9wxFlA3fCySG7cY44U+tDlKBqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m63C8OH1QZomn2YAaiuigY12N23is5kc/BDxzlfBnVQ=; b=JhXUeLup7rz2c8UDe4hIMUz82VsdMo5lzWo1eK0/18+V1rCAaW5j/c7QutNfIz1zqBb94WqfDuQ3zzE8VPB8U+U/1m5UAHVcpW0os4y7a66FzZTnYH4HZag5maOvwAM0sJvdyytSE+Noxtp0XP9qQoNae1Wjpc0xsSFHkrO6vgrUo5Dju1ApHWY00vM+d9f6XJFD8ek31hcjYP2GCqgnAnnDV6b8k1nJR59+AiFHu8oyacEQwUGllhUDmMqtVQpK/LWw1ooGc9A3GVj2eDS/RwRtEZpwEOcQ+oew0a6innpeMl5Y5iSTElvf2WKMp1UPkRGb2E3v6s1cz5rQZOuUxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=arm.com; Received: from PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) by PA4PR08MB5934.eurprd08.prod.outlook.com (2603:10a6:102:e8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.27; Fri, 2 Jul 2021 10:59:16 +0000 Received: from PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::ac83:9f8b:1a5:2c33]) by PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::ac83:9f8b:1a5:2c33%5]) with mapi id 15.20.4287.027; Fri, 2 Jul 2021 10:59:15 +0000 Date: Fri, 2 Jul 2021 11:59:12 +0100 From: Szabolcs Nagy To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] iconvconfig: Use the public feof_unlocked Message-ID: <20210702105912.GI14854@arm.com> References: <20210702094219.3260822-1-siddhesh@sourceware.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210702094219.3260822-1-siddhesh@sourceware.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.55] X-ClientProxiedBy: LO2P265CA0023.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::35) To PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.55) by LO2P265CA0023.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23 via Frontend Transport; Fri, 2 Jul 2021 10:59:14 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d956b5ec-f981-4f7c-571a-08d93d487751 X-MS-TrafficTypeDiagnostic: PA4PR08MB5934:|PAXPR08MB7018: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6430;OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9FCAewsfkC3C6WHgkP/kAKadznCP5kcbNOatBuYeCT18Wt9iYAlZ3IWKnT3sFVc15jdaQiy+A+LMdHi0r6SZT0CIlOwKjHrFVkCboVF5QPzo1PlSqD0iRZ4PqxGNx1eDk8ffoIKCLTkWrbwLPhIobw2BfXnTWzu+qIO5RZL6rWPwPSdbRutEdi9rjxwNqr3gx52hA59CXggNm/s111S/iVRtFG5WQtRma5VgCiqCABX55dXI/N0hCDxkG3nknmMRBegVOMPqY57hJ2as4PybIsBRLT/IlLvDYndTjsbq8FKeh+J/lK2NwDxNoJJzri+h/HGNfP3mOVqLmL9coCcB4JdKrhOFsmMxtX04vrGqMIghN1cm4xQ7R3WusrRSM1ZZnKHkgbp/bis7mEwkdThoE0snRkJcqOP15qy2jNzGOqov7W4MyOske+1izCl1C1JXjDUIS7YAQhsxKLTWwmINwpp0qKLdcibTYjnmPCm6Plzj9u0XVqKcGCLLkH8NBlo/QhSeWxBu0qcen2GeD9C+8BYt4TPLEscGh45a4DM5CtXuin6VdeAsoZxi5KsyWqkWhS1TuUaCgsOT5/iaRB/2+9c6SBuzXL033CCQ4bwRZ+pOEmhhxraEb1V8VXLp70TVyjylxNPxD5GW/1VbJXz1PjoSntBvd3wosAwqqDNC71XnWRh2leo3lvwQfqQOfkgRdGEzMm+rzpexnS0b67I6MA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6320.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(39860400002)(396003)(346002)(376002)(83380400001)(52116002)(7696005)(26005)(316002)(38100700002)(38350700002)(186003)(55016002)(86362001)(16526019)(4326008)(450100002)(1076003)(36756003)(2616005)(956004)(2906002)(44832011)(478600001)(8676002)(8936002)(66476007)(66946007)(66556008)(8886007)(33656002)(6916009)(5660300002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3psTWFxSzdSQS9pKzFlUTBYcHI2VFJDamRmS2RXYVRDY0J6WnNUTzRZWFY3?= =?utf-8?B?Tk9FNXhvYWNJSkZjMFhXdm9VZnljQzB2dzdWWGVFb2dSY1JaLzhrRnk0MzZL?= =?utf-8?B?VWRiUW40bnVoZkw3L3U3MGhqcnFHcUJQSGVBWjNLeGRUZ2ZxQjVzekM2UWFW?= =?utf-8?B?QXpwMTErcHJXcXIrQXZ3MzhmZ0o1YnpQOHNyTENiN05kUGxSaXJxakhrK0lR?= =?utf-8?B?SVYrN21UdUd1aUxWK25ibkRMMDB3b3VJS0hOQWFZWmNKV3dzVCtZdk15bnZv?= =?utf-8?B?cktONXlyaGNVQ2RPcjhSR3BBbXNQeHVNby9sMWxoekZyL0Myem5NLy9VRmdF?= =?utf-8?B?WEI4VHNlei9WYS9DQ0E4ZC9oY3FncDNlM0lXWlprR2phQ1E5SDAxemdINTJL?= =?utf-8?B?aEtzdENLK2dLeGY1Q015Um4ycS9ubzFBT3lNSmlyQUtjeENwU09lSWlMMVZq?= =?utf-8?B?RlJVVnBpRnI4bW54L0JCdHRKYlpidHpFUUlMZXJMZE9DMXEwc25uRjRIcldm?= =?utf-8?B?SVZ0blJzOTJ5RlkvQzZHcTVIdzFZVU1zclQrS1JvZkZnREFMenhPSjJlQVl4?= =?utf-8?B?d2VlR3REU2w0R1l5RVZvcENtMmJIT3NNRURvVW5oUEJEdDV4Vkt5bDBza3dr?= =?utf-8?B?MzlTWEpKd0wvRFc2YkdhdHlsN0ZFc2Y4d2pFWEdlUGhpWHBJNjZzOEIvVlFS?= =?utf-8?B?ZE5KTmNpM1pHbDRXVklTZDlYVElhT0JGTW9qOHJxVUFDVHpGR2JmSjlEYWM0?= =?utf-8?B?dDVUK2daU0VTQ0lNVTAxbi9zdXZVeGZtdkJyY2RQVldLT3RZK1UweVZueEsx?= =?utf-8?B?T0RVZVg0YTZDVCtMUHRYTlNwcTV5cFFKbUp5YjVkbmFWdnBPbm5VWjVRM25k?= =?utf-8?B?QjRmYTllWXlLRWVXV2RmSFpDV24zano4YWF1anZiTXhJRzhlNG5ZbnNPM2FB?= =?utf-8?B?TEREeElseGVqUkVPbUJ0dkk0dEZOeUNLd09CcDZDNWJjTVdoRVQ1NnhFNWFx?= =?utf-8?B?YnNFRzIxbXJ1NElmK2RnR1QwWlgreC9jcUdQak1OMlFNd3J0ZHZURFQ2MkJj?= =?utf-8?B?R1FoWTBmR2dIOFgzTDdGTlF5NUlOUjh5QkVJSmVESFF4K05TQ0VkaUgrRnJM?= =?utf-8?B?ZjhCTVRDc0Nmc0IwWklqaXl1TkZKaFhuZUZiNllKRU52VlEwVEszS1ZVaGRz?= =?utf-8?B?R25xQWFRMG1aRGJxNG15UitYYVM4Nm40cDJ0SFZNbi9VR3JIUi9lSEZjbUFt?= =?utf-8?B?YmdsUDZtSlhUN1Z5ZXZxa1gwaVE2S0N0WDFkT0ZjZFZkVFJqblBWVWxka2J2?= =?utf-8?B?Q3htdGtyQnhRcVYxdHhXeG5vNmdERzUyWEV1MkZzUjdGZ0d3VzBMWEtkdzlH?= =?utf-8?B?NXl4TjIxckZYa3o5QzBDMzZlbC9BTzhKdVM2UkJraS9INCs0OHF5SkJxNHhB?= =?utf-8?B?aEQyYi9kMzNzOFo5SWt1TlZNL1FJYTRkUE41Q1BHNHE0eGtDOXh6L1hxWUVG?= =?utf-8?B?aW5yek5KelkzZjhOZy9NY3ljYWVaWDIxT1RqdE93eFNZYlpDMDkrMW13bXJ5?= =?utf-8?B?em95WXFiRG5WdEVja3RnWWlibWRRWmNETmZnYnI4QTYrQUlaUjRHTjdZT3dM?= =?utf-8?B?a21BbTdBMW1Tb2pvZEdQbnJqQVBVcEZXdGVPUVl6YjZZMDk2b09yU29RU3pK?= =?utf-8?B?MVBqMDh4SGo0dUJyTDFUZE11MkJ6elJnZHFvcC9HSUpIdDVUNVMyY3NZZ25J?= =?utf-8?Q?YFtkB/OP0q0biAi/6VRZwdRpgFqFvqSkuY3/bYQ?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5934 Original-Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 705cf9c1-e53d-409f-9416-08d93d486e13 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nu4JQnaZPmc50z86NHuc88Z4OCdtGGevA33lYQ7R4oL6IMkbtWagKh5OEHTZWvjxppJA5nw4UrUqtcDtFYjm4fHDo44ExTPxKfhvmKbpE/dbSvEq1sCoJQch8CGJ7c+J93NvBNpQ4TiRg8hSDCAEXW7QiUFibQ4oxtSTXWQar/qQK1BkSq+cTVCrfQmwAvc8d9haivBwnGgayP6jy1jNjBAY2ClS1jgwTnXCEAVSRLj9XeFzJZQSCO36XxYK+AWT9/EH7Y4mEpmN6H6/enSsfj9Yrle7+UobHmAukxcnkdA1AceHPE6zLIHgf++np+5uHRgzYbGgFTtDeOhBgcbk5dpmVycnVjb6SZ84NWFaMcey8TiHHhD/oSHQ8psoPK08c3YbmcNNiqpj5lu7ndAOukAxh0PGL/VwJCgMP1cILgxmzhAuk5uEYi9WDMINi4bDjw5pKpVWPUQG0yCgeqeviX2XAwfWdsqKXK7H9U5XarQhSFys89SlnbfkhXJ7RDtj64pqmWPQQ/8+Da8oq4piZ3pWEWSSPseJhy6Lgk/DHoJoZfjVrPxqZLwcS06ruI3qWTzikBAxxbHWA1fWRvqDZfFtdVwMCFxAvgAAH7e9KPkJa3bu8QTxVJV+l83DQoX73aeVk9Linli9BOk1GUYzIngMpVLhrKHulNOTTxRtgbyg75/UBqQXbCwxz3jMhvzau9GpKDWVb9//s2AJmrD/WA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39860400002)(136003)(396003)(376002)(346002)(36840700001)(46966006)(16526019)(956004)(8886007)(55016002)(82740400003)(2616005)(70586007)(33656002)(36860700001)(6916009)(186003)(478600001)(8936002)(1076003)(26005)(70206006)(7696005)(86362001)(450100002)(356005)(2906002)(82310400003)(4326008)(336012)(5660300002)(47076005)(83380400001)(44832011)(316002)(36756003)(8676002)(81166007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 10:59:29.6787 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d956b5ec-f981-4f7c-571a-08d93d487751 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7018 X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jul 2021 10:59:33 -0000 The 07/02/2021 15:12, Siddhesh Poyarekar via Libc-alpha wrote: > Build of iconvconfig failed with CFLAGS=-Os since __feof_unlocked is > not a public symbol. Replace with feof_unlocked (defined to > __feof_unlocked when IS_IN (libc)) to fix this. > > Reported-by: Szabolcs Nagy Thanks, this looks right. Reviewed-by: Szabolcs Nagy > --- > iconv/gconv_parseconfdir.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/iconv/gconv_parseconfdir.h b/iconv/gconv_parseconfdir.h > index e73ea0ff5c..915b60845c 100644 > --- a/iconv/gconv_parseconfdir.h > +++ b/iconv/gconv_parseconfdir.h > @@ -33,6 +33,7 @@ > # define closedir __closedir > # define mempcpy __mempcpy > # define lstat64 __lstat64 > +# define feof_unlocked __feof_unlocked > #endif > > /* Name of the file containing the module information in the directories > @@ -64,7 +65,7 @@ read_conf_file (const char *filename, const char *directory, size_t dir_len) > > /* Process the known entries of the file. Comments start with `#' and > end with the end of the line. Empty lines are ignored. */ > - while (!__feof_unlocked (fp)) > + while (!feof_unlocked (fp)) > { > char *rp, *endp, *word; > ssize_t n = __getdelim (&line, &line_len, '\n', fp); > -- > 2.31.1 >