public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: libc-alpha@sourceware.org
Cc: Stefan Liebler <stli@linux.ibm.com>
Subject: [PATCH] Exclude tst-realloc from tests-mcheck
Date: Tue,  6 Jul 2021 21:31:32 +0530	[thread overview]
Message-ID: <20210706160132.4166609-1-siddhesh@sourceware.org> (raw)

The realloc (NULL, 0) test in tst-realloc fails with gcc 7.x but
passes with newer gcc.  This is because a newer gcc transforms the
realloc call to malloc (0), thus masking the bug in mcheck.

Disable the test with mcheck for now.  The malloc removal patchset
will fix this and then remove this test from the exclusion list.

I'll push this soon if there are no objections.  I'll also post an
updated malloc hooks patchset with these issues fixed.

Reported-by: Stefan Liebler <stli@linux.ibm.com>
---
 malloc/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/malloc/Makefile b/malloc/Makefile
index 2f9b3d596d..2af1203a0a 100644
--- a/malloc/Makefile
+++ b/malloc/Makefile
@@ -93,7 +93,8 @@ tests-exclude-mcheck = tst-mallocstate \
 	tst-malloc-usable-tunables \
 	tst-malloc_info \
 	tst-memalign \
-	tst-posix_memalign
+	tst-posix_memalign \
+	tst-posix-realloc
 
 tests-mcheck = $(filter-out $(tests-exclude-mcheck), $(tests))
 
-- 
2.31.1


             reply	other threads:[~2021-07-06 16:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 16:01 Siddhesh Poyarekar [this message]
2021-07-06 16:12 ` Siddhesh Poyarekar
2021-07-06 17:58   ` Carlos O'Donell
2021-07-06 17:59 ` Carlos O'Donell
2021-07-07  7:49   ` Stefan Liebler
2021-07-07  7:59     ` Siddhesh Poyarekar
2021-07-07  8:07       ` Stefan Liebler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210706160132.4166609-1-siddhesh@sourceware.org \
    --to=siddhesh@sourceware.org \
    --cc=libc-alpha@sourceware.org \
    --cc=stli@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).