From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: libc-alpha@sourceware.org
Cc: carlos@redhat.com, dj@redhat.com, fweimer@redhat.com
Subject: [PATCH v9 01/10] Make mcheck tests conditional on GLIBC_2.23 or earlier
Date: Mon, 19 Jul 2021 08:11:25 +0530 [thread overview]
Message-ID: <20210719024134.155398-2-siddhesh@sourceware.org> (raw)
In-Reply-To: <20210719024134.155398-1-siddhesh@sourceware.org>
Targets with base versions of 2.24 or later won't have
__malloc_initialize_hook because of which the tests will essentially
be the same as the regular malloc tests. Avoid running them instead
and save time.
---
malloc/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/malloc/Makefile b/malloc/Makefile
index 47369b6084..6cac2e5d8d 100644
--- a/malloc/Makefile
+++ b/malloc/Makefile
@@ -78,6 +78,8 @@ tests-exclude-malloc-check = tst-malloc-check tst-malloc-usable \
# Run all tests with MALLOC_CHECK_=3
tests-malloc-check = $(filter-out $(tests-exclude-malloc-check),$(tests))
+# -lmcheck needs __malloc_initialize_hook, which was deprecated in 2.24.
+ifeq ($(have-GLIBC_2.23)$(build-shared),yesyes)
# Tests that don't play well with mcheck. They are either bugs in mcheck or
# the tests expect specific internal behavior that is changed due to linking to
# libmcheck.a.
@@ -100,6 +102,7 @@ tests-exclude-mcheck = tst-mallocstate \
tst-reallocarray
tests-mcheck = $(filter-out $(tests-exclude-mcheck), $(tests))
+endif
routines = malloc morecore mcheck mtrace obstack reallocarray \
scratch_buffer_dupfree \
--
2.31.1
next prev parent reply other threads:[~2021-07-19 2:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 2:41 [PATCH v9 00/10] malloc hooks removal Siddhesh Poyarekar
2021-07-19 2:41 ` Siddhesh Poyarekar [this message]
2021-07-19 2:41 ` [PATCH v9 02/10] Remove __after_morecore_hook Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 03/10] Remove __morecore and __default_morecore Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 04/10] Move malloc hooks into a compat DSO Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 05/10] mcheck: Wean away from malloc hooks [BZ #23489] Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 06/10] Simplify __malloc_initialized Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 07/10] mtrace: Wean away from malloc hooks Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 08/10] glibc.malloc.check: " Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 09/10] Remove malloc hooks [BZ #23328] Siddhesh Poyarekar
2021-07-19 2:41 ` [PATCH v9 10/10] mcheck Fix malloc_usable_size [BZ #22057] Siddhesh Poyarekar
2021-07-19 11:07 ` [PATCH v9 00/10] malloc hooks removal Florian Weimer
2021-07-19 11:09 ` Siddhesh Poyarekar
2021-07-19 11:11 ` Florian Weimer
2021-07-19 11:17 ` Siddhesh Poyarekar
2021-07-19 11:20 ` Florian Weimer
2021-07-19 11:40 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210719024134.155398-2-siddhesh@sourceware.org \
--to=siddhesh@sourceware.org \
--cc=carlos@redhat.com \
--cc=dj@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).