From: Samuel Thibault <samuel.thibault@gnu.org>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>
Cc: libc-alpha@sourceware.org, DJ Delorie <dj@redhat.com>
Subject: Re: tst-interpose-static-thread-{m,malloc-}check linking statically?
Date: Thu, 22 Jul 2021 20:36:03 +0200 [thread overview]
Message-ID: <20210722183603.oyhlseeauavd2toa@begin> (raw)
In-Reply-To: <41e663cf-208d-4d9d-a8eb-351163d6e168@email.android.com>
Siddhesh Poyarekar, le jeu. 22 juil. 2021 02:48:06 +0530, a ecrit:
> On 22-Jul-2021 00:34, Samuel Thibault via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
>
> > tl;dr: I believe we want the patch below? AIUI the
> > tst-interpose-static-{no,}thread-{m,malloc-}check tests are supposed to
> > be linked completely statically?
>
> Those tests ought to be removed when malloc hooks get dropped since mcheck and
> malloc-check won't work with static libraries.
So this? Or just excluding tst-interpose-static-thread?
diff --git a/malloc/Makefile b/malloc/Makefile
index d54285192a..0980e2901b 100644
--- a/malloc/Makefile
+++ b/malloc/Makefile
@@ -72,7 +72,8 @@ test-srcs = tst-mtrace
# with MALLOC_CHECK_=3 because they expect a specific failure.
tests-exclude-malloc-check = tst-malloc-check tst-malloc-usable \
tst-mxfast tst-safe-linking \
- tst-compathooks-off tst-compathooks-on
+ tst-compathooks-off tst-compathooks-on \
+ tst-interpose-static-nothread tst-interpose-static-thread
# Run all tests with MALLOC_CHECK_=3
tests-malloc-check = $(filter-out $(tests-exclude-malloc-check),$(tests))
@@ -92,7 +93,8 @@ tests-exclude-mcheck = tst-mallocstate \
tst-malloc-thread-fail \
tst-malloc-usable-tunables \
tst-malloc_info \
- tst-compathooks-off tst-compathooks-on
+ tst-compathooks-off tst-compathooks-on \
+ tst-interpose-static-nothread tst-interpose-static-thread
tests-mcheck = $(filter-out $(tests-exclude-mcheck), $(tests))
endif
next prev parent reply other threads:[~2021-07-22 18:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 19:04 Samuel Thibault
[not found] ` <41e663cf-208d-4d9d-a8eb-351163d6e168@email.android.com>
2021-07-22 2:09 ` Siddhesh Poyarekar
2021-07-22 18:36 ` Samuel Thibault [this message]
2021-07-23 1:28 ` Siddhesh Poyarekar
2021-07-23 7:45 ` Samuel Thibault
2021-07-23 11:18 ` Siddhesh Poyarekar
2021-07-22 14:01 ` [PATCH] Exclude static tests for mcheck and malloc-check Siddhesh Poyarekar
2021-07-24 14:52 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210722183603.oyhlseeauavd2toa@begin \
--to=samuel.thibault@gnu.org \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).