From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hera.aquilenet.fr (hera.aquilenet.fr [IPv6:2a0c:e300::1]) by sourceware.org (Postfix) with ESMTPS id 19688385381D; Sat, 24 Jul 2021 14:52:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 19688385381D Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 1B0AC3EB; Sat, 24 Jul 2021 16:52:24 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BD88IluvlVYc; Sat, 24 Jul 2021 16:52:23 +0200 (CEST) Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49]) by hera.aquilenet.fr (Postfix) with ESMTPSA id E457D1F9; Sat, 24 Jul 2021 16:52:22 +0200 (CEST) Received: from samy by begin with local (Exim 4.94.2) (envelope-from ) id 1m7J0n-007Om0-51; Sat, 24 Jul 2021 16:52:21 +0200 Date: Sat, 24 Jul 2021 16:52:21 +0200 From: Samuel Thibault To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Exclude static tests for mcheck and malloc-check Message-ID: <20210724145221.epkcxyee4orkztvd@begin> References: <20210721190428.dfnqd4lpqdpohy2a@begin> <20210722140115.2911835-1-siddhesh@sourceware.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722140115.2911835-1-siddhesh@sourceware.org> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spamd-Bar: -- X-Rspamd-Server: hera X-Rspamd-Queue-Id: 1B0AC3EB X-Spamd-Result: default: False [-2.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCPT_COUNT_TWO(0.00)[2]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; BAYES_HAM(-3.00)[100.00%] X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Jul 2021 14:52:27 -0000 Siddhesh Poyarekar, le jeu. 22 juil. 2021 19:31:15 +0530, a ecrit: > mcheck and malloc-check no longer work with static binaries, so drop > those tests. > > Reported-by: Samuel Thibault Reviewed-by: Samuel Thibault > --- > malloc/Makefile | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/malloc/Makefile b/malloc/Makefile > index d54285192a..9b70831d38 100644 > --- a/malloc/Makefile > +++ b/malloc/Makefile > @@ -75,7 +75,8 @@ tests-exclude-malloc-check = tst-malloc-check tst-malloc-usable \ > tst-compathooks-off tst-compathooks-on > > # Run all tests with MALLOC_CHECK_=3 > -tests-malloc-check = $(filter-out $(tests-exclude-malloc-check),$(tests)) > +tests-malloc-check = $(filter-out $(tests-exclude-malloc-check) \ > + $(tests-static),$(tests)) > > # -lmcheck needs __malloc_initialize_hook, which was deprecated in 2.24. > ifeq ($(have-GLIBC_2.23)$(build-shared),yesyes) > @@ -94,7 +95,7 @@ tests-exclude-mcheck = tst-mallocstate \ > tst-malloc_info \ > tst-compathooks-off tst-compathooks-on > > -tests-mcheck = $(filter-out $(tests-exclude-mcheck), $(tests)) > +tests-mcheck = $(filter-out $(tests-exclude-mcheck) $(tests-static), $(tests)) > endif > > routines = malloc mcheck mtrace obstack reallocarray \ > @@ -290,16 +291,8 @@ $(objpfx)tst-interpose-thread-mcheck: \ > $(objpfx)tst-interpose-thread-malloc-check: \ > $(objpfx)tst-interpose-aux-thread.o $(shared-thread-library) > $(objpfx)tst-interpose-static-nothread: $(objpfx)tst-interpose-aux-nothread.o > -$(objpfx)tst-interpose-static-nothread-mcheck: \ > - $(objpfx)tst-interpose-aux-nothread.o > -$(objpfx)tst-interpose-static-nothread-malloc-check: \ > - $(objpfx)tst-interpose-aux-nothread.o > $(objpfx)tst-interpose-static-thread: \ > $(objpfx)tst-interpose-aux-thread.o $(static-thread-library) > -$(objpfx)tst-interpose-static-thread-mcheck: \ > - $(objpfx)tst-interpose-aux-thread.o $(static-thread-library) > -$(objpfx)tst-interpose-static-thread-malloc-check: \ > - $(objpfx)tst-interpose-aux-thread.o $(static-thread-library) > > tst-dynarray-ENV = MALLOC_TRACE=$(objpfx)tst-dynarray.mtrace \ > LD_PRELOAD=$(objpfx)libc_malloc_debug.so