From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from butterfly.birch.relay.mailchannels.net (butterfly.birch.relay.mailchannels.net [23.83.209.27]) by sourceware.org (Postfix) with ESMTPS id 394B03835437 for ; Tue, 27 Jul 2021 17:41:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 394B03835437 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 8772B121CD6; Tue, 27 Jul 2021 17:41:56 +0000 (UTC) Received: from pdx1-sub0-mail-a35.g.dreamhost.com (100-96-17-89.trex.outbound.svc.cluster.local [100.96.17.89]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E2146122140; Tue, 27 Jul 2021 17:41:55 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a35.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.17.89 (trex/6.3.3); Tue, 27 Jul 2021 17:41:56 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Suffer-Robust: 62b83c5f7d8397ab_1627407716162_2844435459 X-MC-Loop-Signature: 1627407716162:2192649406 X-MC-Ingress-Time: 1627407716160 Received: from pdx1-sub0-mail-a35.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a35.g.dreamhost.com (Postfix) with ESMTP id 92D5D86717; Tue, 27 Jul 2021 10:41:55 -0700 (PDT) Received: from rhbox.redhat.com (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a35.g.dreamhost.com (Postfix) with ESMTPSA id A130186127; Tue, 27 Jul 2021 10:41:52 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a35 From: Siddhesh Poyarekar To: libc-alpha@sourceware.org Subject: [PATCH 4/5] copy_and_spawn_sgid: Avoid double calls to close() Date: Tue, 27 Jul 2021 23:11:28 +0530 Message-Id: <20210727174129.3612656-5-siddhesh@sourceware.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210727174129.3612656-1-siddhesh@sourceware.org> References: <20210727174129.3612656-1-siddhesh@sourceware.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3494.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jul 2021 17:42:00 -0000 If close() on infd and outfd succeeded, reset the fd numbers so that we don't attempt to close them again. --- support/support_capture_subprocess.c | 1 + 1 file changed, 1 insertion(+) diff --git a/support/support_capture_subprocess.c b/support/support_captu= re_subprocess.c index 27bfd19c93..0bacf6dbc2 100644 --- a/support/support_capture_subprocess.c +++ b/support/support_capture_subprocess.c @@ -170,6 +170,7 @@ copy_and_spawn_sgid (char *child_id, gid_t gid) support_subprogram because we only want the program exit status, no= t the contents. */ ret =3D 0; + infd =3D outfd =3D -1; =20 char * const args[] =3D {execname, child_id, NULL}; =20 --=20 2.31.1