From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 5EEEE385E44A for ; Thu, 29 Jul 2021 16:21:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5EEEE385E44A Received: by mail-pl1-x630.google.com with SMTP id c16so7559806plh.7 for ; Thu, 29 Jul 2021 09:21:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UZESKtibaRJ+QgvmDFgex+GstRvyH5IenmGg/XAUPlc=; b=Nq3zol8kZAXFQ0ITzy6UO0pA3YAcfd8l9xYj4uwNrmcZRZl1GZngJ4Gcpof6m3Ontu yv+VGDAmSyyYmXTMSDk1/dTtirNug3OHpPPLL5k5VZsh8qOYTFq2s6afJPXxbFL8Qa+4 SLMFWGGJCnjLZmI6hNlFVD8ZPQ8fvqlzZvAp1H1x27xHmlCfWPbZal4AtOQJwRtmLwtL Ro0/NlhXbX9mq6jWGkYCAXsNKxcJA7KaAARg/zUkAfDfwQQ+yijLnC0kPpQ7I2IB5neO ONQYyZ0BaruWz246xftjA+4fElXlsfg+uj88Mpduj/JDGw8P9JuwMgXL5FYoaJHHEkII eglw== X-Gm-Message-State: AOAM532ya1loiVi4DYLzfzrkEI6bbk74sjUoKV/TZowUXxzKLEcsKxtA Wrogbs2rErwCamUZeHLOECbHvlr+pkstlw== X-Google-Smtp-Source: ABdhPJx1jSHf73D3UxB/KapWIeaq0pzAVgVC1QLkUfPihZhNTP3Gki+gDSv0nqChgQWbFBSgBmsC+A== X-Received: by 2002:a05:6a00:124b:b029:358:fcd2:fa37 with SMTP id u11-20020a056a00124bb0290358fcd2fa37mr5845778pfi.35.1627575695294; Thu, 29 Jul 2021 09:21:35 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:d909:a67b:f0a0:a797]) by smtp.gmail.com with ESMTPSA id v29sm978536pfi.215.2021.07.29.09.21.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 09:21:34 -0700 (PDT) Date: Thu, 29 Jul 2021 09:21:30 -0700 From: Fangrui Song To: "H.J. Lu" Cc: GNU C Library Subject: Re: [PATCH 1/3] elf: Replace .tls_common with .tbss definition Message-ID: <20210729162130.p72kde6f47hunnmp@google.com> References: <20210726035802.275992-1-maskray@google.com> <20210726035802.275992-2-maskray@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-24.2 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, FSL_HELO_FAKE, GIT_PATCH_0, PDS_OTHER_BAD_TLD, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jul 2021 16:21:37 -0000 On 2021-07-29, H.J. Lu wrote: >On Sun, Jul 25, 2021 at 8:59 PM Fangrui Song via Libc-alpha > wrote: >> >> .tls_common is obsoleted, not supported by clang -fintegrated-as or ld.lld. >> Just change it to .tbss for portability. > >Please update the commit log for BZ #28152 I will be mindful when committing. >> >> --- >> elf/tls-macros.h | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/elf/tls-macros.h b/elf/tls-macros.h >> index e25e33b0f0..a637407417 100644 >> --- a/elf/tls-macros.h >> +++ b/elf/tls-macros.h >> @@ -1,7 +1,11 @@ >> /* Macros to support TLS testing in times of missing compiler support. */ >> >> #define COMMON_INT_DEF(x) \ >> - asm (".tls_common " #x ",4,4") >> + asm (".section .tbss\n\t" \ >> + ".globl " #x "\n\t" \ >> + ".balign 4\n\t" \ >> + #x ":\t.space 4\n\t" \ >> + ".previous") >> /* XXX Until we get compiler support we don't need declarations. */ >> #define COMMON_INT_DECL(x) >> >> -- >> 2.32.0.432.gabb21c7263-goog >> > > >-- >H.J.