* [PATCH v4 4/5] AArch64: Improve A64FX memset by removing unroll32
@ 2021-08-09 13:13 Wilco Dijkstra
2021-08-10 9:43 ` Szabolcs Nagy
0 siblings, 1 reply; 2+ messages in thread
From: Wilco Dijkstra @ 2021-08-09 13:13 UTC (permalink / raw)
To: naohirot; +Cc: 'GNU C Library'
v4: no changes
Remove unroll32 code since it doesn't improve performance.
---
diff --git a/sysdeps/aarch64/multiarch/memset_a64fx.S b/sysdeps/aarch64/multiarch/memset_a64fx.S
index 55f28b644defdffb140c88da0635ef099235546c..89dba912588c243e67a9527a56b4d3a44659d542 100644
--- a/sysdeps/aarch64/multiarch/memset_a64fx.S
+++ b/sysdeps/aarch64/multiarch/memset_a64fx.S
@@ -102,22 +102,6 @@ L(vl_agnostic): // VL Agnostic
ccmp vector_length, tmp1, 0, cs
b.eq L(L1_prefetch)
-L(unroll32):
- lsl tmp1, vector_length, 3 // vector_length * 8
- lsl tmp2, vector_length, 5 // vector_length * 32
- .p2align 3
-1: cmp rest, tmp2
- b.cc L(unroll8)
- st1b_unroll
- add dst, dst, tmp1
- st1b_unroll
- add dst, dst, tmp1
- st1b_unroll
- add dst, dst, tmp1
- st1b_unroll
- add dst, dst, tmp1
- sub rest, rest, tmp2
- b 1b
L(unroll8):
lsl tmp1, vector_length, 3
@@ -155,7 +139,7 @@ L(L1_prefetch): // if rest >= L1_SIZE
sub rest, rest, CACHE_LINE_SIZE * 2
cmp rest, L1_SIZE
b.ge 1b
- cbnz rest, L(unroll32)
+ cbnz rest, L(unroll8)
ret
// count >= L2_SIZE
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v4 4/5] AArch64: Improve A64FX memset by removing unroll32
2021-08-09 13:13 [PATCH v4 4/5] AArch64: Improve A64FX memset by removing unroll32 Wilco Dijkstra
@ 2021-08-10 9:43 ` Szabolcs Nagy
0 siblings, 0 replies; 2+ messages in thread
From: Szabolcs Nagy @ 2021-08-10 9:43 UTC (permalink / raw)
To: Wilco Dijkstra; +Cc: naohirot, 'GNU C Library'
The 08/09/2021 13:13, Wilco Dijkstra via Libc-alpha wrote:
> v4: no changes
>
> Remove unroll32 code since it doesn't improve performance.
OK to commit, but keep
Reviewed-by: Naohiro Tamura <naohirot@fujitsu.com>
>
> ---
>
> diff --git a/sysdeps/aarch64/multiarch/memset_a64fx.S b/sysdeps/aarch64/multiarch/memset_a64fx.S
> index 55f28b644defdffb140c88da0635ef099235546c..89dba912588c243e67a9527a56b4d3a44659d542 100644
> --- a/sysdeps/aarch64/multiarch/memset_a64fx.S
> +++ b/sysdeps/aarch64/multiarch/memset_a64fx.S
> @@ -102,22 +102,6 @@ L(vl_agnostic): // VL Agnostic
> ccmp vector_length, tmp1, 0, cs
> b.eq L(L1_prefetch)
>
> -L(unroll32):
> - lsl tmp1, vector_length, 3 // vector_length * 8
> - lsl tmp2, vector_length, 5 // vector_length * 32
> - .p2align 3
> -1: cmp rest, tmp2
> - b.cc L(unroll8)
> - st1b_unroll
> - add dst, dst, tmp1
> - st1b_unroll
> - add dst, dst, tmp1
> - st1b_unroll
> - add dst, dst, tmp1
> - st1b_unroll
> - add dst, dst, tmp1
> - sub rest, rest, tmp2
> - b 1b
>
> L(unroll8):
> lsl tmp1, vector_length, 3
> @@ -155,7 +139,7 @@ L(L1_prefetch): // if rest >= L1_SIZE
> sub rest, rest, CACHE_LINE_SIZE * 2
> cmp rest, L1_SIZE
> b.ge 1b
> - cbnz rest, L(unroll32)
> + cbnz rest, L(unroll8)
> ret
>
> // count >= L2_SIZE
>
--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-10 9:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-09 13:13 [PATCH v4 4/5] AArch64: Improve A64FX memset by removing unroll32 Wilco Dijkstra
2021-08-10 9:43 ` Szabolcs Nagy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).