From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: Fangrui Song <maskray@google.com>
Cc: libc-alpha@sourceware.org,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Szabolcs Nagy <nsz@port70.net>
Subject: Re: [PATCH v2] aarch64: Skip traditional GD/LD TLS which are unsupported by Clang and LLD [BZ #28205]
Date: Wed, 11 Aug 2021 13:17:42 +0100 [thread overview]
Message-ID: <20210811121740.GL20410@arm.com> (raw)
In-Reply-To: <20210810211458.oxx3t5phzt3z3sp3@google.com>
The 08/10/2021 14:14, Fangrui Song via Libc-alpha wrote:
> On 2021-08-10, Fangrui Song wrote:
> > TLSDESC is the default on aarch64. Clang doesn't support
> > -mtls-dialect=trad. Its integrated assembler doesn't support the
> > marker. LLD's doesn't support R_AARCH64_TLSGD_*/R_AARCH64_TLSLD_*
> > relocations. Just skip the tests.
> >
> > With https://sourceware.org/pipermail/libc-alpha/2021-August/129966.html
> > ("aarch64: Make elf_machine_{load_address, dynamic} robust [BZ #28203]"),
> > if we allow LLD in configure.ac,
> > `make check` test results of LLD are on par with GNU ld.
>
> I messed up in the diff.
> The correct diff needs `#include <config.h>` to make HAVE_TRAD_TLS
> defined.
the fixed patch looks good to me.
but now i looked at elf/tls-macros.h and it seems
to be for when there is on compiler support.
i think the only thing the compiler does not
support is mixing different tls access models to a
variable in the same tu, but i'm not sure if that's
useful or necessary for the tests: we can use many
files with different -ftls-model= or
__attribute__((tls_model(...))).
is there a need for these hard to maintain macros?
next prev parent reply other threads:[~2021-08-11 12:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 21:02 Fangrui Song
2021-08-10 21:14 ` Fangrui Song
2021-08-11 12:17 ` Szabolcs Nagy [this message]
2021-08-11 15:57 ` Fangrui Song
2021-08-11 21:34 ` Fangrui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210811121740.GL20410@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=maskray@google.com \
--cc=nsz@port70.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).