From: Fangrui Song <maskray@google.com>
To: Zack Weinberg <zack@owlfolio.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2] elf: Avoid nested functions in the loader (all ports) [BZ #27220]
Date: Thu, 23 Sep 2021 09:11:39 -0700 [thread overview]
Message-ID: <20210923161139.umgeaslcld5skele@google.com> (raw)
In-Reply-To: <2eeb347c-f8d9-48ac-b733-d67c0a25ee47@www.fastmail.com>
On 2021-09-23, Zack Weinberg wrote:
>On Thu, Sep 23, 2021, at 4:39 AM, Andreas Schwab wrote:
>> On Sep 23 2021, Fangrui Song wrote:
>>
>>> What do you mean by at the top?
>>
>> The opposite of bottom.
>
>In actually helpful terms, please put the #define for the guard macro immediately after the matching #ifndef. That’s how all the other headers do it.
>
>zw
Thanks for the explanation.
I fixed it and took the opportunity to fix the file-level comment as
well.
Updated https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/maskray/unnest
but do not bother sending v2 since this is a trivial change.
next prev parent reply other threads:[~2021-09-23 16:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 7:17 Fangrui Song
2021-09-23 8:07 ` Andreas Schwab
2021-09-23 8:17 ` Fangrui Song
2021-09-23 8:39 ` Andreas Schwab
2021-09-23 13:08 ` Zack Weinberg
2021-09-23 16:11 ` Fangrui Song [this message]
2021-09-23 16:19 ` H.J. Lu
2021-09-23 16:58 ` Fāng-ruì Sòng
2021-09-23 17:13 ` Florian Weimer
2021-09-23 17:34 ` Fāng-ruì Sòng
2021-09-23 17:40 ` Florian Weimer
2021-09-23 19:05 ` Fangrui Song
2021-09-23 21:48 ` Florian Weimer
2021-09-23 22:41 ` Fāng-ruì Sòng
2021-09-24 5:58 ` Florian Weimer
2021-09-24 7:23 ` Florian Weimer
2021-09-24 7:32 ` Fāng-ruì Sòng
2021-09-24 8:27 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923161139.umgeaslcld5skele@google.com \
--to=maskray@google.com \
--cc=libc-alpha@sourceware.org \
--cc=zack@owlfolio.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).