From: Fangrui Song <maskray@google.com>
To: libc-alpha@sourceware.org, Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH] glibcextract.py: Place un-assemblable @@@ in a comment
Date: Fri, 15 Oct 2021 09:29:35 -0700 [thread overview]
Message-ID: <20211015162935.a7sqpxrgk7lxhrix@google.com> (raw)
In-Reply-To: <20211008014014.800723-1-maskray@google.com>
On 2021-10-07, Fangrui Song wrote:
>Unlike GCC, Clang passes asm statements and verifies they are valid
>instructions/directives. Place the magic @@@ into a comment to avoid
>a parse error.
>---
> scripts/glibcextract.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/scripts/glibcextract.py b/scripts/glibcextract.py
>index 752ff6223b..bf49a5e322 100644
>--- a/scripts/glibcextract.py
>+++ b/scripts/glibcextract.py
>@@ -45,7 +45,7 @@ def compute_c_consts(sym_data, cc):
> continue
> name = arg[0]
> value = arg[1]
>- out_lines.append('asm ("@@@name@@@%s@@@value@@@%%0@@@end@@@" '
>+ out_lines.append('asm ("/* @@@name@@@%s@@@value@@@%%0@@@end@@@ */" '
> ': : \"i\" ((long int) (%s)));'
> % (name, value))
> out_lines.append('}')
>--
>2.33.0.882.g93a45727a2-goog
>
Ping..
next prev parent reply other threads:[~2021-10-15 16:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 1:40 Fangrui Song
2021-10-15 16:29 ` Fangrui Song [this message]
2021-10-19 6:18 ` Fāng-ruì Sòng
2021-10-19 7:40 ` Florian Weimer
2021-10-19 7:44 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015162935.a7sqpxrgk7lxhrix@google.com \
--to=maskray@google.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).