From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60088.outbound.protection.outlook.com [40.107.6.88]) by sourceware.org (Postfix) with ESMTPS id A6E443858400 for ; Mon, 18 Oct 2021 12:46:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A6E443858400 Received: from AM6PR10CA0037.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::14) by PAXPR08MB6544.eurprd08.prod.outlook.com (2603:10a6:102:157::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct 2021 12:46:56 +0000 Received: from AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:80:cafe::eb) by AM6PR10CA0037.outlook.office365.com (2603:10a6:209:80::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend Transport; Mon, 18 Oct 2021 12:46:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT028.mail.protection.outlook.com (10.152.16.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Mon, 18 Oct 2021 12:46:55 +0000 Received: ("Tessian outbound d5def7722ff7:v103"); Mon, 18 Oct 2021 12:46:55 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a16cde58d58d3dc8 X-CR-MTA-TID: 64aa7808 Received: from 9f99df6b989a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CB2857B9-CDBE-4871-B1F5-A1AB488EE8D3.1; Mon, 18 Oct 2021 12:46:48 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9f99df6b989a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 18 Oct 2021 12:46:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lCx+ZCWo8UcHzD3rKVUyARACFyHlk0XuX2NyUsNnPCJX0c5zf6JbALn616K/Ipp84P9EhTMs+8x1B201PbSgiyUtnkvi72zqN5C9YImdmvQ6RABMvl0p+Vwp0MGn4TVnOladINzlQfjgUPVcUGdX1PXlWblliVvWIlFeNulOUAtT8s+g723MjKGh3T23B5X73TW/E1x0mTKtoVtuciW+5qsB3hM8tAAL2qVmaDVOnEskQw+pPNV3wF60gBdso5JFNZ55MSLZG6S9t48jyuj7vxS0i+CaQhtYYhpoRBIkegmYQIU3bVBLxeYTlBYH9Aaj8iLPrdXttAJwKyof6BXiZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WGcWYbyK66k/myM5A/xeQZCLkXrXNeflbPy6rpy+yYM=; b=guewC9i/3z0Tf5P8BtpR6hHp5zKZrgo4a5Hx6ggN8QCFmresao8jbJJihErJsbhHsxaRgUZNbSm1LVPvRK+rHctFCTEFmWQWPSS1rWfDXxOgk8Hfm7MngG3YdyxSRvraHE4pOsz9y7X8VTx/Q8lTRa6eFhT/wkxVpaGhfmqrD5c8ItfY0sXCAjgGLckCLf597Silaw/HeSZjvqlH5lsh+QP/X5RMODkiK7pFiMTDcUaoq+TPz9LSc09bndaErPwViBJ1dLpMLYBpC8hCBXdFD3w94Ho1gTj6CcdRVZZJJepKWRmtPdzC3VhLwIUQZKvjLjz2Jp5tl0VywTE0SXlqaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DU2PR08MB7375.eurprd08.prod.outlook.com (2603:10a6:10:2f3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct 2021 12:46:47 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::2900:7140:8ac4:6846]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::2900:7140:8ac4:6846%6]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021 12:46:47 +0000 Date: Mon, 18 Oct 2021 13:46:39 +0100 From: Szabolcs Nagy To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Manuel Lauss Subject: Re: [PATCH] elf: Fix elf_get_dynamic_info() for bootstrap Message-ID: <20211018124639.GG1982710@arm.com> References: <20211015174123.2305597-1-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SN7PR04CA0074.namprd04.prod.outlook.com (2603:10b6:806:121::19) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 Received: from arm.com (217.140.106.52) by SN7PR04CA0074.namprd04.prod.outlook.com (2603:10b6:806:121::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Mon, 18 Oct 2021 12:46:45 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aa04246b-1132-4d32-a237-08d992355e0d X-MS-TrafficTypeDiagnostic: DU2PR08MB7375:|PAXPR08MB6544: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tiU5Fss6BJbgvjxSJX5mLkVYFZj8m4MVmY5wA0TQtxFC+5Ag2vusLJTTAAlWzM5GMwIwSW50nxPTnCNHpQaICqCOexFcqRfJ1U8Zrn3e6ZldPhrOGssE/J9LrdW/7wwnjuZ8v2YqANh9j/7DNBZQrhe2aNQ9DHVmWzJXYWJAq4uwBY/wtN5rADcbpQqboUOddLXlvZkZ3VOOoxecMHuij2M+++ynfvD/4yqF6lX3VmHGF1UhzCYeQ2qJRr5449+MEBNYPw0TJ0sJUofWt4BH79Mdn+A+hg0r2ZvcZm8zVIdjZeLnWANLNhn1FdOf19DqxmdgJrSo7H+hjLAQD0EiutOTfcV/mJgFxCapoLq3TeInkqyrgFRxRw6EBwNHFd3SptYkBMEzMzoXk/sCr3j2nXdomHjBLJcWpT6472XsibQFvcEgfg0/xVRtrypwPviljFkZZawJTul+UAPAbAH0a/g4gDecT3MzsD4JNZyxKmNPP5v22MTWjBhB1bbLmoOgJwxyntxAVggwgVodo+5EsKrN1jj89cv3gE0lVNTV3uvcg8clLvS4WPm3Di5f/tsFloGQFid8doo6VACBIX61da5a1Lq2oPKfubVzaWHCUnxE/Qui5/HLrOqEfehElzBkTnnzI+zVZ3GBQSI76sgVH1eL+D8Aquym55czPMvxBOsKVKX/siUeIZ6yuSA2C813BuE0hHr9iQTsTGlKp6W3GQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR08MB7179.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(86362001)(36756003)(2616005)(66476007)(55016002)(8886007)(4326008)(44832011)(508600001)(33656002)(316002)(26005)(8676002)(2906002)(1076003)(8936002)(956004)(5660300002)(66556008)(6916009)(53546011)(186003)(66946007)(7696005)(38100700002)(52116002)(6666004)(38350700002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7375 Original-Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d2b3b070-25e1-4aaa-46ce-08d9923558be X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kr5+3bFEWDynI7D41p6Ddf3mrczhZhmXf3WWq+TqlrMl/4fcE51SaRKIur871xjPtdtMzoM+Ta4yYQLvnK38RUaFqNjlY3kU7lOdGysCY56cKD05sz/f3UKytMPvN0yrg6pwDMY6c34hl9ZsKmbs+akhVfEjNjaRwLvvewTlnwQ6TsmO9rDyesn3Kcf/tONw5eOFmOY13RXx58ClUKHhvYsJq+VdYryjxftFj9I2AvAN0fsGvXn1zQ7CT+Ga2z8wODfwzhRlTq++ljvxekBZO+ksnJh+DG3hf47/otMkCgVmiR6e3x9m+tjfHSCqdDvYhKWiHivnTpfxzHWmHC9hNujR0DnxbAReegYRL9bCNDjAS2SsOIBXzeJvnnoWVA4njNGJWlukObpEcIn0LMTSaJY5gyc7B0Vk5YhvTpiugxqfKJIoUnK4FGKpMGDadelzunTRlJu3rxs3RSRvd4svbDFmBM0JWDmawEhLgZprcdaE4JMFgf33y0sb6pUadM5qykiLDHuz92ZEI8IvmkQaUrrZFEEXi1n9pYTyRVeofSxcJGP77r39q3E2UqweaWdf/2/r7ffYPb7wL8Sobj8nyjiK1thVO6q40yLLlnYx2O61dl+lzbayEkraQvqEMmUuGYcq5v/1EM4X9N3p8JaD4iIeawJ77hZ8gdMcyr1h9SI5bH0UWrk3CdIlUXtaLY5/ZkrrcBAdGXsv6Koh6cVZhA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(8676002)(316002)(44832011)(70586007)(1076003)(47076005)(186003)(356005)(6666004)(33656002)(5660300002)(336012)(8886007)(36756003)(7696005)(70206006)(82310400003)(508600001)(6862004)(2906002)(8936002)(86362001)(36860700001)(26005)(55016002)(81166007)(107886003)(53546011)(956004)(2616005)(4326008); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 12:46:55.7919 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aa04246b-1132-4d32-a237-08d992355e0d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6544 X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2021 12:47:00 -0000 The 10/15/2021 14:42, Adhemerval Zanella wrote: > > > On 15/10/2021 14:41, Adhemerval Zanella wrote: > > THe d6d89608ac8c broke powerpc for --enable-bind-now because it turned > > out that different than patch assumption rtld elf_get_dynamic_info() > > does require to handle RTLD_BOOTSTRAP to avoid DT_FLAGS and > > DT_RUNPATH (more specially the GLRO usage which is not reallocate > > yet). > > > > This patch fixes by passing two arguments to elf_get_dynamic_info() > > to inform that by rtld (bootstrap) or static pie initialization > > (static_pie_bootstrap). I think using explicit argument is way more > > clear and burried C preprocessor, and compiler should remove the > > dead code. > > > > I checked on x86_64 and i686 with default options, --enable-bind-now, > > and --enable-bind-now and --enable--static-pie. I also check on > > aarch64, armhf, powerpc64, and powerpc with default and > > --enable-bind-now. > > Manuel and Szabolcs, > > If you could check if this breaks something in your environment I would > be grateful. I really want to fix this nasty regression... the patch works for me too.