From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by sourceware.org (Postfix) with ESMTPS id 1072C3858412 for ; Mon, 25 Oct 2021 18:25:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1072C3858412 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=denx.de Received: from ktm (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 6F43F80607; Mon, 25 Oct 2021 20:25:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1635186344; bh=AT+CPkAU9D9gIqAB97hGSh4DcTqEL/sSwzHjGnhkecg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=k3TelBY0h24QFvJ+n3sWjQIuXlYTiPhgfESOnHgSFD7NaXqaXZMGPpYIxAtIU9r/U kXz2ppSqfVFOAoYF0nxMiuQKwocZR3FwH4pyNznmkdqqmnQ0lavDU2PBZqCRUZ15ZT A6mp8eJ3j1NXxIPOiJGgVDMT0Cp+qftHjVneELzR/gufhMOzYL59dP+tlfd0HVU+A4 hZf5Ts1I4/D6BAqg+Agobxxz8NGkhZjobpvslFAtmV900kCEQPj3qWZmdhmGv1Dr9U e4EVCJ+pKiCXX7VVe6qLC8JGC2LDhNer3LbdilgzGDrhNbl5Ji6iH0iumeYu52CVdM OIAoMV72VGGzw== Date: Mon, 25 Oct 2021 20:25:42 +0200 From: Lukasz Majewski To: Szabolcs Nagy Cc: Florian Weimer , =?UTF-8?B?RsSBbmctcnXDrCBTw7Ju?= =?UTF-8?B?Zw==?= , "H.J. Lu" , "libc-alpha@sourceware.org" , Patches and discussions about the oe-core layer , Andreas Schwab , Joseph Myers , Carlos O'Donell Subject: Re: [PATCH v2] dl: Use "adr" assembler command to get proper load address on ARM Message-ID: <20211025202542.38a79fc9@ktm> In-Reply-To: <20211025150904.GO1982710@arm.com> References: <20211015145831.5d0fafcd@ktm> <20211018110818.GE1982710@arm.com> <871r4iftvc.fsf@oldenburg.str.redhat.com> <20211025121819.16f63048@ktm> <878ryhwgd7.fsf@oldenburg.str.redhat.com> <20211025125307.1fa34445@ktm> <20211025133425.GN1982710@arm.com> <20211025160444.09f0c5e0@ktm> <20211025150904.GO1982710@arm.com> Organization: denx.de X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/4aN61=gbbTXF0Loina0Z+BD"; protocol="application/pgp-signature" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Oct 2021 18:25:48 -0000 --Sig_/4aN61=gbbTXF0Loina0Z+BD Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Szabolcs, > The 10/25/2021 16:04, Lukasz Majewski wrote: > > > > > Either fix the prelink tool not to prelink shared objects > > > > > that do not have a dependency on libc.so.6, or fix the > > > > > dynamic loader to work if prelinked on AArch64. =20 > > > >=20 > > > > Just for the correctness - both 64 and 32 bit ARMs are > > > > affected. =20 > > >=20 > > > last time i looked, prelinking did not support tlsdesc > > > correctly so it is unusable for aarch64. > > >=20 > > > does yocto/oe use prelinking on aarch64? =20 > >=20 > > I think yes - the=20 > > USER_CLASSES ?=3D "buildstats image-prelink" > >=20 > > is added by default to local.conf =20 >=20 > ok, i think we need the patches upstream for that like > https://sourceware.org/pipermail/libc-alpha/2015-November/066153.html >=20 Oh... I see. > > > > > I do not have a strong opinion. =20 > > > >=20 > > > > Thanks for your opinion. Let's wait for other community members > > > > opinions. =20 > > >=20 > > > i think fixing the arm load address computation makes > > > sense (small extra cost of a relative reloc). i think > > > the c code proposal i made in the thread is nicer than > > > the old asm. > > >=20 > > > (i'm happy to make the same change on aarch64 too if > > > prelinking is used there, but i think that's broken.) =20 > >=20 > > +1 =20 >=20 > since you have a prelink setup, can you prepare the > arm and aarch64 patches? >=20 I can prepare the patch - no problem. Beforehand, I would like to hear from the community if we do have a consensus about this solution... > (i suspect x86 would need the same fix, but probably > prelink is not used there anymore..?) I do assume that in yocto at least it would use prelink by default as well. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/4aN61=gbbTXF0Loina0Z+BD Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmF29qYACgkQAR8vZIA0 zr10jAgA0hTDDzgDT4HSY+YEnh7OIHWfTPvLMuowvFsm8XM3R67jytbfky0ELjdM 95JKRXOi8TmfT6j1CSruqG682KLZdlFoYZI7q1x1MvBbDfHmROb5u3991Z0Gf637 4GRsVogOlm4F8yzqM17aUDeaZKi5BmrWKiQfR19ghwR2bpfIsTavDdUHAy0xczlb k2Rgah0Qnt5U9sgCVXYv7y1WL8YUhKbp1OekNi/rMLvkmiFt9IvsdgBjr6O9kKkt WEjkrEAYfUdBlvVP8U8OmQLEU3JIw66fZNYFKLpSIoZdGhvizprQyOUjxtX2Vy0F K35u1WumQbJIkVb+LbH/s93ApZLTVw== =Z2P6 -----END PGP SIGNATURE----- --Sig_/4aN61=gbbTXF0Loina0Z+BD--