From: Stafford Horne <shorne@gmail.com>
To: GLIBC patches <libc-alpha@sourceware.org>
Subject: [PATCH] tst-tzset: output reason when creating 4GiB file fails
Date: Fri, 29 Oct 2021 06:23:00 +0900 [thread overview]
Message-ID: <20211028212300.2311323-1-shorne@gmail.com> (raw)
Currently, if the temporary file creation fails the create_tz_file
function returns NULL. The NULL pointer is then passed to setenv which
causes a SIGSEGV. Rather than failing with a SIGSEGV print a warning
and exit.
---
timezone/tst-tzset.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/timezone/tst-tzset.c b/timezone/tst-tzset.c
index d6da2932bb..e6aef6bf51 100644
--- a/timezone/tst-tzset.c
+++ b/timezone/tst-tzset.c
@@ -103,6 +103,13 @@ static void
test_tz_file (off64_t size)
{
char *path = create_tz_file (size);
+ if (path == NULL)
+ {
+ printf ("creating timezone file of size: %lld MiB failed.\n",
+ size / (1024 * 1024));
+ exit (1);
+ }
+
if (setenv ("TZ", path, 1) < 0)
{
printf ("setenv failed: %m\n");
--
2.31.1
next reply other threads:[~2021-10-28 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 21:23 Stafford Horne [this message]
2021-10-29 12:14 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028212300.2311323-1-shorne@gmail.com \
--to=shorne@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).