From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 601053858020 for ; Mon, 1 Nov 2021 16:38:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 601053858020 Received: by mail-pl1-x62f.google.com with SMTP id p18so8604738plf.13 for ; Mon, 01 Nov 2021 09:38:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Mi/Boug7kVBASHb37Kx2+Kv9vUpMqa2xSs1tiuo4MFE=; b=HtIpUj33LyKVvvV5ENBGmkqhPVP/GQZeFs7oxuwyw7Q7FvtAutpnhtk0zLuM+4D762 59C+rvHq6aP9D/3xw2dbfF994KNL3Wj1SIthoudPjCysmzPITTI8Kpb5zkUCLiVV/hCy 18q71h2AUIrwiZRwosF59ZeR4fX4nX/ianrV0Rp7jREsDZpeTaAcr6IrHaT5ExYoxeFb huv1kBvO0YxQTEshzoxKNQ513EHjlvZMDpHgeKYI7gU17zsdosIKNO33GpomcumEjJFy gIqrkH1SlYHPhG+4Z+2FNUDseCZ5M9+Y92bdoMUGYT9Pi8BstNIJ60ixpqZJNvNbj/C5 95SA== X-Gm-Message-State: AOAM530N9g4SJiyWpmLxZYyuC+aNkz8+Kc+GGhkiWuuaAK3XCYZCHKmV gfvj3BTcmzPwELLCOfzHx490NI7Wc3TdlQ== X-Google-Smtp-Source: ABdhPJw5FgxkbBabetYK/jcBDZZUEFy7YbNk/RPMy9qpVIqeAHURepj1anPejySG+qkmWFjyStIBTg== X-Received: by 2002:a17:90b:30e:: with SMTP id ay14mr57056pjb.60.1635784715254; Mon, 01 Nov 2021 09:38:35 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:f5cb:808f:4f47:f1b7]) by smtp.gmail.com with ESMTPSA id j1sm13466467pgb.5.2021.11.01.09.38.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 09:38:34 -0700 (PDT) Date: Mon, 1 Nov 2021 09:38:32 -0700 From: =?utf-8?B?RsSBbmctcnXDrCBTw7JuZw==?= To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 1/3] arm: Use internal symbol for _dl_argv on _dl_start_user Message-ID: <20211101163832.fwhpd5hvo6w2ybtj@google.com> References: <20211101125003.500945-1-adhemerval.zanella@linaro.org> <20211101125003.500945-2-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20211101125003.500945-2-adhemerval.zanella@linaro.org> X-Spam-Status: No, score=-27.4 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2021 16:38:40 -0000 On 2021-11-01, Adhemerval Zanella wrote: >The lld does not support R_ARM_GOTOFF32 to preemptible symbol (_dl_argv >has global visibility). Use the internal alias instead (one option s/global visibility/default visibility/ >would to use HIDDEN_JUMPTARGET, bu the macro is not defined for >!__ASSEMBLER__ and I made this patch arm-specific to avoid require to >check extensivelly on other architecture it this might break something). > >Checked on arm-linux-gnueabihf. >--- > sysdeps/arm/dl-machine.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/sysdeps/arm/dl-machine.h b/sysdeps/arm/dl-machine.h >index c758bba169..4ecdde4355 100644 >--- a/sysdeps/arm/dl-machine.h >+++ b/sysdeps/arm/dl-machine.h >@@ -202,7 +202,7 @@ _dl_start_user:\n\ > .L_FINI_PROC:\n\ > .word _dl_fini(GOTOFF)\n\ > .L_ARGV:\n\ >- .word _dl_argv(GOTOFF)\n\ >+ .word __GI__dl_argv(GOTOFF)\n\ > .L_LOADED:\n\ > .word _rtld_local(GOTOFF)\n\ > .previous\n\ >-- >2.32.0 > Reviewed-by: Fangrui Song