From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by sourceware.org (Postfix) with ESMTPS id 3B2503858432 for ; Mon, 1 Nov 2021 16:42:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3B2503858432 Received: by mail-pj1-x102c.google.com with SMTP id gt5so4216921pjb.1 for ; Mon, 01 Nov 2021 09:42:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/DdcYEE7+Sn/4kU7N+vcw7WuB3KkO06r6cdFDfrOaRs=; b=kFj4AeafLihjx4G5SbOhKBZHUzoamaZQpRf2gU3/mH6eEn2tCGX4f9YNUrQbEam0cx 0x8cACK8HxOEQJIvwtdg1F/06pBDldqa3sePxgCGBIfJn36eYgqbQPX8PXGmqWiFkCSu 6ndLUk5TdsbdsolrwmrvIL5FOF4UamA8Q0Q9FYaYhrLy16ou0s68ZCy8iQdnP6X37er2 OPbiAJN6JuNg/1BJyh40aG8B+beWIU+AOW+qI0qVpbbP4W3itvZrC6rUdO6CSaJC/ID5 S4qpmroZfIk7OhHS7N/R5FCcChIpkvxDl1fu9I8ITItZcI3asL8Xl+DGZlp/MrCVNgKh +aEA== X-Gm-Message-State: AOAM531zOwp6kym1zmuKyblDAftthGhcYBoBHXCq4y8fo9EW94Rb11CI SBKzqQHXDYXOvhlsG/G/iUTmhKoHJBfZUw== X-Google-Smtp-Source: ABdhPJzFrFu3NtUFdQGLbABhr49X3cZ8U02qmAauTMJklOgDxx8lIjmvV/SScdxU2TkpOIOhsd6uxw== X-Received: by 2002:a17:902:934c:b0:13d:c685:229b with SMTP id g12-20020a170902934c00b0013dc685229bmr25702881plp.25.1635784935125; Mon, 01 Nov 2021 09:42:15 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:f5cb:808f:4f47:f1b7]) by smtp.gmail.com with ESMTPSA id l1sm15733923pff.125.2021.11.01.09.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 09:42:14 -0700 (PDT) Date: Mon, 1 Nov 2021 09:42:12 -0700 From: =?utf-8?B?RsSBbmctcnXDrCBTw7JuZw==?= To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 2/3] arm: Use have-mtls-dialect-gnu2 to check for ARM TLS descriptors support Message-ID: <20211101164212.u472u3xzpvkbyezg@google.com> References: <20211101125003.500945-1-adhemerval.zanella@linaro.org> <20211101125003.500945-3-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20211101125003.500945-3-adhemerval.zanella@linaro.org> X-Spam-Status: No, score=-27.2 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2021 16:42:17 -0000 On 2021-11-01, Adhemerval Zanella wrote: >The lld linker does not support TLSDESC for arm. The have-arm-tls-desc >is a leftover of 56583289b1 to support NaCL. > >Checked on arm-linux-gnueabihf. Thanks! >--- > sysdeps/arm/Makefile | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > >diff --git a/sysdeps/arm/Makefile b/sysdeps/arm/Makefile >index fb4164f0d9..da4226c8c8 100644 >--- a/sysdeps/arm/Makefile >+++ b/sysdeps/arm/Makefile >@@ -1,11 +1,6 @@ > gnulib-arch = $(elf-objpfx)libgcc-stubs.a > static-gnulib-arch = $(elf-objpfx)libgcc-stubs.a > >-# All supported build tools support TLS descriptors, but the OS may not. >-ifndef have-arm-tls-desc >-have-arm-tls-desc = yes >-endif >- > ifeq ($(subdir),elf) > sysdep-dl-routines += tlsdesc dl-tlsdesc > sysdep_routines += aeabi_unwind_cpp_pr1 find_exidx >@@ -18,7 +13,7 @@ $(objpfx)libgcc-stubs.a: $(objpfx)aeabi_unwind_cpp_pr1.os > lib-noranlib: $(objpfx)libgcc-stubs.a > > ifeq ($(build-shared),yes) >-ifeq ($(have-arm-tls-desc),yes) >+ifeq (yes,$(have-mtls-dialect-gnu2)) > tests += tst-armtlsdescloc tst-armtlsdescextnow tst-armtlsdescextlazy > modules-names += tst-armtlsdesclocmod > modules-names += tst-armtlsdescextlazymod tst-armtlsdescextnowmod >-- >2.32.0 > Reviewed-by: Fangrui Song