From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id 988793858C27 for ; Wed, 3 Nov 2021 01:15:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 988793858C27 Received: by mail-pg1-x533.google.com with SMTP id a9so905702pgg.7 for ; Tue, 02 Nov 2021 18:15:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Y52CQSTgr8k48RNFQlfnjMVUoYWuQrZvVfFLxGPH7WM=; b=akXXQRS8S51JU4k1mWiKpjBN7qQzwcvVcnfJ9rp+AeLPqfHdY68+yyns7n+gcGAgYB vs3asVnqTKE4joYGo6sqEpIMxvdbSBH7hy+rq/ofPci03PDqa0GJ09hf5TBL7roaqRP2 ewMoXW1VeWnv8IhK+iDh2UikRO58i9J6pKcWUsWFrNrWvvOpZ0buI7lEhUDghOIWw+oM 8xO0xEpOGrc0mjNai2OrHQIdG4DNtcffiqJpbr5ytnNp+NzS2GlNJqxODuXUY0jQS2sm 9yc/bFNFHWsnwrP4/j8WQXWGG5p/MTWFMfOIrqWJeRlVlZMo+0bYbT2MinnCA2ktz5Qq k00A== X-Gm-Message-State: AOAM532VTaxy7MaoVbxVSRjZBsZrXHkPlM4QT9fv1a8DlbL/MIWL3edb 0r40D6FUsLjUNjfXOJOKcNroPXELe45z8g== X-Google-Smtp-Source: ABdhPJxUug1RorriScDGhgg/io5do1rakYsW8GNH7u28MWLEsCw61iaRu0nk8ZpfFfoPKqSzG9A/4w== X-Received: by 2002:a63:7006:: with SMTP id l6mr30358045pgc.402.1635902134562; Tue, 02 Nov 2021 18:15:34 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:be09:83e2:3abe:b3eb]) by smtp.gmail.com with ESMTPSA id e15sm3610145pja.52.2021.11.02.18.15.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 18:15:34 -0700 (PDT) Date: Tue, 2 Nov 2021 18:15:31 -0700 From: Fangrui Song To: "H.J. Lu" Cc: GNU C Library Subject: Re: [PATCH] x86-64: Replace movzx with movzbl Message-ID: <20211103011531.yiuufsybf5e56rnt@google.com> References: <20211102204459.3405575-1-maskray@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-27.3 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2021 01:15:37 -0000 On 2021-11-02, H.J. Lu wrote: >On Tue, Nov 2, 2021 at 1:45 PM Fangrui Song wrote: >> >> Clang cannot assemble movzx in the AT&T dialect mode. >> >> ../sysdeps/x86_64/strcmp.S:2232:16: error: invalid operand for instruction >> movzx (%rsi), %ecx >> ^~~~ >> >> Change movzx to movzbl, which follows the AT&T dialect and is used >> elsewhere in the file. >> --- >> sysdeps/x86_64/strcmp.S | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/sysdeps/x86_64/strcmp.S b/sysdeps/x86_64/strcmp.S >> index c7cbe4042a..bfe83abede 100644 >> --- a/sysdeps/x86_64/strcmp.S >> +++ b/sysdeps/x86_64/strcmp.S >> @@ -2229,8 +2229,8 @@ LABEL(strcmp_exitz): >> >> .p2align 4 >> LABEL(Byte0): >> - movzx (%rsi), %ecx >> - movzx (%rdi), %eax >> + movzbl (%rsi), %ecx >> + movzbl (%rdi), %eax >> >> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L >> leaq _nl_C_LC_CTYPE_tolower+128*4(%rip), %rdx >> -- >> 2.33.1.1089.g2158813163f-goog >> > >LGTM. > >Reviewed-by: H.J. Lu > >Thanks. Thanks for the quick review! Just noticed that sysdeps/x86_64/multiarch/strcmp-sse42.S has a similar pattern which needs fixing as well. I'll fix that, too.