public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: libc-alpha@sourceware.org
Cc: Florian Weimer <fweimer@redhat.com>
Subject: [PATCH v2 0/2] Update Makefile fragments for DSO sorting tests
Date: Mon,  8 Nov 2021 07:42:09 -0800	[thread overview]
Message-ID: <20211108154211.167829-1-hjl.tools@gmail.com> (raw)

One problem of using

$(objpfx)%$o: $(objpfx)%.c $(before-compile); $$(compile-command.c)
compile-command.c = $(compile.c) $(OUTPUT_OPTION) $(compile-mkdep-flags)
compile.c = $(CC) $< -c $(CFLAGS) $(CPPFLAGS)

to build DSO sorting relocatable objects is that $< may not be the source
file with 3 "make -j 28" parallel builds on a machine with 112 cores.
When generating Makefile fragments at build time, the same file may be
generated more than once at the same time with parallel builds.

1. Update dso-ordering-test.py to put all sources for DSO sorting tests
in a single directory, dso-sort-tests-src, and compile relocatable objects
with

$(objpfx)tst-dso-ordering1-dir/tst-dso-ordering1-a.os: $(objpfx)dso-sort-tests-src/tst-dso-ordering1-a.c
	$(compile.c) $(OUTPUT_OPTION)

2. Generate Makefile fragments for DSO sorting tests at configure time
to avoid generate them in the elf directory at build time.

H.J. Lu (2):
  dso-ordering-test.py: Put all sources in one directory [BZ #28550]
  elf: Pre-generate Makefile fragment for DSO sorting tests [BZ #28550]

 configure                    | 11 +++++++++
 configure.ac                 | 12 +++++++++
 elf/Makefile                 | 22 ++++-------------
 scripts/dso-ordering-test.py | 47 ++++++++++++++++++++++++++----------
 4 files changed, 62 insertions(+), 30 deletions(-)

-- 
2.33.1


             reply	other threads:[~2021-11-08 15:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 15:42 H.J. Lu [this message]
2021-11-08 15:42 ` [PATCH v2 1/2] dso-ordering-test.py: Put all sources in one directory [BZ #28550] H.J. Lu
2021-11-11 17:52   ` Chung-Lin Tang
2021-11-11 18:21     ` H.J. Lu
2021-11-15 18:50   ` Adhemerval Zanella
2021-11-08 15:42 ` [PATCH v2 2/2] elf: Pre-generate Makefile fragment for DSO sorting tests " H.J. Lu
2021-11-15 18:59   ` Adhemerval Zanella
2021-11-15 19:51     ` H.J. Lu
2021-11-15 20:18       ` Adhemerval Zanella
2021-11-16  4:48         ` [PATCH] elf: Use a temporary file to generate Makefile fragments " H.J. Lu
2021-11-16 12:52           ` Adhemerval Zanella
2021-11-16 13:15             ` H.J. Lu
2021-11-11 13:46 ` [PATCH v2 0/2] Update Makefile fragments for DSO sorting tests H.J. Lu
2021-11-11 14:05   ` Adhemerval Zanella
2021-11-15 14:43     ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211108154211.167829-1-hjl.tools@gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).