From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by sourceware.org (Postfix) with ESMTPS id CCE2D3858D3C for ; Mon, 8 Nov 2021 19:44:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CCE2D3858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=denx.de Received: from ktm (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 85DFC83816; Mon, 8 Nov 2021 20:44:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1636400686; bh=BohQcHuKF6ZFl2fiSpcbJoXPDjLb0luoihFE2YYqQeg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QSdpm93zKyhfJufhuAQPIRIPgk6AdvwbW6tZbflgtSud8a28OGjg91ePoQEd00YF8 UaDrMqAlB6FXe9+vZe2Vw4TAirG5aq3r2OQ3YdYnXKttazOrdCebEuPAUuTbjPeLk+ Vs96gXEYVS/z/Ocbs0tBEln5nu0E4sY4BUsbroz0YA5HNNz1JPaGAKahqdieHUSJRD HLTBDRH345OMVt0zEAiB6lZ2xk4t9xjNuVrYmkyk4tLoatEDVee1la3gCN4Zdnqxak wgcH0CKQLjE5GL6PZ9h/2aLZuhrlyhJPm9FD5Y/xmyxlgZvx3eduHYPzchemNNv3DN Z0m6U0aWkMPRg== Date: Mon, 8 Nov 2021 20:44:39 +0100 From: Lukasz Majewski To: Adhemerval Zanella Cc: Joseph Myers , Florian Weimer , Carlos O'Donell , Andreas Schwab , libc-alpha Subject: Re: [PATCH] ci: Check for necessary Debian packages when running build-many-glibcs.py Message-ID: <20211108204439.48a8bf87@ktm> In-Reply-To: References: <20211108165255.15600-1-lukma@denx.de> Organization: denx.de X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/xlwMh5wV5vh4l8K6EqEx4k3"; protocol="application/pgp-signature" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2021 19:44:50 -0000 --Sig_/xlwMh5wV5vh4l8K6EqEx4k3 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Adhemerval, > On 08/11/2021 13:59, Joseph Myers wrote: > > On Mon, 8 Nov 2021, Lukasz Majewski wrote: > > =20 > >> The same approach (with using the 'distro' python module) can be > >> applied to Fedora or Suse. =20 > >=20 > > That module isn't part of the Python standard library. I don't > > think we should introduce a dependency on it; rather, any use of it > > should be appropriately conditional, so the code still runs > > (without these checks) if the module is unavailable (importing > > produces an ImportError). > >=20 > > In particular, even if the OS Python installation includes that > > module, the script should work with a separately built copy of > > Python without any such modules from the OS. =20 >=20 > Maybe add a check without tying to any distribution (tool -v and some > version parsing). This would require some extra, work but then we would avoid 'distro' module as the dependency. >=20 > > =20 > >> +def check_os_requirements(): > >> + if distro.id() =3D=3D "debian" and distro.version() =3D=3D "10": > >> + # List 'Debian' specific packages requirements (different > >> than > >> + # vanila distro) to run this test without errors. > >> + debian_requirements =3D ['flex', 'bison', 'dnsutils', > >> 'texinfo'] =20 > >=20 > > Why is dnsutils needed? =20 >=20 > Also, strictly to build and check 'texinfo' is not required either. if makeinfo --split-size=3D5000000 --split-size=3D5000000 -I "/work/wd/glibc/glibc-many-build/src/binutils/binutils/doc" -I "/work/wd/glibc/glibc-many-build/src/binutils/binutils/../libiberty" -I "/work/wd/glibc/glibc-many-build/src/binutils/binutils/../bfd/doc" -I ../../bfd/doc --no-split -I /work/wd/glibc/glibc-many-build/src/binutils/binutils/doc \ -o binutils.info `test -f 'binutils.texi' || echo '/work/wd/glibc/glibc-many-build/src/binutils/binutils/doc/'`binutils.texi; \ then \ rc=3D0; \ else \ rc=3D$?; \ $restore $backupdir/* `echo "./binutils.info" | sed 's|[^/]*$||'`; \ fi; \ rm -rf $backupdir; exit $rc /work/wd/glibc/glibc-many-build/src/binutils/binutils/doc/binutils.texi:871: warning: @ref node name should not contain `.' /work/wd/glibc/glibc-many-build/src/binutils/binutils/doc/binutils.texi:132= 9: warning: @xref node name should not contain `.' make[4]: Leaving directory '/work/wd/glibc/glibc-many-build/build/compilers/powerpc64-linux-gnu/binuti= ls/binutils/doc' Making info in po make[4]: Nothing to be done for 'info'. make[4]: Nothing to be done for 'info-am'. make[2]: *** [Makefile:3701: all-binutils] Error 2 make[2]: *** Waiting for unfinished jobs....=20 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/xlwMh5wV5vh4l8K6EqEx4k3 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmGJficACgkQAR8vZIA0 zr3b8wgA1V9wCGUc6GC19QATsXd11JJGWIq0p+WB9fRvy2qkwqtLR69ylAu9npPz DqnAmjQS5fTpGCk1F6G6qDgwFE9eLu8OAlT6mijjYvG11E8ZXCIx0zngOfd7cKKJ W+YLpqB4/DWg8VpuDeKc5iUgUgD1Nd7XwOEqX60CNWVibd4G+hUlZSUCt0OcZNWw aUCLwekWFL2bk6lR3GAOtPDW3fhmy3z1KDRndfSK+7Q1lroQSnkyMEhe/g8PL4mz 5bkQ880BKjkgjh9ZGFfiCjHko6xiZ2ESiQoUAhuDp1IJPmi0Hpws5anZcSHsONIV xbFPpzgkNT6JE0fpml559KKM/u1pKA== =/l48 -----END PGP SIGNATURE----- --Sig_/xlwMh5wV5vh4l8K6EqEx4k3--