From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) by sourceware.org (Postfix) with ESMTPS id B85823857C52 for ; Wed, 10 Nov 2021 18:58:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B85823857C52 Received: by mail-ua1-x930.google.com with SMTP id ay21so6852819uab.12 for ; Wed, 10 Nov 2021 10:58:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bn8duwf7MhrxzfsyuKb4ArEKmpoBfuSWldolaBEQa2o=; b=L1DeEefqfyRUD7CqnjKk99IVXypJgJxvgjCaJuecrt1WkNH0x/5Vt4qVm2jjlkdnYp kU4YRNCR9jONQ46v3CR7C/V/7t+vDj+yu/v1lePF4uGrmGpqqAexZ//UezMI7acjKlWr h4SJUZsmYVwd8Uw1iS+6N2h5aYhtqdtl1OBwVLqDkIehL/wduAf2217pT4ztmRWRmabi py9wTBEZMenZ6gdFXXysCEzeAZNfObTSQtEgeq13EebYHDU5DixvzH9YqOQP09ijPj0P K6jZjvC5R5MNd92h3f5AoVqb+pbETqvS3x312TaPPCLMsTGPonUUGGvBNpdOkvos0gEg Q0lA== X-Gm-Message-State: AOAM530IfnQ6J6FdfUVl58OpzLatPjmKpd+VG3KxHesTl+Ts+jDXOVg2 obthgOA+wfHmr3zTooQsJ1PG+cHkG3/Z2w== X-Google-Smtp-Source: ABdhPJylCnrDGDh1Dsm4rdeokdVG2W3Za5Md8wiApuaFr3bXKN9bwOsp8lbWRNS6nAv2eGlHc2kmOg== X-Received: by 2002:a67:c993:: with SMTP id y19mr1413788vsk.36.1636570718765; Wed, 10 Nov 2021 10:58:38 -0800 (PST) Received: from birita.. ([2804:431:c7cb:55a:73fa:8bad:ab14:14a3]) by smtp.gmail.com with ESMTPSA id r20sm518149vkq.15.2021.11.10.10.58.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Nov 2021 10:58:38 -0800 (PST) From: Adhemerval Zanella To: libc-alpha@sourceware.org Cc: leonardo.macchia@gmail.com Subject: [PATCH 2/3] inet: Remove strdupa from nrl_domainname() Date: Wed, 10 Nov 2021 15:58:31 -0300 Message-Id: <20211110185832.1931688-3-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211110185832.1931688-1-adhemerval.zanella@linaro.org> References: <20211110185832.1931688-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2021 18:58:42 -0000 We can use the already in place scratch_buffer. Checked on x86_64-linux-gnu. --- inet/getnameinfo.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/inet/getnameinfo.c b/inet/getnameinfo.c index 58ebbb1154..69a94604bd 100644 --- a/inet/getnameinfo.c +++ b/inet/getnameinfo.c @@ -127,10 +127,10 @@ nrl_domainname (void) else { /* We need to preserve the hostname. */ - const char *hstname = strdupa (tmpbuf.data); - while (__gethostbyname_r (hstname, &th, - tmpbuf.data, - tmpbuf.length, + size_t hstnamelen = strlen (tmpbuf.data) + 1; + while (__gethostbyname_r (tmpbuf.data, &th, + tmpbuf.data + hstnamelen, + tmpbuf.length - hstnamelen, &h, &herror)) { if (herror == NETDB_INTERNAL && errno == ERANGE) -- 2.32.0