From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4D40F385843A for ; Thu, 18 Nov 2021 14:33:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4D40F385843A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-275-jFH7KK3IPkeNnkkFYZYJ4Q-1; Thu, 18 Nov 2021 09:33:27 -0500 X-MC-Unique: jFH7KK3IPkeNnkkFYZYJ4Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2F33D824F8D; Thu, 18 Nov 2021 14:33:26 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AE30067871; Thu, 18 Nov 2021 14:33:25 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 1AIEXMrY2647615 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 18 Nov 2021 15:33:23 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 1AIEXMTV2647614; Thu, 18 Nov 2021 15:33:22 +0100 Date: Thu, 18 Nov 2021 15:33:22 +0100 From: Jakub Jelinek To: Florian Weimer Cc: gcc-patches@gcc.gnu.org, libc-alpha@sourceware.org, Jason Merrill Subject: Re: [PATCH 2/4] libgcc: Remove dbase member from struct unw_eh_callback_data if NULL Message-ID: <20211118143322.GD2646553@tucnak> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Nov 2021 14:33:32 -0000 On Wed, Nov 03, 2021 at 05:28:41PM +0100, Florian Weimer wrote: > Only i386 and nios2 need this member at present. Only i386, nios2, frv and bfin to be precise. > > libgcc/ChangeLog > > * unwind-dw2-fde-dip.c (NEED_DBASE_MEMBER): Define. > (struct unw_eh_callback_data): Make dbase member conditional. > (unw_eh_callback_data_dbase): New function. > (base_from_cb_data): Simplify for the non-dbase case. > (_Unwind_IteratePhdrCallback): Adjust. > (_Unwind_Find_FDE): Likewise. LGTM. Jakub