From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by sourceware.org (Postfix) with ESMTPS id 1BE0C385842B for ; Wed, 24 Nov 2021 12:17:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1BE0C385842B IronPort-HdrOrdr: =?us-ascii?q?A9a23=3ANX/NL659iDlbngPqBwPXwPfXdLJyesId70hD?= =?us-ascii?q?6qm+c20tTiX4rbHXoB1/73XJYVkqKRQdcLy7Scu9qDbnhP1ICOoqXItKPjOW3F?= =?us-ascii?q?dARbsKheDfKn/bexEWndQtspuIHZIObuEYzmIXsS852mSF+hobr+VvOZrHudvj?= X-IronPort-AV: E=Sophos;i="5.84,326,1620684000"; d="scan'208";a="400160744" Received: from nat-inria-interne-52-gw-01-bso.bordeaux.inria.fr (HELO begin) ([194.199.1.52]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Nov 2021 13:17:41 +0100 Received: from samy by begin with local (Exim 4.95) (envelope-from ) id 1mprDZ-005WQY-32; Wed, 24 Nov 2021 13:17:41 +0100 Date: Wed, 24 Nov 2021 13:17:41 +0100 From: Samuel Thibault To: Florian Weimer Cc: Adhemerval Zanella , Adhemerval Zanella via Libc-alpha , Sergey Bugaev Subject: Re: [PATCH v2] io: Refactor close_range and closefrom Message-ID: <20211124121741.qcrchlkne6c3ystm@begin> References: <20211108172817.2235239-1-adhemerval.zanella@linaro.org> <87r1b5op82.fsf@oldenburg.str.redhat.com> <87mtltoj5k.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mtltoj5k.fsf@oldenburg.str.redhat.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2021 12:17:44 -0000 Florian Weimer, le mer. 24 nov. 2021 13:03:19 +0100, a ecrit: > * Adhemerval Zanella: > > >> diff --git a/sysdeps/mach/hurd/kernel-features.h b/sysdeps/mach/hurd/kernel-features.h > >> index 7d4eaee0a6..5fd37a6d7b 100644 > >> --- a/sysdeps/mach/hurd/kernel-features.h > >> +++ b/sysdeps/mach/hurd/kernel-features.h > >> @@ -19,3 +19,5 @@ > >> /* This file can define __ASSUME_* macros checked by certain source files. > >> Almost none of these are used outside of sysdeps/unix/sysv/linux code. > >> But those referring to POSIX-level features like O_* flags can be. */ > >> + > >> +#define __ASSUME_CLOSE_RANGE 1 > > > > It does add it here (I also checked with a build for i688-gnu). > > Hmm, this doesn't match existing practice. We haven't unified > implementations in light of such divergence, I think. If the Hurd > developers don't object, it should be fine, though.. I'm fine with it yes. This is not a "kernel-feature" since it's actually implemented inside glibc itself, but from the point of view of the rest of the world that's how people understand it, so better adhere to it :) Samuel