From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
Subject: Re: glibc -Werror=address build failure for Hurd with mainline GCC
Date: Sun, 28 Nov 2021 21:28:12 +0100 [thread overview]
Message-ID: <20211128202812.tt6absnn3ldojo34@begin> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2111221814340.1574757@digraph.polyomino.org.uk>
Hello,
Joseph Myers, le lun. 22 nov. 2021 18:19:28 +0000, a ecrit:
> The glibc build with GCC mainline has recently started failing for Hurd:
>
> report-wait.c: In function '_S_msg_report_wait':
> report-wait.c:129:12: error: the address of '_hurd_itimer_thread' will always evaluate as 'true' [-Werror=address]
> 129 | else if (&_hurd_itimer_thread && thread == _hurd_itimer_thread)
> | ^
>
> This seems like a valid warning (the compiler can see the address can't be
> NULL), given the #if 0 above (but maybe the right fix depends on whether
> you want to keep the #if 0, and so keep it clear what would need to change
> if the #if 0 changed, or remove it):
It seems the #if 0 is outdated, I have removed it.
Thanks!
Samuel
prev parent reply other threads:[~2021-11-28 20:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 18:19 Joseph Myers
2021-11-28 20:28 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211128202812.tt6absnn3ldojo34@begin \
--to=samuel.thibault@ens-lyon.org \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).