From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org,
Paul Zimmermann <Paul.Zimmermann@inria.fr>,
Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Subject: [PATCH v4 08/12] math: Add math-use-builtinds-fmax.h
Date: Thu, 2 Dec 2021 21:00:59 -0300 [thread overview]
Message-ID: <20211203000103.737833-9-adhemerval.zanella@linaro.org> (raw)
In-Reply-To: <20211203000103.737833-1-adhemerval.zanella@linaro.org>
It allows the architecture to use the builtin instead of generic
implementation.
---
math/s_fmax_template.c | 27 ++++++++++++++++++++++++
sysdeps/generic/math-use-builtins-fmax.h | 4 ++++
sysdeps/generic/math-use-builtins.h | 1 +
3 files changed, 32 insertions(+)
create mode 100644 sysdeps/generic/math-use-builtins-fmax.h
diff --git a/math/s_fmax_template.c b/math/s_fmax_template.c
index d817406f04..4417fdb283 100644
--- a/math/s_fmax_template.c
+++ b/math/s_fmax_template.c
@@ -17,10 +17,37 @@
<https://www.gnu.org/licenses/>. */
#include <math.h>
+#include <math-use-builtins.h>
+
+#if __HAVE_FLOAT128
+# define USE_BUILTIN_F128 , _Float128 : USE_FMAXF128_BUILTIN
+# define BUILTIN_F128 , _Float128 :__builtin_fmaxf128
+#else
+# define USE_BUILTIN_F128
+# define BUILTIN_F128
+#endif
+
+#define USE_BUILTIN(X, Y) \
+ _Generic((X), \
+ float : USE_FMAXF_BUILTIN, \
+ double : USE_FMAX_BUILTIN, \
+ long double : USE_FMAXL_BUILTIN \
+ USE_BUILTIN_F128)
+
+#define BUILTIN(X, Y) \
+ _Generic((X), \
+ float : __builtin_fmaxf, \
+ double : __builtin_fmax, \
+ long double : __builtin_fmaxl \
+ BUILTIN_F128) \
+ (X, Y)
FLOAT
M_DECL_FUNC (__fmax) (FLOAT x, FLOAT y)
{
+ if (USE_BUILTIN (x, y))
+ return BUILTIN (x, y);
+
if (isgreaterequal (x, y))
return x;
else if (isless (x, y))
diff --git a/sysdeps/generic/math-use-builtins-fmax.h b/sysdeps/generic/math-use-builtins-fmax.h
new file mode 100644
index 0000000000..8fc4efca6a
--- /dev/null
+++ b/sysdeps/generic/math-use-builtins-fmax.h
@@ -0,0 +1,4 @@
+#define USE_FMAX_BUILTIN 0
+#define USE_FMAXF_BUILTIN 0
+#define USE_FMAXL_BUILTIN 0
+#define USE_FMAXF128_BUILTIN 0
diff --git a/sysdeps/generic/math-use-builtins.h b/sysdeps/generic/math-use-builtins.h
index 19d2d1cf3c..e07bba242f 100644
--- a/sysdeps/generic/math-use-builtins.h
+++ b/sysdeps/generic/math-use-builtins.h
@@ -34,5 +34,6 @@
#include <math-use-builtins-copysign.h>
#include <math-use-builtins-sqrt.h>
#include <math-use-builtins-fma.h>
+#include <math-use-builtins-fmax.h>
#endif /* MATH_USE_BUILTINS_H */
--
2.32.0
next prev parent reply other threads:[~2021-12-03 0:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 0:00 [PATCH v4 00/12] Improve hypot Adhemerval Zanella
2021-12-03 0:00 ` [PATCH v4 01/12] math: Simplify hypotf implementation Adhemerval Zanella
2021-12-03 13:23 ` Wilco Dijkstra
2021-12-03 19:44 ` Adhemerval Zanella
2021-12-03 0:00 ` [PATCH v4 02/12] math: Use an improved algorithm for hypot (dbl-64) Adhemerval Zanella
2021-12-03 13:41 ` Wilco Dijkstra
2021-12-03 19:44 ` Adhemerval Zanella
2021-12-03 0:00 ` [PATCH v4 03/12] math: Improve hypot performance with FMA Adhemerval Zanella
2021-12-03 13:44 ` Wilco Dijkstra
2021-12-03 0:00 ` [PATCH v4 04/12] math: Use an improved algorithm for hypotl (ldbl-96) Adhemerval Zanella
2021-12-06 12:00 ` Wilco Dijkstra
2021-12-06 12:21 ` Adhemerval Zanella
2021-12-03 0:00 ` [PATCH v4 05/12] math: Use an improved algorithm for hypotl (ldbl-128) Adhemerval Zanella
2021-12-06 11:58 ` Wilco Dijkstra
2021-12-06 12:22 ` Adhemerval Zanella
2021-12-03 0:00 ` [PATCH v4 06/12] math: Remove powerpc e_hypot Adhemerval Zanella
2021-12-06 17:12 ` Adhemerval Zanella
2021-12-06 21:29 ` Paul A. Clarke
2021-12-07 13:19 ` Adhemerval Zanella
2021-12-03 0:00 ` [PATCH v4 07/12] i386: Move hypot implementation to C Adhemerval Zanella
2021-12-03 14:51 ` Wilco Dijkstra
2021-12-06 12:26 ` Adhemerval Zanella
2021-12-03 0:00 ` Adhemerval Zanella [this message]
2021-12-06 11:52 ` [PATCH v4 08/12] math: Add math-use-builtinds-fmax.h Wilco Dijkstra
2021-12-06 21:11 ` Joseph Myers
2021-12-07 13:21 ` Adhemerval Zanella
2021-12-03 0:01 ` [PATCH v4 09/12] math: Add math-use-builtinds-fmin.h Adhemerval Zanella
2021-12-06 11:50 ` Wilco Dijkstra
2021-12-03 0:01 ` [PATCH v4 10/12] aarch64: Add math-use-builtins-f{max,min}.h Adhemerval Zanella
2021-12-06 11:46 ` Wilco Dijkstra
2021-12-06 12:35 ` Adhemerval Zanella
2021-12-03 0:01 ` [PATCH v4 11/12] math: Use fmin/fmax on hypot Adhemerval Zanella
2021-12-06 11:44 ` Wilco Dijkstra
2021-12-03 0:01 ` [PATCH v4 12/12] math: Remove the error handling wrapper from hypot and hypotf Adhemerval Zanella
2021-12-03 8:51 ` [PATCH v4 00/12] Improve hypot Paul Zimmermann
2021-12-06 12:36 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211203000103.737833-9-adhemerval.zanella@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=Paul.Zimmermann@inria.fr \
--cc=Wilco.Dijkstra@arm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).