From: "Paul A. Clarke" <pc@us.ibm.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org,
Paul Zimmermann <Paul.Zimmermann@inria.fr>,
Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
tuliom@linux.ibm.com
Subject: Re: [PATCH v5 07/12] math: Remove powerpc e_hypot
Date: Tue, 7 Dec 2021 13:42:00 -0600 [thread overview]
Message-ID: <20211207194200.GA8404@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> (raw)
In-Reply-To: <20211207190353.3282666-8-adhemerval.zanella@linaro.org>
On Tue, Dec 07, 2021 at 04:03:48PM -0300, Adhemerval Zanella via Libc-alpha wrote:
> The generic implementation is shows only slight worse performance:
>
> POWER10 reciprocal-throughput latency
> master 8.28478 13.7253
> new hypot 7.21945 13.1933
>
> POWER9 reciprocal-throughput latency
> master 13.4024 14.0967
> new hypot 14.8479 15.8061
>
> POWER8 reciprocal-throughput latency
> master 15.5767 16.8885
> new hypot 16.5371 18.4057
>
> One way to improve might to make gcc generate xsmaxdp/xsmindp for
> fmax/fmin (it onl does for -ffast-math, clang does for default
> options).
I opened https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103605.
> Checked on powerpc64-linux-gnu (power8) and powerpc64le-linux-gnu
> (power9).
Presuming the numbers above number hold for this "v5", I have no objections
to merging these changes.
For v4:
Tested-by: Paul A. Clarke <pc@us.ibm.com>
PC
next prev parent reply other threads:[~2021-12-07 19:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 19:03 [PATCH v5 00/12] Improve hypot Adhemerval Zanella
2021-12-07 19:03 ` [PATCH v5 01/12] math: Simplify hypotf implementation Adhemerval Zanella
2021-12-07 19:03 ` [PATCH v5 02/12] math: Use an improved algorithm for hypot (dbl-64) Adhemerval Zanella
2021-12-07 19:03 ` [PATCH v5 03/12] math: Improve hypot performance with FMA Adhemerval Zanella
2021-12-07 19:03 ` [PATCH v5 04/12] math: Use an improved algorithm for hypotl (ldbl-96) Adhemerval Zanella
2021-12-07 19:03 ` [PATCH v5 05/12] math: Use an improved algorithm for hypotl (ldbl-128) Adhemerval Zanella
2021-12-07 19:03 ` [PATCH v5 06/12] i386: Move hypot implementation to C Adhemerval Zanella
2021-12-07 19:03 ` [PATCH v5 07/12] math: Remove powerpc e_hypot Adhemerval Zanella
2021-12-07 19:42 ` Paul A. Clarke [this message]
2021-12-07 19:03 ` [PATCH v5 08/12] math: Add math-use-builtinds-fmax.h Adhemerval Zanella
2021-12-07 19:03 ` [PATCH v5 09/12] math: Add math-use-builtinds-fmin.h Adhemerval Zanella
2021-12-07 19:03 ` [PATCH v5 10/12] aarch64: Add math-use-builtins-f{max,min}.h Adhemerval Zanella
2021-12-07 19:03 ` [PATCH v5 11/12] math: Use fmin/fmax on hypot Adhemerval Zanella
2021-12-07 19:03 ` [PATCH v5 12/12] math: Remove the error handling wrapper from hypot and hypotf Adhemerval Zanella
2021-12-08 5:51 ` [PATCH v5 00/12] Improve hypot Paul Zimmermann
2021-12-10 19:31 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211207194200.GA8404@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com \
--to=pc@us.ibm.com \
--cc=Paul.Zimmermann@inria.fr \
--cc=Wilco.Dijkstra@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=tuliom@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).