From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60056.outbound.protection.outlook.com [40.107.6.56]) by sourceware.org (Postfix) with ESMTPS id A396A3858D3C for ; Wed, 8 Dec 2021 11:10:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A396A3858D3C Received: from AM6PR10CA0107.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::48) by AS8PR08MB7010.eurprd08.prod.outlook.com (2603:10a6:20b:34d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Wed, 8 Dec 2021 11:10:12 +0000 Received: from AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8c:cafe::ca) by AM6PR10CA0107.outlook.office365.com (2603:10a6:209:8c::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Wed, 8 Dec 2021 11:10:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT040.mail.protection.outlook.com (10.152.17.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.13 via Frontend Transport; Wed, 8 Dec 2021 11:10:12 +0000 Received: ("Tessian outbound 9a8c656e7c94:v110"); Wed, 08 Dec 2021 11:10:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ebd449be5566d724 X-CR-MTA-TID: 64aa7808 Received: from 702a38e9b253.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A9A22C7E-A1FB-407E-B15A-3AA4AD9F4231.1; Wed, 08 Dec 2021 11:09:56 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 702a38e9b253.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Dec 2021 11:09:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aMJToMnqBi3rlfS9Td2QUc65nv8QqYQ5dE7SyISizVeUZEgh4d4Jx+FRKYcHx9e4eIUM15KjaOW44y68fqgROf3DJwjzgxk0CMfMfWjD0N2M0k0CSlnqK+SDnko5kJO8FBWmN7izjZlA8Mwp/DaObUmU/Uvd1qgzL0+1X9z1Ih+I8oDbWf6BmkRtbqLMvTePLIajiGleWe1P4c+L0FW/x+e45BAFA0D8FdZjDg1akVSQfbUwR4Sj6y1BXRjppZKgZDJiv1DVZpR8EmWeg0EV1EyiK2z4zkdtzEVMNwN0OhsLq0LGQgy5IFpV1Cwwc6LBB2TXKr1OdrbFnSVTHxUqlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RgntDMWkgn8gsHmSM0JakNd47Amz6i0aL3p2eXyIWw4=; b=FyaP7LW7z/J2owcwqMTnl2i5UHq94XRXXWUWr1/syPhWwj8BC0iAkhx4EsZ6i6ju3DYklrOIszxHRXjGkHrdk6533GXUr7JAuytF8M4gFunMDExTstB/VNHQWn6Rw8fRtGNxrXVdOGKcLxK10vvkiI7uV58rtRO44V8I5HS0yw5smbdUcQduD1HoomVmC7T9/offoNFjKFO89WiG2admcBMKhkyMe29vPc7msxAnEoP6jeoqoAD4hvb7DTH+AyOec0vM3eIuMm0hwLmqfo2ew4fKLVyMKzz0BMaweBs31LvD91vpNsy26Uy65waAsHhCKxlHwWSUSBUJuRy9RlWAvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DB9PR08MB7495.eurprd08.prod.outlook.com (2603:10a6:10:36c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Wed, 8 Dec 2021 11:09:54 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::25f9:a7e6:422a:da43]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::25f9:a7e6:422a:da43%6]) with mapi id 15.20.4755.022; Wed, 8 Dec 2021 11:09:54 +0000 Date: Wed, 8 Dec 2021 11:09:46 +0000 From: Szabolcs Nagy To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 2/8] nptl: Introduce for THREAD_* accessors Message-ID: <20211208110946.GF3294453@arm.com> References: <2fab93e19a8bbee4d8644a44300b76bdc057ac99.1638880889.git.fweimer@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2fab93e19a8bbee4d8644a44300b76bdc057ac99.1638880889.git.fweimer@redhat.com> X-ClientProxiedBy: SA9PR13CA0075.namprd13.prod.outlook.com (2603:10b6:806:23::20) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 Received: from arm.com (217.140.106.51) by SA9PR13CA0075.namprd13.prod.outlook.com (2603:10b6:806:23::20) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Wed, 8 Dec 2021 11:09:52 +0000 X-MS-Office365-Filtering-Correlation-Id: c283f05f-810d-4cfd-b261-08d9ba3b4ded X-MS-TrafficTypeDiagnostic: DB9PR08MB7495:|AM5EUR03FT040:EE_|AS8PR08MB7010:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2958;OLM:2958; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nZzQRBTsA+SBmBPSpLAYVDY4vOX31tU/kq5R+2t+xZ0wmP+kBF2HWV0d1JKeCWotPemu/Xw7GmTL1xanDuUChr8jy6e/Jv7YICl6EYNrH50gD+rsexaKVejprTwJuDPCiYo+uT1cDOHUNmt6PwZXU5kGFAO7k+pemUX7WQgKEju2eRX4K+lx1zwSw4XQNBheilxF32GVA+RNHJIef7g+Qo8grCUU2D+CeCXAuGgvvToZ04DSVzHlXn2TJFwHO9PD9XEjBcf1bUK37HSLhYDliK47sN3vWmWaPvetm2GNZnHiAHlP1ln9MZemF9rdkBrq6daMYjrZgf9mbY+FhLI3luDOO3MyKDG8swBSiJ8R29Ih+DKQ5eLDqMag65yvZ579nJOjS9ExCuPkfCfAep5uOauDkzzI/YJINGvSkCsM3E5ixiYySixWPbua0hotrEnlZNSFTGU0nQh1V1zGIRd96ewvaQN4NhgRVl/MxFM9vCeVciEyIveTIfDSOdBOPqB3GTFLKV1wR+kTgquTrx/mp95JdZV51PXB4KAfhmsWAjMZVXec25wWyq3W7+THOuNpVWMYsvwRfG+RyhuLxCwnFNWbrzczElWy8bU2cQQb9BYBcbW18OrwstwcBsvEepvz8H/ZwCx9bCRAMaEVlM/rL5LQ/CwIlTa7Bq9W9X98Rphc6rhnNte1NizaddCaM7EVBp0QcAjlho3knFu8wi+RTQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR08MB7179.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2616005)(316002)(558084003)(33656002)(66946007)(6666004)(26005)(8676002)(36756003)(2906002)(6916009)(38350700002)(52116002)(5660300002)(38100700002)(508600001)(44832011)(7696005)(8886007)(1076003)(186003)(55016003)(86362001)(8936002)(956004)(66556008)(66476007)(4326008); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7495 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ba9305ec-2551-4e84-4611-08d9ba3b42fd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o8qlKtOeK9pt4MsEY/VSm/hkSLT5iRmIlIhiV8VuHoge16mwIoqx8F9QoLiyeqOqg4wTLN0Ja+z7NcUJUFJUZa/E+Kg0Ude7rghFPUQPj19AeOiIXuPv0eqYe62IqP10I+RnE8ItEF3FpoWvM20cDwh6pSs4ZEkOMX1n2vNyn5/3DtSl2G1uA6c9uuquWsjFuOU9R+NKgsZfFP4rUb085HKJxlonezsDixiNeNaG83wZIE8Fno4QO/CnowuI+U8UNEsQRloYfCAPwVs3RAy0QZztKURgAxXqg5Gx1TCgHYL5o+3IM9bEsUDPmo8Zkw3QdIlZ+RGo9eg6GDmA84cSFEyM7TEbna5g9zJ6UiesIT2jLKpdwDExq1vVSHQS/fueuB4ntbG6zjwyA2MirKKrovxyw6P7a+fXunquz8PX2K+YLcT1GwFk8xAft4mTrHgbvnitBoPQaFVaeI/+AbhJtnT7e5dkTuaj/DyOIfn3wbLEBXisjdi2RdXo7GYFEsGDADrfuRiKCl8jfKXjM6j7t+hidLR34HmvNP1jQz/iQlhRxnVlHVy+wKatOFsFmObohTmXRInwHCwb6DJcKSZQ4aCmBU6FKvZOK+a1MD0brf+1q3qtdd6l23R/EHRpg+yK1d2v7yj0yTe5JBJrr8L3Q1zi+Cv/LL7c2WkOm+L9Ep8ZF4J0D8fKSdvfA4PDUhbljj7PuydMEdFVw1dKJF9TCZ2fLqqTWWr61J3AkGl0Y7Gj/sYHySH3UXwDX/tmQj7biGJ6Jn4vTDKlRQc8vRZxtA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(40470700001)(558084003)(336012)(316002)(36860700001)(33656002)(81166007)(5660300002)(356005)(956004)(82310400004)(2616005)(6666004)(2906002)(6862004)(4326008)(86362001)(8886007)(186003)(47076005)(508600001)(55016003)(7696005)(26005)(8676002)(44832011)(8936002)(40460700001)(36756003)(70206006)(70586007)(1076003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 11:10:12.2292 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c283f05f-810d-4cfd-b261-08d9ba3b4ded X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7010 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2021 11:10:17 -0000 The 12/07/2021 14:00, Florian Weimer via Libc-alpha wrote: > These are common between most architectures. Only the x86 targets > are outliers. This code refactoring looks OK. Reviewed-by: Szabolcs Nagy