From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2075.outbound.protection.outlook.com [40.107.20.75]) by sourceware.org (Postfix) with ESMTPS id 37E5B3858418 for ; Wed, 8 Dec 2021 16:52:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 37E5B3858418 Received: from AM6PR10CA0108.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::49) by PAXPR08MB7156.eurprd08.prod.outlook.com (2603:10a6:102:209::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Wed, 8 Dec 2021 16:52:02 +0000 Received: from VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8c:cafe::e4) by AM6PR10CA0108.outlook.office365.com (2603:10a6:209:8c::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend Transport; Wed, 8 Dec 2021 16:52:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT005.mail.protection.outlook.com (10.152.18.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.13 via Frontend Transport; Wed, 8 Dec 2021 16:52:01 +0000 Received: ("Tessian outbound a33f292be81b:v110"); Wed, 08 Dec 2021 16:52:01 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: df01d9ee7f829aa1 X-CR-MTA-TID: 64aa7808 Received: from 158369f0941f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 652FA88A-9273-4A05-82DC-1488D290EE39.1; Wed, 08 Dec 2021 16:51:39 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 158369f0941f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Dec 2021 16:51:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f8ttrwOMvIQUcL07AW0YtNELFrv3dpw2bhnSYy/HpngJbBK8XUW5Yu1+9loo/F8Lau5RGXHztOCI7CPFPbQOstmMFfRH+G8jIbWa+WMl/h0onHcZv48TkNzsCzS9cdpn+o+Xb/eLnMxW6hC/0uXsaTvoV/kCXFyor0rnVIf3wnqQbL2FAW5uKZkmBsAQ/uHCZ6oIxkc+JX/iwEkr42t9Hj5x38DpPMpwMBtBPTjEJC+l5WNqlioNAOsQzQ/kPEqlyJEkW/I0kRcaD2wxoyiJE94YIfy/E/P0Kttb6aeTuWh14x2Uc35j8oVWZciI+ofkjgO/q8wSSMKmMR3LO4mGvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uQLjMZNZaQ/diO8ugBfw4zWKgsPDRLkcdv/O67JqZD4=; b=lunC8WmuJAHOFVuKyCega2ixTWHq2gvIjhe/Iy6MqAD/qAqMGJSenylqywtcR8WoirjyBVPHW+2pVwhybF7AmEezDTAYE76wIguHkE6S4NcW3L0m/SKE1VeKaeo66mFdk3XCdltobsIYymXGavNVdm2q+Or1sV2k2yyH4ZXu+DtCUYkjRXW20/sHrCKY+CcMCqsqQCeJTHMMVwB2cqHDbbnRLbqylXHo0MDc1gxdBQm5cUQ8rf0VzLsOg8IY9IvUNpsgwAkHqwIoR+tIjNmYDwwuC6zRLRtU8UboJ2BGVMFT5C2NdUc+Swz6GwrfpBBq+rp7UVnjOtwRFKy/XcbF5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Wed, 8 Dec 2021 16:51:38 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::25f9:a7e6:422a:da43]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::25f9:a7e6:422a:da43%6]) with mapi id 15.20.4755.022; Wed, 8 Dec 2021 16:51:38 +0000 Date: Wed, 8 Dec 2021 16:51:36 +0000 From: Szabolcs Nagy To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 4/8] nptl: Add rseq registration Message-ID: <20211208165136.GH3294453@arm.com> References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P265CA0494.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::19) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 Received: from arm.com (217.140.106.51) by LO2P265CA0494.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Wed, 8 Dec 2021 16:51:38 +0000 X-MS-Office365-Filtering-Correlation-Id: 2c7a2904-deaa-440f-33cc-08d9ba6b0e9f X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|VE1EUR03FT005:EE_|PAXPR08MB7156:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:7691;OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fVUU/2OgPu3qyaBeoloGEJ9uwz2XQ6aaTBgxbnEaq6/T3aEmWp7GiUcK3i144IZBDgyHImOAA6KkDu5S4aRWlQudlELzxJGwmcX/YTO0WT28gA+jJ0Yml9l6alSPMqqrZiS6wxDhWgFjmzi51KsG93X7tZST/Yfnvrp5bfj1a54bfRySoc5z57MGZaLXDkPfbZOGZ749rno4Y5pmYmTxYuvNnb+hCOn+638lDiKwEftHoo9ljGGqOL/I9Qc8FFbb2eJAs1kL9lj7GaDnMgGTB+qShs1ZGcuAk8Abt9GiQGu5PObK/uurC7/u/Jc6QLwageGkTzijkbguwKkI9U4UxQkZxZWNZZNbVpMDGMYTbfbFl8/eM8ULY2it1ZTqKUUN7tV8B9jLIFLnzxXTcxp50xm1KU0ht4RAyFH0wQz2enPwYJphjaBvuRKMPE7+YqqcH2d74YDhWetrKjXyM2fHbANyvfkN8IH5xpftOSYlMD8plXgsARnR18/rA9dB4lcZtUMHV/lU4waUsKdwi2/eUS2UtNTy10zQb3Ry+N4z24sA+bQmO4KAo8jn45Z4oW3bMfN6/JSDGYeyNFoJaygfwqWPE+bn6EhYRtCK9E9F5/aKseN3dMUmXcm3HpTB6AMb2c75NtF2t5oDGUO3yFpxV3pU4u+LeaGQVegkebqEqRdjM3bEq67DEnv2Qq4oBOdtekMQ9T+wbrb3b+ASvPEMnw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR08MB7179.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66556008)(83380400001)(66946007)(4326008)(508600001)(36756003)(44832011)(66476007)(86362001)(1076003)(38350700002)(6916009)(7696005)(38100700002)(8886007)(186003)(33656002)(52116002)(5660300002)(26005)(2906002)(2616005)(8936002)(8676002)(55016003)(316002)(956004); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7179 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2d9cd098-5b6d-4fda-e72a-08d9ba6b0066 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DBKqjaFhrY7Bx5BHGlhXfsL92il82zbdRWa8CH/RaVU+0tKUXsKIiQfiYrVdrg7MvSN091KOqTa1502/D7fdTbTzMVJBBwq1ruKbVQfMG62jlw69LtRqIxtgb8lWSlVnAyR+LhA0UqE964j59nure8eYVrECpWdDrjgpla7dz3v6ikZpOwTxwHqKgULtaYw0G8SQQy7y1k59KW0vyarDSl2fdka7yiNWpvnOPjmyx5TTXmvVi1MDN4Eg9pGB0BoHY1ux9gmL0RPZ9mJmGvSf4DDW+NY0Z1P+xtyWWlw1a0Njyrj8YR7EgwxJcJc4ds1xj4V4daLEsa4Soy6L4//rqb3LhjN9sJxym9sn2D7vnNRKZVqo5uS2r5Mbw8Q35nVk4gzR7rqn+bATOCaN0xTdmjqNqUZu3/DLgn5AmPWx+8iIdgp1O/N7xW9POMLQwlwWdJrYLp9WqUCJPrLQiTFWTLPPDtxSHX9ElOhIiSecnh+K/8QGOq3+OSF3E59f8dUqNy+YhUtSdHpYq4N+LpZ4fNJjeyCAbNIDCaQjGC32RJjPr1lyroV3Jw3amXV/YYqAr5VfivEBOuV94a3TDUIO36dmSxSSgzTjjqxLBEzEPNAOe46rBQDLB2OUQ+N8uwdmW1HiB4tDB2uIvqFvf85EbJNEDC5UuWq757TLiPXYEURjDv0QEM0c+LEP1eRlqJdS1YA04bd/ypzGHSKIfylN+Mrx4gyZcOUSxzNIyKvALMu9QO0A+tgTPCe/hajkRX28NvT7LmKc5tRjpHFRMfMFMw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(40470700001)(36860700001)(83380400001)(5660300002)(82310400004)(508600001)(40460700001)(336012)(55016003)(356005)(8886007)(4326008)(2906002)(316002)(8676002)(44832011)(6862004)(81166007)(70206006)(70586007)(956004)(33656002)(86362001)(7696005)(8936002)(36756003)(186003)(47076005)(1076003)(2616005)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 16:52:01.8123 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c7a2904-deaa-440f-33cc-08d9ba6b0e9f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7156 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2021 16:52:06 -0000 The 12/07/2021 14:01, Florian Weimer via Libc-alpha wrote: > The rseq area is placed directly into struct pthread. rseq > registration failure is not treated as an error, so it is possible > that threads run with inconsistent registration status. > > is not yet installed as a public header. > > Co-Authored-By: Mathieu Desnoyers looks good. most of the changes were reviewed when rseq was first committed. my problem with __has_include ("linux/rseq.h") etc in sys/rseq.h is that linux might change that later to conflict with libc headers in some way. but i don't have a better way to avoid issues when both libc and linux headers are included into the same TU. despite the comments in linux/rseq.h (and sys/rseq.h) the RSEQ_CPU_ID_UNINITIALIZED state is now not observable. i guess it is just an unused piece of linux uapi so ok. inconsistent rseq status in threads is ok. not unregistering on thread exit is ok. updated tests are ok. Reviewed-by: Szabolcs Nagy