From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60075.outbound.protection.outlook.com [40.107.6.75]) by sourceware.org (Postfix) with ESMTPS id 4EA5F3858D3C for ; Wed, 8 Dec 2021 17:37:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4EA5F3858D3C Received: from DU2PR04CA0243.eurprd04.prod.outlook.com (2603:10a6:10:28e::8) by AM6PR08MB3079.eurprd08.prod.outlook.com (2603:10a6:209:45::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Wed, 8 Dec 2021 17:37:02 +0000 Received: from DB5EUR03FT003.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28e:cafe::44) by DU2PR04CA0243.outlook.office365.com (2603:10a6:10:28e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Wed, 8 Dec 2021 17:37:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT003.mail.protection.outlook.com (10.152.20.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.13 via Frontend Transport; Wed, 8 Dec 2021 17:37:02 +0000 Received: ("Tessian outbound 1cd1a01725a6:v110"); Wed, 08 Dec 2021 17:37:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 41d04b93faf1eb01 X-CR-MTA-TID: 64aa7808 Received: from e3b90eb5ae80.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4CF7A0EE-6D38-41C5-985A-994DD059B299.1; Wed, 08 Dec 2021 17:36:43 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e3b90eb5ae80.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Dec 2021 17:36:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BQ4Bk8mp6ttJ+hIRjgfv7ilC4IA1tP6lXUvbNszzS4rxu62wNJY8dAHjUymWKMYJiJpDeiV6xwwBjRQknhV7PxYs40qHGCd73lbHBsruH7yUMC9u+PE+ggWBQNPNagGXsv5YVRjOusydDkfBLpUvHi9wQxE0baM5c1qj4rXAAZJNDPGoqEbqvae1LW3xMaWD2KWRjXb/oPWYFXweb/I5csM0PUTgM1KhKm9OKC/m5yG81BA/YCraBMCyhLjfZ7w50umTiTs0O12F1K6aefIMyaI1/fs5+WbKz57bY2FAOMi7mwIGWVIpIHzuktgofQuE/qHdFuHP7MdpFwhT/pAhqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8qEmnh5HlAI0mftHZplgI/G1iKOAUEuTumhzzQG7wSA=; b=W/jbZzthRnbKLoZ95l+qMguKJ0CrEHd+Ojhxv9FL4PMjhapZDui3XX4mzs6qyO0drJrLqS38zU8FvxImrfz3wYog6KtvXLkhULsauozxK27fanxmOWmAmhQ0YbnOjheCVj2ykrQK6/cY0Hs0NxWCkbZ23QCBv0iF1WoTo1MdzYSN+VS4HZgyqTDp8dr8zT1HMR55uVDFLwc1frE6G5C2O5ItF0HW6+uxL3Ge7YbWHkRI1b/LKz0P2CFuT2AiqeaoQmlHAfykIJ0sdbagUrM0ABcD3A892Gaf7QmH5xWM4E2iDjQZ2GUuWk3skE3XImM3DzIWszw6dL9baSKifiK7Bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DB9PR08MB7129.eurprd08.prod.outlook.com (2603:10a6:10:2c7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Wed, 8 Dec 2021 17:36:41 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::25f9:a7e6:422a:da43]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::25f9:a7e6:422a:da43%6]) with mapi id 15.20.4755.022; Wed, 8 Dec 2021 17:36:41 +0000 Date: Wed, 8 Dec 2021 17:36:38 +0000 From: Szabolcs Nagy To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 8/8] nptl: rseq failure after registration on main thread is fatal Message-ID: <20211208173638.GL3294453@arm.com> References: <354a2d43774aeca68104a6230caa4be7141ed43b.1638880889.git.fweimer@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <354a2d43774aeca68104a6230caa4be7141ed43b.1638880889.git.fweimer@redhat.com> X-ClientProxiedBy: LO4P123CA0240.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::11) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 Received: from arm.com (217.140.106.51) by LO4P123CA0240.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend Transport; Wed, 8 Dec 2021 17:36:41 +0000 X-MS-Office365-Filtering-Correlation-Id: 2ad4851e-f0ae-4c32-4e5d-08d9ba715856 X-MS-TrafficTypeDiagnostic: DB9PR08MB7129:EE_|DB5EUR03FT003:EE_|AM6PR08MB3079:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6790;OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qlzVSFUsHjYNQE7PBy0c2SEqLjzBaskeJLsLYQMo+4VZgdry05XC58MfXhzwsnl6TurXIRMMlTPiG8LOeftnkU1bSQgwhVePK14QanTVfQH1rPpCJrORGUquAnE1F+NVbKCf0r9wgoRoSFbMzaVCdRQYe6T5dGiSh9QmLznCjsl152dg0Aw1Y6pIWNZgNKeX3SPeUyL05t3h3aYjt6JzP1mO3/lt4fjf9XFswTh9hkACLvZkA1OR5cv8xq/+6TW2bqll0+bP3sULvQasmWvLHb1h5PvsIG4L2IrdVBwzPEzFLPp/rCzJYoBvMRMQRs7IfCF7MYGfcQL1q2o3MDEA2ljVSEz0j3EcHU8JUXh69HwWddSSJOSjOAEDD4Vfx+BNOXs+ZVLtpOoYOzGCfStdTwGdmPQpbbjb3KPaFvSPus6r6ZJb+vBp3bDjbg+7cv6979pum02dEkCoLtcGhGjhntjPyjG00yCNashnplpyGhTnKOi0DIY+xXqOHM0IF7tOO2imu+laUSAoi8VMu9uEaK3Jit+Oa6GU6OzB5HOZ1N/AjhnhernyF4W9Y30Otgxyyvbj1sER1TewC1quFJMce1wBhs6lHZUuFq7cGmrUqjIR2j5ljtYWSWpcx+BOD4Pic6h4H73R9ur/UoP5qnltFHqix6uGWuxRaBDEXnHbFYUgWZprlCSHnJMUzlSvmEP8Qp4Xk0O0CQWlEOJoe0IRdTBCk6tKBbLkCBB9rjX1IolgKCQ8ffckhGWv1/lfQfUoX3h6eHFbVD0Zous1b1mqVQsx60TWxrwbw4MFRD782mIIsWa66DnHD8iDP0o9a5J0 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR08MB7179.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2616005)(5660300002)(8886007)(956004)(66574015)(55016003)(316002)(66946007)(38350700002)(6666004)(186003)(4326008)(26005)(66556008)(83380400001)(8936002)(36756003)(33656002)(66476007)(508600001)(8676002)(52116002)(44832011)(38100700002)(1076003)(86362001)(7696005)(2906002)(6916009); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7129 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cc26aef8-bad6-4d3b-6dca-08d9ba714b8d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 47y+ljI7IGX5PwIoj8vMwdrAJfNOmTZTTEG2UhTOBc2gXa+zeOokZiNgowSnv7NrpBqUXGSxvueUSunub4wi2l7qV+s+6mSLkSXJvOZRQWEWi+1yg1oHFHWrjfeND8vCtZWASxHgoVao7MyvR3+B/pjhUInj0jvZDpMtrFvDGGSbssWNMNBnUIWbztP1aDSIu0N4I2h95ht3P2YbAyS9Ylgs+hZXYZV4uf5IH0QOsimte5SEt0pOUyB/FTePa9li1ZmsgoNwsEFSzQLztZHkKEgrRY+0ScTFhQKJFaczNEviHm84m2Dy/YAlx2Xjd9MehdtkQ3ukixong0qHlvtqGdh4XLminMSPsV/His9KkUPYQ8UIvhSH98lW9sk5yzo2ZaMenGfNZFd+Z9NWnYBqa2OymQ+Bwgp0x626N0un3MXjbMb0qG/DQLHK5JdHsFVMVcwQbyrg5TGHdTsgwQEzNUZBgpqtSEfBEvvTmNYnyIAyMeokVZHw7PKZhKvPYiDzrj9tzk30ASwIqPLed2dNMaoFyQzDsiZKH3FK2ZgVHYSy8g1XiIyG0o78MH0ivhPNa/AGM/VsB1LLeVw/OrymiOFrPKNO18K5urhjrDXCLPCPoy2kItxDSdtuVH9aUivqHp07/WPU9TsCeCAtMCrz0AIdvnwD3yFZXx2ULgTuOG+hfzphyOd/0DR+MMEZ4aWn+TYHjdbEOxh99Tei5jCBrB2hY+EW0ujnfdGvcOfOB75hFpa+1w9TtZwqoM91+ySggHGGeHrq+J7Mg3opQjpa4ZDsGcRe9X4WCHNuYWcktTYlMjlyz8jF86G9YJk08i+W5k0xnw5pey+4MoqWpLszngxmAtqcmRlVZ/PMQM7OA4o31ANvmsPMruWCSisVG18g X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(40470700001)(186003)(70586007)(70206006)(33656002)(6862004)(5660300002)(66574015)(47076005)(8676002)(956004)(55016003)(2616005)(2906002)(82310400004)(36756003)(1076003)(6666004)(86362001)(316002)(4326008)(36860700001)(44832011)(26005)(336012)(40460700001)(508600001)(8936002)(7696005)(356005)(83380400001)(8886007)(81166007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 17:37:02.5662 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2ad4851e-f0ae-4c32-4e5d-08d9ba715856 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3079 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS, TXREP, T_SPF_HELO_TEMPERROR, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2021 17:37:07 -0000 The 12/07/2021 14:04, Florian Weimer via Libc-alpha wrote: > This simplifies the application programming model. > > Browser sandboxes have already been fixed: > > Sandbox is incompatible with rseq registration > > > Allow rseq in the Linux sandboxes. r=gcp > > > Sandbox needs to support rseq system call > > > Linux sandbox: Allow rseq(2) > > --- > v2: New patch. Tested with Firefox 94.0 on Fedora 35. looks good. Reviewed-by: Szabolcs Nagy > > nptl/pthread_create.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/nptl/pthread_create.c b/nptl/pthread_create.c > index 4608fd9068..c097fc54e6 100644 > --- a/nptl/pthread_create.c > +++ b/nptl/pthread_create.c > @@ -370,7 +370,8 @@ start_thread (void *arg) > /* Register rseq TLS to the kernel. */ > { > bool do_rseq = THREAD_GETMEM (pd, flags) & ATTR_FLAG_DO_RSEQ; > - rseq_register_current_thread (pd, do_rseq); > + if (!rseq_register_current_thread (pd, do_rseq) && do_rseq) > + __libc_fatal ("Fatal glibc error: rseq registration failed\n"); > } > > #ifndef __ASSUME_SET_ROBUST_LIST > -- > 2.33.1 >