From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2068.outbound.protection.outlook.com [40.107.20.68]) by sourceware.org (Postfix) with ESMTPS id 25DD73858C39 for ; Thu, 9 Dec 2021 12:26:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 25DD73858C39 Received: from AS9P194CA0006.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::6) by DB6PR0801MB1829.eurprd08.prod.outlook.com (2603:10a6:4:39::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec 2021 12:26:48 +0000 Received: from AM5EUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46d:cafe::44) by AS9P194CA0006.outlook.office365.com (2603:10a6:20b:46d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend Transport; Thu, 9 Dec 2021 12:26:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT063.mail.protection.outlook.com (10.152.16.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.22 via Frontend Transport; Thu, 9 Dec 2021 12:26:45 +0000 Received: ("Tessian outbound 9a8c656e7c94:v110"); Thu, 09 Dec 2021 12:26:45 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 348db0b5f8391915 X-CR-MTA-TID: 64aa7808 Received: from a37cb06d4367.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 01F219D8-813F-4894-A947-81010C7B834F.1; Thu, 09 Dec 2021 12:26:28 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a37cb06d4367.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 09 Dec 2021 12:26:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A0YMREBhjiV2xiHDsJEEeXVD2dwOMO4EXyn882kLfM3yoR7Ti9RRW9a0y7fwRITbyGXqVCaQTeiFJofPeHlGHkGgReSRt221FSI7lnBZ6QBfxk6AjQ3e98deC5ZRHulGGEgzYP6Af8EogGseF7xB5gAo9yDIc0aw0RzkQHas8gHW77x5RTQsWehAgOyFSxiJv+81Kpfp9wUKU2lMl6Zn5rXlJc+67k4U0H0N3ElhkmiMjeyjCTd0gD3rka1zqk0IoL8bUI85XL6vkl83vlmKiNy3tgT/tCDPmQxI++Akj2ZxDa2Rm8SdeXjCaXSlPULLJRXC1M9S0ynozor7iID1LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oPrAmBAMwF88a2Ta/03bdZcdYelZ2hu9oWWxV+oJUP0=; b=cR/44j9+lfLL3faB7J7C9+FT3hwR12YQ5dpdOaEdOIQ4jGYFQSEGUo33IoCfFsF6SRrvB6G1b6Ck7QxsSAxgGx9lYIHABm7HmGDOftMgU5fGn5qhhsWGbXrEX/kt70XPRr5miYq6yhOq658qxgXVRhgZTsr5+lauBUdIs2fOWB2OBrMj7MWt+5MZpEN6E74rH8yRj4MsiLK9YYnztJh9vHlE+46HAhDgE6yxPfwOY9zspMO+77ECNKaT0ENo55nrtJ9SbAvF4f4k1Ca/XeTCdOkjbJWecodEwWQouVQxrYebbAayPYtfJ2UeDdFBo22A9SAiknPhh8zH6XErKifbUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DB9PR08MB7494.eurprd08.prod.outlook.com (2603:10a6:10:36d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Thu, 9 Dec 2021 12:26:27 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::25f9:a7e6:422a:da43]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::25f9:a7e6:422a:da43%6]) with mapi id 15.20.4755.022; Thu, 9 Dec 2021 12:26:26 +0000 Date: Thu, 9 Dec 2021 12:26:24 +0000 From: Szabolcs Nagy To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 7/8] nptl: Add public rseq symbols and Message-ID: <20211209122624.GO3294453@arm.com> References: <67665bb0d00cd540def5bfe758c94c98458536df.1638880889.git.fweimer@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <67665bb0d00cd540def5bfe758c94c98458536df.1638880889.git.fweimer@redhat.com> X-ClientProxiedBy: LO2P265CA0426.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::30) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 Received: from arm.com (217.140.106.49) by LO2P265CA0426.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend Transport; Thu, 9 Dec 2021 12:26:26 +0000 X-MS-Office365-Filtering-Correlation-Id: 7794b8b7-3465-4de9-ba07-08d9bb0f2a23 X-MS-TrafficTypeDiagnostic: DB9PR08MB7494:EE_|AM5EUR03FT063:EE_|DB6PR0801MB1829:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4714;OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dQAkm6B+I+OJKYijLgSJueUFL90BpEfsQiDnbdcDpGEly9Sbf0GfHzOnUaI7lVd9rwBnISJjR6VsVejCh4Rbq/NuB9R/4DqSGeSpsiWME3vujDS754wVIf/aHdmYRpG3fa2tMS7eEEY+xWPjXcYwukKlHUBEJXtNjy8blx4I+muJ5jrltVpvpFjNckhvTg+9Nwn85dAgyj78ul1jARwPO08IVzO5JNHgCeQQ9kNFjEIjppN2Xh3hRUKNPKNlNF8iAXh/wk279YXKIVyWprZKk+mD/b+GtEeFF1cmcA6CR8JV2qkiyfJD6YNgnC2t5Zc+EKu0jDDwVeYq/6EYKhPUByQW1jSBL7r2Ig//KN8kXpctMmo2/v/rdqrn8tMreCPykKlcifM8y2criI6Jw7WEupuRquW3ROPbGWEtFvq2V7DdAf6ZO5EdohOidAPKG6hw7/5zuWWqHer/MShAFQ6d+udm5/NaRxmux56lqfRnkzZTA3tiJ9bRoln2zkl/xXQsCYIprDSPF2A3M0glJARYiZVhTb3YUlkLJ3knTeykvkq2KtR/xz4HlFdpOQWW4jmrLNpuz0cwXDPRLfha6bvh4cp70cmr4hGq4q0DbnhNEeTPfQVuKZNphqP8W2bIVBXTwwtDl6YtaJcCn5agnJhUAIsfCLyi1pOWBnq4EsGE+QtgTANUBMNnILXfHjD/d+c55vRWwl+j6Xn1pzrX8k1G6A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR08MB7179.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8676002)(508600001)(38100700002)(1076003)(186003)(38350700002)(52116002)(66556008)(66946007)(55016003)(316002)(36756003)(2906002)(5660300002)(26005)(83380400001)(7696005)(44832011)(8886007)(33656002)(6916009)(2616005)(66476007)(86362001)(4326008)(956004)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7494 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bbcf3342-92af-48d7-93a6-08d9bb0f1ee4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A2mzg19XeEdDLG3kgynW/6cW6RVhl435DuONpGsFGKGK8yo+USQiah1b9ZhDtzR5bfWrM7UaYFYpkiU7zx9Pvqik0sNuUVqoJ8J7z1avh2fRQ4wg8txIYO2Px11cxQSLvFpzXdd4v98F3QcYXAAf2/tXptxhWxfA+Osm9eHIWnnWTDOJ22YDs1oXXk4WY2B5sO9eAOdWRmor1D+B6NwKG/Kp5A2qreLrAa2znM+DSRRVvlljeDwf8pUBGZrBzkCNbMFByyMwWOIVEADF4CIaR0tg+i4VqKWuQVoL7tRNQUUWTe06H9Mi0Kw8fvdncO/YXfjA/C/g5muUHzw8DDpKk2dA6B0mIogWCW/OwC933huAOulV2xiKnS9naDWnpAXkz2qHBe6dRwR/q9v1EEUMePeA/aKbsVe8Oi/AoKSCdrS/JR5YujqL7hNwe4kt5c9Ui1hUeGD/674z8W4Rsjm50cf2oA6LEnNfRuJ/Hhl5p6p1swqLrJzQWmtwa7K1tYThUipbtWotpybfEs+hPwkDSCnJlLEFUg5zYsN7KhYhMEn5vu32FSrAASNfH47ML5HXuRTDwGTvMv9xjZinG3UwquBLumf/QpEdKhs9zLqIAF7hycAyaNAzhtuDjjJszwXohjDMeu+pFh0kEYjJaKQn8xXxzgcJnbTGxruiwrtFCWV1HDTHYgb3zkyVChTBZbnFNSHbFDW+8RtnZmLnlIvb+jO83B9+E85af78gR1bUv2FbGHPazhHx/DBl+pNddKxrAo74a3zCAQxBQrWPHBcKwQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(40470700001)(33656002)(86362001)(26005)(36756003)(47076005)(316002)(2906002)(508600001)(44832011)(70586007)(5660300002)(83380400001)(336012)(956004)(8676002)(82310400004)(1076003)(70206006)(55016003)(4326008)(2616005)(356005)(8886007)(186003)(36860700001)(6862004)(8936002)(81166007)(40460700001)(7696005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 12:26:45.4860 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7794b8b7-3465-4de9-ba07-08d9bb0f2a23 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1829 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Dec 2021 12:26:55 -0000 The 12/07/2021 14:03, Florian Weimer via Libc-alpha wrote: > diff --git a/sysdeps/unix/sysv/linux/tst-rseq.c b/sysdeps/unix/sysv/linux/tst-rseq.c > index 926376b6a5..572c11166f 100644 > --- a/sysdeps/unix/sysv/linux/tst-rseq.c > +++ b/sysdeps/unix/sysv/linux/tst-rseq.c > @@ -29,12 +29,20 @@ > # include > # include > # include > +# include > +# include > # include "tst-rseq.h" > > static void > do_rseq_main_test (void) > { > + struct pthread *pd = THREAD_SELF; > + > TEST_VERIFY_EXIT (rseq_thread_registered ()); > + TEST_COMPARE (__rseq_flags, 0); > + TEST_VERIFY ((char *) __thread_pointer () + __rseq_offset > + == (char *) &pd->rseq_area); > + TEST_COMPARE (__rseq_size, sizeof (pd->rseq_area)); > } sorry i just tested the committed patches on 32bit arm (on 64bit kernel) and there is a tls alignment issue FAIL: nptl/tst-tls3 FAIL: nptl/tst-tls3-malloc FAIL: nptl/tst-tls5 outputs: initial thread's struct pthread not aligned enough initial thread's struct pthread not aligned enough pthread_self () = 0xf7e2d350, size 1408, align 32, WRONG ALIGNMENT and rseq registration fails with EINVAL causing FAIL: misc/tst-rseq output is ../sysdeps/unix/sysv/linux/tst-rseq.c:45: numeric comparison failure left: 0 (0x0); from: __rseq_size right: 32 (0x20); from: sizeof (pd->rseq_area) error: 1 test failures strace has ... set_tls(0xf7e41e30) = 0 set_tid_address(0xf7e41918) = 1181659 set_robust_list(0xf7e41920, 12) = 0 syscall_0x18e(0xf7e41e10, 0x20, 0, 0xe7f5def3, 0xf7e418b0, 0xf7e41e30) = -1 (errno 22) mprotect(0xf7df6000, 8192, PROT_READ) = 0 mprotect(0xf7e15000, 4096, PROT_READ) = 0 mprotect(0xf7e44000, 8192, PROT_READ) = 0 ugetrlimit(RLIMIT_STACK, {rlim_cur=8192*1024, rlim_max=RLIM_INFINITY}) = 0 mmap2(NULL, 8, PROT_READ|PROT_WRITE, MAP_SHARED|MAP_ANONYMOUS, -1, 0) = 0xf7e40000 getrandom("\x44\x21\x97\xf7", 4, GRND_NONBLOCK) = 4 syscall_0x18e(0, 0, 0, 0, 0xffc1be68, 0x1) = -1 (errno 22) write(1, "../sysdeps/unix/sysv/linux/tst-r"..., 69) = 69 write(1, " left: ", 9) = 9 ... 0x18e is __NR_rseq and errno 22 is EINVAL.