From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2081.outbound.protection.outlook.com [40.107.21.81]) by sourceware.org (Postfix) with ESMTPS id F2084385840C for ; Mon, 13 Dec 2021 11:36:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F2084385840C Received: from AS9PR06CA0007.eurprd06.prod.outlook.com (2603:10a6:20b:462::19) by AM6PR08MB3206.eurprd08.prod.outlook.com (2603:10a6:209:46::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Mon, 13 Dec 2021 11:36:10 +0000 Received: from VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:462:cafe::f8) by AS9PR06CA0007.outlook.office365.com (2603:10a6:20b:462::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11 via Frontend Transport; Mon, 13 Dec 2021 11:36:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT055.mail.protection.outlook.com (10.152.19.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Mon, 13 Dec 2021 11:36:09 +0000 Received: ("Tessian outbound 1cd1a01725a6:v110"); Mon, 13 Dec 2021 11:36:09 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d791a4b42f2a2657 X-CR-MTA-TID: 64aa7808 Received: from c3e28191971b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3C72834D-800F-401B-B0AC-23F06170827F.1; Mon, 13 Dec 2021 11:35:58 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c3e28191971b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 13 Dec 2021 11:35:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ANCsgz5stJ1+TVcgCudlQkzC4l/fVePi/1j2p2dH4H5FshcjGHkk1HzaTXpS7pWzbqqCr3Uw1xMDceL3N9SY3HX/qW0hFe54ZoRrYsAaSNEMYOMo8KvuBNC6FMXZtO5o54VArd/L0OySv/Orw5Zaf9yFK5I88CuQ9A9gd7mNf1QQjTvSUFehS8WgO9gzTePPTQFUt2GHAE5sgJCS1gp+Wt2fmBEoVGg6MqBJYG6IAdW7wOb9Wel+0nfcfbqM6B3VOsPUh/qaXlmmtpy5eYDunWnZElYdKn6llJo16RkKDTToZIoen+SzZrE9gLiw7BHEureh8sp5oyhohCLQhHtaQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kqRZfUgES0HPhpLFR8ONXQ44anyp3JCxJx0HcvuZdY0=; b=TN42he1V73bGoohDj2U7kKT/vNomcQr2/8y9i3w7Bn3o0Mlg0htatPf+pud8FKsa8kIVE8Ovlxr7VdAZ7NRkLUtDFKU0fCRJQaI+SippLYwXKoMGFGoDeIe6T89mrQ2IuZbPVsNACzM5Cd8FoSIgBZgEZzbIRNvzbiZEGDRBNxQiHBHZUCUov6q/o/louNmR5ME1IEOcJB85pHDi8o0cka3E2ZM6TipmNADwyE/kTX23H+uVzIEREwpXz57nne1+736Rr5xH7FlKqY+pQ8obrtgJN8UyfmLze1fDsVMgVPCt7f0yE8hcJ1odLGPC96AHZxwYesfJkP1pwOVBwahpNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DU2PR08MB7288.eurprd08.prod.outlook.com (2603:10a6:10:2d7::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.13; Mon, 13 Dec 2021 11:35:56 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::25f9:a7e6:422a:da43]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::25f9:a7e6:422a:da43%7]) with mapi id 15.20.4778.018; Mon, 13 Dec 2021 11:35:56 +0000 Date: Mon, 13 Dec 2021 11:35:54 +0000 From: Szabolcs Nagy To: Florian Weimer Cc: Rongwei Wang , libc-alpha@sourceware.org, hjl.tools@gmail.com, adhemerval.zanella@linaro.org, xuyu@linux.alibaba.com, gavin.dg@linux.alibaba.com Subject: Re: [PATCH v6 1/2] elf: Properly align PT_LOAD segments [BZ #28676] Message-ID: <20211213113554.GU3294453@arm.com> References: <20211204045848.71105-1-rongwei.wang@linux.alibaba.com> <20211213025103.48472-1-rongwei.wang@linux.alibaba.com> <20211213025103.48472-2-rongwei.wang@linux.alibaba.com> <20211213110522.GT3294453@arm.com> <87sfuw21qi.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87sfuw21qi.fsf@oldenburg.str.redhat.com> X-ClientProxiedBy: LNXP265CA0081.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::21) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 34db893a-51dc-40b9-12d3-08d9be2cc264 X-MS-TrafficTypeDiagnostic: DU2PR08MB7288:EE_|VE1EUR03FT055:EE_|AM6PR08MB3206:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8zgiaZBLe1kxZdz4WEU0Xa8woHl4BZwIgfrXBQsIq3yVeaxYt4cEuwdpI6Q4JfeaZbCZL2IZiyvhJvr34OfWxEOpSGDD5J7naDUXZZsZnj9hefyTGsv/9+MP9RcJjrkikzIDHdc33wSIiGZoAayex7axiPy+AvS2rNAQwLnRO6KnDfQwbbpdYdaEdgCtVGyTdDj8OLld5AaSYBUmX0Uf49lXjCyveQAzt/RK0mXvpHjVP/LK97UIDc10Kw0iMtPVUWvqT7zVs2RUHpLqblPARyJfrF/INzq+cALG+P6DsJjsY7z5vnNoBYDWviIabED08q43GPindLaCj6TC3OK9abCxgiQknBodyGbwqO+vSZldZpAquVJcxwCN6NUrDs8gkYzq88XP95UvqORLKXGKrGLWH0GuUt1ha9f5agPxaeLaY+VoQIj2+1e+ZBF+HmR1Gs17FkqwLdV7Sbam2B/r7dj0zRwoeehWGl6AuDOwK9QxnuMc3AwEnCzkW2ZmM+2LaThm0kfKqJRaUUzr1rZjeJLZl77Q+vw05fSNzRuWvxA32GeJyG3wvytThVAxnHTHswatsPAQRaL3JX7fAn3UGJMuDx9EhSL6mXEIbS+huApAK04VESJASjnafRhc0alZSTZfUOqL3rYLZ23rILXanT31ATdVviWiIh4n+j+euJLC1boPRgGlXtXIg9x0jpQ0rNd1om066Yldqam3GOONoA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR08MB7179.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66476007)(8936002)(508600001)(8676002)(83380400001)(52116002)(316002)(6916009)(26005)(66946007)(44832011)(2616005)(1076003)(5660300002)(2906002)(186003)(6486002)(36756003)(6512007)(33656002)(38100700002)(4326008)(86362001)(66556008)(6506007)(38350700002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7288 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9319b641-6560-488f-a86e-08d9be2cba44 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mA/FV+y0VMzsfvETgOXfFKRdxz6Ue3tlSG0CiOwxvZi5hnx4ogvpW/wpa9+wObO+k5o09eAA/rmGm+nPGXXv2fsYVEVqd6mwJEw/TG0oFVQF0jWcnJvma2s7jpS1Nu/OimbfMRv/WX2OpWuw9JCXYZGRzMbwVu6fIk9q3EN0+2QGqfEhdayvpc13dB96IZd3au/QY7MHcY5oojGnzGxZ5Wb4woQEkSx7cc73Pjd+w5ilK1D3bO6yYjBcK61RYBfBFoIZP4oB/XH2qscSyQJnz64J/MF2EUF4Q2nMjmZhwgh0TyAt4cz+TqhPIUaeh4aqTaTwF3je7hM0bYgtV1xRlD3/NkWoN7YYCjE50itp9hI+35FwxcItvFC5c4hsSj/DRqNsTxezyxIYFjgDrJVoQAkGEIIpoJ9kYa7bfdsYyqwz95CtFqYPa59mo8Cl0we/p65BCugDuies9rBYeX8npmV+4hl6xWcPDI5kbRFsunSsc2w/QbwDHGuehJd7A0TR1v7XqxU+NRuwnZ4TPLiN1I5xJeGM5kttk4cH+e6fvgTf6e0vKYPMbdnPsC+jxZkyx+EfVftU64ifOncYtob+Y7KmUOAPfDVIAysp/dqFqQ7AUO8LoHj4MBer5QGp6+AkmRiurzMvujDOF/yIQPA/FQGthm+YzW1x0bzuFHJtSJpVqnWOU7Wo467+1kIj+bPdH94yVbBP10QJ624/UeSYmA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(2616005)(2906002)(5660300002)(33656002)(1076003)(83380400001)(82310400004)(26005)(186003)(6512007)(86362001)(8936002)(47076005)(8676002)(6486002)(4326008)(36860700001)(81166007)(36756003)(336012)(107886003)(6862004)(508600001)(70586007)(6506007)(356005)(316002)(44832011)(70206006); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 11:36:09.7718 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 34db893a-51dc-40b9-12d3-08d9be2cc264 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3206 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Dec 2021 11:36:17 -0000 The 12/13/2021 12:17, Florian Weimer wrote: > * Szabolcs Nagy: > > > The 12/13/2021 10:51, Rongwei Wang via Libc-alpha wrote: > >> When PT_LOAD segment alignment > the page size, allocate > >> enough space to ensure that the segment can be properly > >> aligned. > >> > >> And this change helps code segments use huge pages become > >> simple and available. > >> > >> This fixes [BZ #28676]. > >> > >> Signed-off-by: Xu Yu > >> Signed-off-by: Rongwei Wang > > > > > > since this commit nptl/tst-stack4 consistently > > fails in my 32bit arm test environment with > > > > pthread_create failed: 11 > > pthread_create failed: 11 > > pthread_create failed: 11 > > pthread_create failed: 11 > > pthread_create failed: 11 > > pthread_create failed: 11 > > pthread_create failed: 11 > > tst-stack4: tst-stack4.c:69: dso_process: Assertion `handle[dso]' failed. > > Didn't expect signal from child: got `Aborted' > > > > i suspect it simply runs out of memory. > > > > if this change pushes memory usage of the test > > above 2G then i think either the test or the > > patch have to be changed so 32bit targets can > > still run it reliably. > > What are the p_align values of the involved objects? I would not expect > any changes on 32-bit Arm because p_align and the run-time page size > should match there. p_align is 64K and i see a lot of close to 64K PROT_NONE mappings left behind after many dlclose which creates a lot of vm fragmentation when dlopen/dlclose is called in a loop. (i think the mapping is at the beginning or end of the lib as some kind of padding and left behind after dlclose, but haven't confirmed this yet)