From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60061.outbound.protection.outlook.com [40.107.6.61]) by sourceware.org (Postfix) with ESMTPS id 1AD42385840D for ; Mon, 13 Dec 2021 11:52:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1AD42385840D Received: from AM7PR03CA0012.eurprd03.prod.outlook.com (2603:10a6:20b:130::22) by AS8PR08MB6661.eurprd08.prod.outlook.com (2603:10a6:20b:38f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.19; Mon, 13 Dec 2021 11:52:33 +0000 Received: from VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:130:cafe::bc) by AM7PR03CA0012.outlook.office365.com (2603:10a6:20b:130::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17 via Frontend Transport; Mon, 13 Dec 2021 11:52:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT037.mail.protection.outlook.com (10.152.19.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Mon, 13 Dec 2021 11:52:33 +0000 Received: ("Tessian outbound de6049708a0a:v110"); Mon, 13 Dec 2021 11:52:33 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: dc6ab291f0bf86a3 X-CR-MTA-TID: 64aa7808 Received: from d0b9d6ebfede.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CDD17362-2CF0-4E7B-8E18-9C704376A783.1; Mon, 13 Dec 2021 11:52:15 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d0b9d6ebfede.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 13 Dec 2021 11:52:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hlv3Kz3/4gMIN80Kl9JbWRk2IOI1UZ0vy9BGY1+EnC3MwURZzfK5v6A8mb2ydVRVJ8Z0Tn0FDeaH4xjVDrwcnPK3RVRdwT+YEV0Y5qUUx01FyHhSmyxZwHxpGaPcm5NzneRZw84q+6JLUMEY6BuOtOmXDq4QcOwm9LSMY9M6+GG7cZnXpBhgBiyf/un87aSDUt/sT3DeB3kHywmv9Xa1qJ+MfVE+oLr48gP6qDwf/6Tq8xIjLcOIvVAsW9j9//jcdMa819x/7VnpzDdnm9hazolcAGnHPMV4yMGZzaJFfUcPrDZ9AbCZ8VBwzmG5fHgWrYDkd1iPOyoon3osXGq6bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eqW/owNprOFIjWfKvvGL9GRX67ydjAvD+ayxagfUWdc=; b=iCDUMDSCWaWcM0S7FhOhtjsgunkMNVcqixRmsm3EoKDIvPdL8JRvuI8D2ABUMtkVUAyMJWVtuYGwCi9iwBjqRNsawWmaq9v6ih+eJMhaXJu6yYFc/K54HU2TRtEwBNwDLL8pevU7/8FSncFXY7cipGqc9dxf2X1laecTf0kE8+OnH+i05SvYwmy1/zbG0BsS7BLEpepBilAjEPiuXi54J+b9qDAQQg+kz3+6uPEWXP+aXQWEFRFMZO36sZWKUy3RfNmV+Ic+Eb4h6R6lmOc5q9sjv2XNrue2my+DGBQ5JphhtSg5vHfhrZO97HFlSSlTpkeRYo035WM8J/L2xvXZ3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DU2PR08MB7285.eurprd08.prod.outlook.com (2603:10a6:10:2d4::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Mon, 13 Dec 2021 11:52:13 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::25f9:a7e6:422a:da43]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::25f9:a7e6:422a:da43%7]) with mapi id 15.20.4778.018; Mon, 13 Dec 2021 11:52:13 +0000 Date: Mon, 13 Dec 2021 11:52:11 +0000 From: Szabolcs Nagy To: Andreas Schwab Cc: Rongwei Wang via Libc-alpha , fweimer@redhat.com, xuyu@linux.alibaba.com, gavin.dg@linux.alibaba.com Subject: Re: [PATCH v6 1/2] elf: Properly align PT_LOAD segments [BZ #28676] Message-ID: <20211213115211.GV3294453@arm.com> References: <20211204045848.71105-1-rongwei.wang@linux.alibaba.com> <20211213025103.48472-1-rongwei.wang@linux.alibaba.com> <20211213025103.48472-2-rongwei.wang@linux.alibaba.com> <87h7bczq0q.fsf@igel.home> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87h7bczq0q.fsf@igel.home> X-ClientProxiedBy: LO2P265CA0192.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::36) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 26248a07-95ca-446a-8f36-08d9be2f0c9a X-MS-TrafficTypeDiagnostic: DU2PR08MB7285:EE_|VE1EUR03FT037:EE_|AS8PR08MB6661:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:5516;OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nY+u1Zp8C1AWOSVNkaovGmBG59kPOCxc4M7gfX6vr2xL3SvpVVrcSJInETaveqWuQckIWsFuga9qOMhUr2fv2hoWp5o1IItaSq7NzOjVSv9D/NoRjzY5KszOtzhglv1677vLWWItHPjfwxQYA3/JNq+woPfB+tX9GPEBgC008sMVhwYsHJiCnUBwyuOWi8Vx//ZRYAYZIYJr1gu3BubWHtbbN48wE6m42WFR2GoyEPdXLUrdGekPSEFir/sLNw9EweVUDPT7fCeBfiLBEgKXsh2OBOC8kC7m2DCw6CjHjme72yS4Vr4ii67KpRhmaUlfFwgWYRkQiX9BY17fEV/daRNEQV94mnVi79y5vHwd/+ZO1Kiy7gArW3AigIKPD9fDVYyQF593yGoghkd8xf5yxQ6yfclApjEAMjyFlxXXdz9NXm5SUUqGO8EL3WAfHOKsqs4c1KnNIw70Azi5+nUMuOTLlLPAn/DOpsSMnqTiB+sTH0iurlKwWCZHyjvSL+CrSZLk79rlLe7yjjYC5x/yxX3BneBwbk3tSxzyIX4P8+uNtp/DEcbZ79J55SdLfd0GWbDWjJ004aZpq/7quw5tYH2+rHBw1HbSEqSfuNaFaRQCoyKe9Vx9/sWoK9re80mknpa41pBSmiPijBUlR3amfaJ49dQOBmC6fYdOIzkROXRXwVLywwvaT521dWhFuoshYD4LuyEgHyYMVQikWwv2ew== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR08MB7179.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(508600001)(86362001)(6506007)(4326008)(6916009)(6512007)(52116002)(26005)(1076003)(186003)(33656002)(5660300002)(44832011)(8936002)(36756003)(8676002)(2906002)(2616005)(4744005)(316002)(66946007)(66476007)(6486002)(38350700002)(66556008)(38100700002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7285 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 37052955-3af8-419b-813f-08d9be2f005d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l3ybsFQyrYMj3CJXQUWLPW/QXpAHQKc6uLAoEepEaC9c4HpIV8FwnCFwzAEsh6pIl4f8KxrE2qFe5DPlOubzmkriwKsJgVmNT0BmGn4aHZULgBQ0xv8qVyOYesN+GAqZl1/4yNLsRlk9VzgaEjiisaObyxnrh41OaC9dqRSn5YY9AZ7jW8t80Tp6Z3ZT+fywtPGReeAYsMc+msKOF63D0y1njQ+AHk3G/Ci7EovFf7uL5P6VS4JAbAnlQkL6a6STZ0HpjAunR9cfJc/gccHolfQpUd5Gps2K/HDNvyWqi/2lyJ0xEvruYwDwTDjAou3T7FEWNyWGuDyvFDrf2ByMbk6NqXg4x6W4HUyel8oNOWGpihK1IoT6lXMXyBBm21Q4oSNsrYP7vZX55OBjM66qWaMok33/WeCYyQ59foBTPiNn8TJfzhXUS/PY1V+MQanEdyUU5py48KNzBwAmPlJm7+0pUTsgk4YJu/bycsI6nLOey+lXCduLTSQ9NaaNjxHhOfXnVhwZlE+U42bvAn1+MWIg8YLH+Fa61KfRi8F9Z2bCl6/JvGV9/Co/D8DsmpDVn78wnM5eGIIzXo6wGTrRkzGFYCb6/p1adb4C1FH31BAOyi0tgPeJb2XmmxdFulrPdBX0K6o5G1XOl17Y0x8M9N1SrQvHj2NAiF/bEgqrvrYbi8kkb6Cw72x3M3d6pBgysuvtO7PwAYM5yEfxCdt2UQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(36756003)(33656002)(47076005)(4744005)(70586007)(44832011)(2616005)(508600001)(6486002)(2906002)(316002)(86362001)(107886003)(186003)(70206006)(81166007)(6512007)(356005)(1076003)(36860700001)(8676002)(5660300002)(8936002)(4326008)(82310400004)(336012)(6506007)(26005)(6862004); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 11:52:33.2758 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 26248a07-95ca-446a-8f36-08d9be2f0c9a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6661 X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Dec 2021 11:52:37 -0000 The 12/13/2021 12:46, Andreas Schwab wrote: > On Dez 13 2021, Rongwei Wang via Libc-alpha wrote: > > > + else > > + { > > + /* Unmap the unused regions. */ > > + ElfW(Addr) delta = map_start_aligned - map_start; > > + if (delta) > > + __munmap ((void *) map_start, delta); > > + ElfW(Addr) map_end = map_start_aligned + maplength; > > + delta = map_start + maplen - map_end; > > + if (delta) > > + __munmap ((void *) map_end, delta); > > I don't think map_end is guaranteed to be page-aligned. indeed i see failing munmap syscalls in strace .. 3161105 munmap(0xf7973040, 57344) = -1 EINVAL (Invalid argument) 3161105 munmap(0xf79591d4, 24576) = -1 EINVAL (Invalid argument) 3161107 munmap(0xf6031038, 45056) = -1 EINVAL (Invalid argument) 3161108 munmap(0xf56f1038, 53248) = -1 EINVAL (Invalid argument) ...